From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337)
Date: Sat, 13 Jun 2009 14:28:23 +0200 [thread overview]
Message-ID: <20090613122823.GC3814@game.jcrosoft.org> (raw)
In-Reply-To: <200906130413.59441.david-b@pacbell.net>
On 04:13 Sat 13 Jun , David Brownell wrote:
> On Saturday 13 June 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >
> > > The machine_is_X() macros are automatically #ifdeffed in
> > > the header; no size impact. ?Read <asm/mach-types.h> ...
> >
> > If I use this pacth on the rm9200ek the u-boot.bin size will increase
> > for nothing
>
> I'm not following you. The lines are:
>
>
> #ifdef CONFIG_MACH_CSB337
> # ifdef machine_arch_type
> # undef machine_arch_type
> # define machine_arch_type __machine_arch_type
> # else
> # define machine_arch_type MACH_TYPE_CSB337
> # endif
> # define machine_is_csb337() (machine_arch_type == MACH_TYPE_CSB337)
> #else
> # define machine_is_csb337() (0)
> #endif
>
> ... and similar for EK. The csb337 config file sets CONFIG_MACH_CSB337,
> and nothing else does. Result: on rm9200ek, that test becomes if(0),
> while on csb337 it becomes if (X == X), where X == MACH_TYPE_CSB337.
>
>
> > If I was able to detect dynamicly on which board I will run ok
> > but it's not the case here
> > so please use
> > #ifdef CONFIG_MACH_xxx
> > #else
> > #endif
>
> See above. There already *IS* such an #ifdef, but it's just not
> cluttering up the guts of that driver.
you adding MUST have NO size impact on other board
if we apply you code as it we will increase the size of u-boot for every
rm9200 board that use the ethernet
so please do the ifdef on the ether driver
Best Regards,
J.
next prev parent reply other threads:[~2009-06-13 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 18:14 [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337) David Brownell
2009-06-12 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 22:02 ` David Brownell
2009-06-13 10:26 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-13 11:13 ` David Brownell
2009-06-13 12:28 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-13 14:50 ` Mike Frysinger
2009-06-13 14:54 ` [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337) Jean-Christophe PLAGNIOL-VILLARD
2009-06-13 15:13 ` Mike Frysinger
2009-06-13 17:19 ` [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337) David Brownell
2009-07-10 20:39 ` [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337) Wolfgang Denk
2009-06-12 23:02 ` [U-Boot] [patch] rm9200 ethernet driver: board-specific quirk (csb337) Ben Warren
2009-06-18 5:14 ` Ben Warren
2009-06-19 6:59 ` David Brownell
2009-06-19 7:01 ` Ben Warren
2009-06-19 7:56 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613122823.GC3814@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.