[U-Boot] [patch] rm9200 ethernet driver: board-specific quirk?(csb337)

[Wolfgang Denk <wd@denx.de>]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090613145439.GG25406@game.jcrosoft.org> you wrote:
>
> > i dont get it.  the CPP expands into if(0) and unless you have a completely 
> > shitty compiler, gcc will do dead code elimination on it resulting in the same 
> > binary size.
> I've seen to much "shitty version" that does not do it correctly
> so I prefer ot avoid the problem

There are zillions of places that rely on the compiler optimizing away
"if (0) ..." stuff. It is a valid and even recommended C programming
technique.

This is definitely no reason to reject a patch.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Space is big. You just won't believe how vastly, hugely, mind-
bogglingly big it is. I mean, you may think it's a long way down the
road to the drug store, but that's just peanuts to space.
                              -- The Hitchhiker's Guide to the Galaxy