All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection
@ 2009-06-13  5:22 Christian Couder
  2009-06-13  8:14 ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Couder @ 2009-06-13  5:22 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Sam Vilain, H. Peter Anvin, Ingo Molnar

This warning was probably useless anyway, but it is even more so now
that filtering of skipped commits is done in C and that there is a
mechanism to skip away from broken commits.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Documentation/git-bisect.txt |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
index ffc02c7..5d015fc 100644
--- a/Documentation/git-bisect.txt
+++ b/Documentation/git-bisect.txt
@@ -164,9 +164,8 @@ to do it for you by issuing the command:
 $ git bisect skip                 # Current version cannot be tested
 ------------
 
-But computing the commit to test may be slower afterwards and git may
-eventually not be able to tell the first bad commit among a bad commit
-and one or more skipped commits.
+But git may eventually not be able to tell the first bad commit among
+a bad commit and one or more skipped commits.
 
 You can even skip a range of commits, instead of just one commit,
 using the "'<commit1>'..'<commit2>'" notation. For example:
-- 
1.6.3.GIT

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection
  2009-06-13  5:22 [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection Christian Couder
@ 2009-06-13  8:14 ` Stephen Boyd
  2009-06-13 11:13   ` Christian Couder
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2009-06-13  8:14 UTC (permalink / raw)
  To: Christian Couder
  Cc: Junio C Hamano, git, Sam Vilain, H. Peter Anvin, Ingo Molnar

Christian Couder wrote:
> -But computing the commit to test may be slower afterwards and git may
> -eventually not be able to tell the first bad commit among a bad commit
> -and one or more skipped commits.
> +But git may eventually not be able to tell the first bad commit among
> +a bad commit and one or more skipped commits.
>  
>  You can even skip a range of commits, instead of just one commit,
>  using the "'<commit1>'..'<commit2>'" notation. For example:
>   

Can this be "git may eventually be unable to tell" instead?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection
  2009-06-13  8:14 ` Stephen Boyd
@ 2009-06-13 11:13   ` Christian Couder
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2009-06-13 11:13 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Junio C Hamano, git, Sam Vilain, H. Peter Anvin, Ingo Molnar

Le Saturday 13 June 2009, Stephen Boyd a écrit :
> Christian Couder wrote:
> > -But computing the commit to test may be slower afterwards and git may
> > -eventually not be able to tell the first bad commit among a bad commit
> > -and one or more skipped commits.
> > +But git may eventually not be able to tell the first bad commit among
> > +a bad commit and one or more skipped commits.
> >
> >  You can even skip a range of commits, instead of just one commit,
> >  using the "'<commit1>'..'<commit2>'" notation. For example:
>
> Can this be "git may eventually be unable to tell" instead?

Yes, I just sent a v2 with this change.

Thanks,
Christian.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-13 11:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-13  5:22 [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection Christian Couder
2009-06-13  8:14 ` Stephen Boyd
2009-06-13 11:13   ` Christian Couder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.