* [PATCH 1/1] jffs2: leaking jffs2_summary in function jffs2_scan_medium
@ 2009-06-13 21:06 Christian Engelmayer
0 siblings, 0 replies; only message in thread
From: Christian Engelmayer @ 2009-06-13 21:06 UTC (permalink / raw)
To: dwmw2; +Cc: linux-mtd, christian.engelmayer
From: Christian Engelmayer <christian.engelmayer@frequentis.com>
In case of an error returned by file_dirty() 's' is not freed as the cleanup
path is skipped.
Signed-off-by: Christian Engelmayer <christian.engelmayer@frequentis.com>
--
Reported by Coverity.
--- linux-2.6.29.4/fs/jffs2/scan.c.orig 2009-06-13 22:49:07.000000000 +0200
+++ linux-2.6.29.4/fs/jffs2/scan.c 2009-06-13 22:29:06.000000000 +0200
@@ -196,7 +196,7 @@ int jffs2_scan_medium(struct jffs2_sb_in
if (c->nextblock) {
ret = file_dirty(c, c->nextblock);
if (ret)
- return ret;
+ goto out;
/* deleting summary information of the old nextblock */
jffs2_sum_reset_collected(c->summary);
}
@@ -207,7 +207,7 @@ int jffs2_scan_medium(struct jffs2_sb_in
} else {
ret = file_dirty(c, jeb);
if (ret)
- return ret;
+ goto out;
}
break;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-06-13 21:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-13 21:06 [PATCH 1/1] jffs2: leaking jffs2_summary in function jffs2_scan_medium Christian Engelmayer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.