All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	kaber@trash.net, geert@linux-m68k.org
Subject: Re: linux-next: net tree build failure
Date: Wed, 17 Jun 2009 01:36:58 -0700 (PDT)	[thread overview]
Message-ID: <20090617.013658.58706664.davem@davemloft.net> (raw)
In-Reply-To: <20090617163112.e14e064d.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 17 Jun 2009 16:31:12 +1000

> Today's linux-next build (m68k defconfig) failed like this:
> 
> drivers/net/sonic.c: In function 'sonic_send_packet':
> drivers/net/sonic.c:227: error: expected ';' before '}' token
> 
> Caused by commit 5b548140225c6bbbbd560551dd1048b2c0ce58be ("net: use
> symbolic values for ndo_start_xmit() return codes") which lost a
> semicolon in drivers/net/sonic.c.

I just pushed the following fix, thanks!

sonic: Fix build after ndo_start_xmit() changes.

Noticed by Stephen Rothwell.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/sonic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sonic.c b/drivers/net/sonic.c
index e4255d8..753a1fb 100644
--- a/drivers/net/sonic.c
+++ b/drivers/net/sonic.c
@@ -223,7 +223,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev)
 	if (!laddr) {
 		printk(KERN_ERR "%s: failed to map tx DMA buffer.\n", dev->name);
 		dev_kfree_skb(skb);
-		return NETDEV_TX_BUSY
+		return NETDEV_TX_BUSY;
 	}
 
 	sonic_tda_put(dev, entry, SONIC_TD_STATUS, 0);       /* clear status */
-- 
1.6.3.2


  reply	other threads:[~2009-06-17  8:37 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17  6:31 linux-next: net tree build failure Stephen Rothwell
2009-06-17  8:36 ` David Miller [this message]
2009-06-17 13:10   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-27  2:18 Stephen Rothwell
2010-01-27  4:49 ` David Miller
2010-01-11  7:42 Stephen Rothwell
2010-01-11  7:42 ` Stephen Rothwell
2010-01-11  8:02 ` David Miller
2010-01-11  8:16   ` Joe Perches
2010-01-11  8:44     ` David Miller
2010-01-11  8:49       ` Stephen Rothwell
2010-01-11 11:16     ` Maciej W. Rozycki
2009-11-18  5:51 Stephen Rothwell
2009-11-18  7:05 ` David Miller
2009-11-19 10:51   ` Shreyas Bhatewara
2009-11-14  6:50 Stephen Rothwell
2009-11-14  6:50 ` Stephen Rothwell
2009-11-14 13:18 ` Arnaldo Carvalho de Melo
2009-11-09  2:21 Stephen Rothwell
2009-11-09  2:21 ` Stephen Rothwell
2009-11-09  4:41 ` David Miller
2009-10-13  4:33 Stephen Rothwell
2009-10-13  5:14 ` Michael Chan
2009-10-13  6:20   ` David Miller
2009-10-13  6:19 ` David Miller
     [not found] <20090521001928.4bf71911.sfr@canb.auug.org.au>
2009-05-20 14:53 ` Eric W. Biederman
2009-05-20 19:44   ` David Miller
2009-04-24  7:01 Stephen Rothwell
2009-04-24 11:53 ` David Miller
2009-04-24 11:57   ` Stephen Rothwell
2009-04-22  0:29 Stephen Rothwell
2009-04-22  0:37 ` Alexander Beregalov
2009-04-22  1:12   ` David Miller
2009-04-20  1:26 Stephen Rothwell
2009-04-20  1:36 ` Alexander Beregalov
2009-04-20  1:43   ` David Miller
2009-04-20  1:50     ` Stephen Rothwell
2009-03-19  4:46 Stephen Rothwell
2009-03-19  5:40 ` David Miller
2009-04-01 19:58   ` Ingo Molnar
2009-04-01 21:22     ` David Miller
2009-03-30  1:15 ` Stephen Rothwell
2009-03-30  1:50   ` Stephen Rothwell
2009-03-02  7:05 Stephen Rothwell
2009-03-02  9:49 ` David Miller
2009-03-02 16:38   ` Andy Grover
2009-03-03  1:55   ` Stephen Rothwell
2009-03-03  3:22     ` Andy Grover
2009-01-26  2:53 Stephen Rothwell
2009-01-26  4:46 ` David Miller
2009-01-26  5:15   ` Stephen Rothwell
2009-01-26  5:17     ` David Miller
2009-01-26  8:31       ` Stephen Rothwell
2009-01-26 19:40         ` David Miller
2009-01-23  7:28 Stephen Rothwell
2009-01-23  7:56 ` David Miller
2009-01-23  8:01   ` Stephen Rothwell
2009-01-23  8:13     ` David Miller
2009-01-23 10:21       ` Stephen Rothwell
2009-01-23 10:39         ` Stephen Rothwell
2009-01-23 10:50           ` Stephen Rothwell
2009-01-24  6:27             ` David Miller
2008-12-09  6:29 Stephen Rothwell
2008-12-09  8:04 ` David Miller
2008-12-09  8:54   ` Stephen Rothwell
2008-12-09  9:05     ` David Miller
2008-12-09  9:12       ` Marcel Holtmann
2008-11-28  3:46 Stephen Rothwell
2008-11-28  7:07 ` David Miller
2008-11-26  7:15 Stephen Rothwell
2008-11-26  7:51 ` Herbert Xu
2008-11-26  8:45 ` David Miller
2008-11-26  9:40   ` Stephen Rothwell
2008-11-24  2:43 Stephen Rothwell
2008-11-24  3:56 ` David Miller
2008-11-24  4:03   ` David Miller
2008-11-24  4:25   ` Stephen Rothwell
2008-11-24  4:28     ` David Miller
2008-11-24  4:49       ` Stephen Rothwell
2008-11-24  5:04         ` David Miller
2008-11-24  5:20           ` Stephen Rothwell
2008-11-24  5:22             ` Stephen Rothwell
2008-11-24  5:23             ` David Miller
2008-11-24  5:29               ` David Miller
2008-11-24  5:45                 ` Stephen Rothwell
2008-11-24  5:38               ` Stephen Rothwell
2008-11-24 21:00                 ` Sam Ravnborg
2008-11-24 21:52                   ` Stephen Hemminger
2008-11-24 22:12                     ` Sam Ravnborg
2008-11-25  8:42                       ` Stephen Rothwell
2008-11-25  9:01                         ` Sam Ravnborg
2008-11-21  2:44 Stephen Rothwell
2008-11-21  4:02 ` Stephen Hemminger
2008-11-21  4:13   ` David Miller
2008-11-20  2:58 Stephen Rothwell
2008-11-20  2:30 Stephen Rothwell
2008-12-29  6:45 ` Stephen Rothwell
2008-09-13  5:03 Stephen Rothwell
2008-09-13  6:24 ` David Miller
2008-09-13  9:42   ` Stephen Rothwell
2008-09-15  0:54 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617.013658.58706664.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.