kbuild docs regression

kbuild docs regression

[Randy Dunlap]

make htmldocs
without using "O=dir" now (as of 2.6.30-git8) fails with

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/docproc
  HOSTCC  scripts/basic/hash
  DOCPROC Documentation/DocBook/alsa-driver-api.xml
  DOCPROC Documentation/DocBook/debugobjects.xml
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
make[1]: *** [Documentation/DocBook/debugobjects.xml] Error 1
make[1]: *** Waiting for unfinished jobs....
  DOCPROC Documentation/DocBook/deviceiobook.xml
  DOCPROC Documentation/DocBook/device-drivers.xml
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
exec /scripts/kernel-doc: No such file or directory
make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1

(+ more)

Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:


make -f scripts/Makefile.build obj=scripts/basic
make -f scripts/Makefile.build obj=Documentation/DocBook htmldocs
  SRCTREE=/lnx/src/TMP/linux-2.6.30-git8/ /lnx/src/TMP/linux-2.6.30-git8/scripts/basic/docproc doc Documentation/DocBook/alsa-driver-api.tmpl >Documentation/DocBook/alsa-driver-api.xml
exec /scripts/kernel-doc: No such file or directory

and one additional fprintf() in docproc.c shows that kernsrctree is empty:

docproc: srctree='/lnx/src/TMP/linux-2.6.30-git8/', kernsrctree=''



-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

Re: kbuild docs regression

[Jiri Slaby]

On 06/15/2009 06:31 PM, Randy Dunlap wrote:
> make htmldocs
> without using "O=dir" now (as of 2.6.30-git8) fails with
> 
>   DOCPROC Documentation/DocBook/deviceiobook.xml
>   DOCPROC Documentation/DocBook/device-drivers.xml
> exec /scripts/kernel-doc: No such file or directory
> exec /scripts/kernel-doc: No such file or directory
> make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1
> 
> (+ more)
> 
> Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:

Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is
it a build-sys bug?

Re: kbuild docs regression

[Amerigo Wang]

On Tue, Jun 16, 2009 at 03:14:14PM +0200, Jiri Slaby wrote:
>On 06/15/2009 06:31 PM, Randy Dunlap wrote:
>> make htmldocs
>> without using "O=dir" now (as of 2.6.30-git8) fails with
>> 
>>   DOCPROC Documentation/DocBook/deviceiobook.xml
>>   DOCPROC Documentation/DocBook/device-drivers.xml
>> exec /scripts/kernel-doc: No such file or directory
>> exec /scripts/kernel-doc: No such file or directory
>> make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1
>> 
>> (+ more)
>> 
>> Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:
>
>Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is
>it a build-sys bug?

No, it is a bug of docproc. Patch below fixes it.

Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---
diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c
index 4c9523e..99ca7a6 100644
--- a/scripts/basic/docproc.c
+++ b/scripts/basic/docproc.c
@@ -385,7 +385,7 @@ int main(int argc, char *argv[])
 	if (!srctree)
 		srctree = getcwd(NULL, 0);
 	kernsrctree = getenv("KBUILD_SRC");
-	if (!kernsrctree)
+	if (!kernsrctree || !*kernsrctree)
 		kernsrctree = srctree;
 	if (argc != 3) {
 		usage();

Re: kbuild docs regression

[Randy Dunlap]

Amerigo Wang wrote:
> On Tue, Jun 16, 2009 at 03:14:14PM +0200, Jiri Slaby wrote:
>> On 06/15/2009 06:31 PM, Randy Dunlap wrote:
>>> make htmldocs
>>> without using "O=dir" now (as of 2.6.30-git8) fails with
>>>
>>>   DOCPROC Documentation/DocBook/deviceiobook.xml
>>>   DOCPROC Documentation/DocBook/device-drivers.xml
>>> exec /scripts/kernel-doc: No such file or directory
>>> exec /scripts/kernel-doc: No such file or directory
>>> make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1
>>>
>>> (+ more)
>>>
>>> Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:
>> Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is
>> it a build-sys bug?
> 
> No, it is a bug of docproc. Patch below fixes it.
> 
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>


> ---
> diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c
> index 4c9523e..99ca7a6 100644
> --- a/scripts/basic/docproc.c
> +++ b/scripts/basic/docproc.c
> @@ -385,7 +385,7 @@ int main(int argc, char *argv[])
>  	if (!srctree)
>  		srctree = getcwd(NULL, 0);
>  	kernsrctree = getenv("KBUILD_SRC");
> -	if (!kernsrctree)
> +	if (!kernsrctree || !*kernsrctree)
>  		kernsrctree = srctree;
>  	if (argc != 3) {
>  		usage();


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/