* [PATCH] fix Pstate growing in OSLEC
@ 2009-06-18 17:45 Tzafrir Cohen
2009-06-18 20:54 ` [freetel-oslec] " David Rowe
0 siblings, 1 reply; 3+ messages in thread
From: Tzafrir Cohen @ 2009-06-18 17:45 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg KH, OSLEC list
The following fix has been posted in the OSLEC mailing list by Ruslan
Cray (and shortly afterwards acepted into the OSLEC SVN tree). Sadly it
has not been forwarded the kernel.org tree until now.
See:
http://sourceforge.net/mailarchive/forum.php?thread_name=000b01c9d88f%24ec689690%2475a8a8c0%40rcraydvlpmnt&forum_name=freetel-oslec
As a side note, the OSLEC code is gathering dust in the staging tree.
As-is it is mostly useless without providing an interface for its code.
I was hoping to see the mISDN code starting to use it but so far no
change in that front.
---
drivers/staging/echo/echo.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
index 6d7217e..faab26d 100644
--- a/drivers/staging/echo/echo.c
+++ b/drivers/staging/echo/echo.c
@@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
old = (int)ec->fir_state.history[ec->fir_state.curr_pos] *
(int)ec->fir_state.history[ec->fir_state.curr_pos];
ec->Pstates +=
- ((new - old) + (1 << ec->log2taps)) >> ec->log2taps;
+ ((new - old) + (1 << (ec->log2taps - 1))) >> ec->log2taps;
if (ec->Pstates < 0)
ec->Pstates = 0;
}
--
1.5.6.5
--
Tzafrir Cohen
icq#16849755 jabber:tzafrir.cohen@xorcom.com
+972-50-7952406 mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com iax:guest@local.xorcom.com/tzafrir
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [freetel-oslec] [PATCH] fix Pstate growing in OSLEC
2009-06-18 17:45 [PATCH] fix Pstate growing in OSLEC Tzafrir Cohen
@ 2009-06-18 20:54 ` David Rowe
2009-06-18 21:09 ` Tzafrir Cohen
0 siblings, 1 reply; 3+ messages in thread
From: David Rowe @ 2009-06-18 20:54 UTC (permalink / raw)
To: Open Source Line Echo Canceller; +Cc: linux-kernel, Greg KH
Hi Tzafrir,
I submitted the patch to Greg a few weeks ago (as well as checking it
into Oslec SVN).
Re gathering dust, on the contrary I understand that many people are
using Oslec from the kernel staging directory with the Asterisk DAHDI
interface.
Cheers,
David
On Thu, 2009-06-18 at 20:45 +0300, Tzafrir Cohen wrote:
> The following fix has been posted in the OSLEC mailing list by Ruslan
> Cray (and shortly afterwards acepted into the OSLEC SVN tree). Sadly it
> has not been forwarded the kernel.org tree until now.
>
> See:
>
> http://sourceforge.net/mailarchive/forum.php?thread_name=000b01c9d88f%24ec689690%2475a8a8c0%40rcraydvlpmnt&forum_name=freetel-oslec
>
> As a side note, the OSLEC code is gathering dust in the staging tree.
> As-is it is mostly useless without providing an interface for its code.
> I was hoping to see the mISDN code starting to use it but so far no
> change in that front.
>
> ---
> drivers/staging/echo/echo.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
> index 6d7217e..faab26d 100644
> --- a/drivers/staging/echo/echo.c
> +++ b/drivers/staging/echo/echo.c
> @@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
> old = (int)ec->fir_state.history[ec->fir_state.curr_pos] *
> (int)ec->fir_state.history[ec->fir_state.curr_pos];
> ec->Pstates +=
> - ((new - old) + (1 << ec->log2taps)) >> ec->log2taps;
> + ((new - old) + (1 << (ec->log2taps - 1))) >> ec->log2taps;
> if (ec->Pstates < 0)
> ec->Pstates = 0;
> }
> --
> 1.5.6.5
>
>
--
Free Telephony Project
open embedded IP-PBX hardware and software
http://www.rowetel.com/ucasterisk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [freetel-oslec] [PATCH] fix Pstate growing in OSLEC
2009-06-18 20:54 ` [freetel-oslec] " David Rowe
@ 2009-06-18 21:09 ` Tzafrir Cohen
0 siblings, 0 replies; 3+ messages in thread
From: Tzafrir Cohen @ 2009-06-18 21:09 UTC (permalink / raw)
To: Open Source Line Echo Canceller; +Cc: Greg KH, linux-kernel
On Fri, Jun 19, 2009 at 06:24:06AM +0930, David Rowe wrote:
> Re gathering dust, on the contrary I understand that many people are
> using Oslec from the kernel staging directory with the Asterisk DAHDI
> interface.
... and thus creating interesting artifacts such as:
http://svn.asterisk.org/svn/dahdi/linux/trunk/drivers/dahdi/dahdi_echocan_oslec.c
http://svn.asterisk.org/svn/dahdi/linux/trunk/drivers/dahdi/Kbuild
https://issues.asterisk.org/view.php?id=15251
Note the line '#include "../staging/echo/oslec.h"
--
Tzafrir Cohen
icq#16849755 jabber:tzafrir.cohen@xorcom.com
+972-50-7952406 mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com iax:guest@local.xorcom.com/tzafrir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-18 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-18 17:45 [PATCH] fix Pstate growing in OSLEC Tzafrir Cohen
2009-06-18 20:54 ` [freetel-oslec] " David Rowe
2009-06-18 21:09 ` Tzafrir Cohen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.