libuuid (Re: blkid: util-linux-ng vs. e2fsprogs)

libuuid (Re: blkid: util-linux-ng vs. e2fsprogs)

[Karel Zak]

On Mon, Jun 01, 2009 at 08:48:57AM -0400, Theodore Tso wrote:
> It is supposed to be safe to replace the built-in libblkid in
> e2fsprogs with the one in util-linux-ng.  There may be bugs, but if
> there are report them, and we'll work to get them fixed.  I'll try to
> keep the bug fixes in e2fsprogs and util-linux-ng roughly synchronized
> for at least a while, since it takes a while for distributions to make
> the switch.  So a brusque, "drop libblkid, who cares if we screw over
> distro's that haven't yet moved to util-linux-ng" is not in the cards,
> no.  In terms of formal plan, probably in a year or so.  I'm believer
> in long compatibility windows.

 Yes, this is our plan.

 This reminds me...

 The next step is to move libuuid from e2fsprogs to util-linux-ng.
 Currently, this library is widely used by many packages (Fedora-11):

   $ repoquery --qf="%{NAME}" --whatrequires libuuid* | sort -u | wc -l
   74

 The util-linux-ng code is already prepared for this change and the
 library has been merged into git tree.

 It would be nice to add the --disable-uuid option to e2fsprogs. If I
 good remember Scott has a patch for this change. Scott?

    Karel

-- 
 Karel Zak  <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Scott James Remnant]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

Hi Ted, any good?

On Wed, 2009-06-03 at 10:39 +0100, Scott James Remnant wrote:
> On Wed, 2009-06-03 at 10:51 +0200, Karel Zak wrote:
> 
> > On Mon, Jun 01, 2009 at 08:48:57AM -0400, Theodore Tso wrote:
> > > It is supposed to be safe to replace the built-in libblkid in
> > > e2fsprogs with the one in util-linux-ng.  There may be bugs, but if
> > > there are report them, and we'll work to get them fixed.  I'll try to
> > > keep the bug fixes in e2fsprogs and util-linux-ng roughly synchronized
> > > for at least a while, since it takes a while for distributions to make
> > > the switch.  So a brusque, "drop libblkid, who cares if we screw over
> > > distro's that haven't yet moved to util-linux-ng" is not in the cards,
> > > no.  In terms of formal plan, probably in a year or so.  I'm believer
> > > in long compatibility windows.
> > 
> >  Yes, this is our plan.
> > 
> >  This reminds me...
> > 
> >  The next step is to move libuuid from e2fsprogs to util-linux-ng.
> >  Currently, this library is widely used by many packages (Fedora-11):
> > 
> >    $ repoquery --qf="%{NAME}" --whatrequires libuuid* | sort -u | wc -l
> >    74
> > 
> >  The util-linux-ng code is already prepared for this change and the
> >  library has been merged into git tree.
> > 
> >  It would be nice to add the --disable-uuid option to e2fsprogs. If I
> >  good remember Scott has a patch for this change. Scott?
> > 
> Right ;)
> 
> attached
> 
> Scott
-- 
Scott James Remnant
scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

Hey Ted,
it would be great, if you could add that, and put it into a release.
The current packaging is a dependency hell, and it would be much
easier if util-linux-ng can just provide all the needed stuff for
libblkid, instead of the circular dependencies we have to work around
now.

Thanks,
Kay

On Tue, Jun 16, 2009 at 15:36, Scott James Remnant<scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> wrote:
> Hi Ted, any good?
>
> On Wed, 2009-06-03 at 10:39 +0100, Scott James Remnant wrote:
>> On Wed, 2009-06-03 at 10:51 +0200, Karel Zak wrote:
>>
>> > On Mon, Jun 01, 2009 at 08:48:57AM -0400, Theodore Tso wrote:
>> > > It is supposed to be safe to replace the built-in libblkid in
>> > > e2fsprogs with the one in util-linux-ng.  There may be bugs, but if
>> > > there are report them, and we'll work to get them fixed.  I'll try to
>> > > keep the bug fixes in e2fsprogs and util-linux-ng roughly synchronized
>> > > for at least a while, since it takes a while for distributions to make
>> > > the switch.  So a brusque, "drop libblkid, who cares if we screw over
>> > > distro's that haven't yet moved to util-linux-ng" is not in the cards,
>> > > no.  In terms of formal plan, probably in a year or so.  I'm believer
>> > > in long compatibility windows.
>> >
>> >  Yes, this is our plan.
>> >
>> >  This reminds me...
>> >
>> >  The next step is to move libuuid from e2fsprogs to util-linux-ng.
>> >  Currently, this library is widely used by many packages (Fedora-11):
>> >
>> >    $ repoquery --qf="%{NAME}" --whatrequires libuuid* | sort -u | wc -l
>> >    74
>> >
>> >  The util-linux-ng code is already prepared for this change and the
>> >  library has been merged into git tree.
>> >
>> >  It would be nice to add the --disable-uuid option to e2fsprogs. If I
>> >  good remember Scott has a patch for this change. Scott?
>> >
>> Right ;)
>>
>> attached
>>
>> Scott
> --
> Scott James Remnant
> scott-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org
>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

Sorry for the delay; I've been incredibly busy.  I'm guessing you
never actually bothered to build and test the patch which you
submitted?

I tried building with --disable-libuuid, when it tried to compile
e2fsck, it crashed and burned.  The reason why was because LIBUUID
wasn't getting set properly:

% grep LIBUUID MCONFIG  | head -1
LIBUUID =  

And the reason for that is....

On Wed, Jun 03, 2009 at 10:39:05AM +0100, Scott James Remnant wrote:
> +AC_ARG_ENABLE([libuuid],
> +[  --disable-libuuid	  do not build private uuid library],
> +if test "$enableval" = "no"
> +then
> +	if test -z "$PKG_CONFIG"; then
> +		AC_MSG_ERROR([pkg-config not installed; please install it.])
> +	fi
> +
> +	AC_CHECK_LIB(uuid, uuid_generate,
> +		[LIBBLKID=`$PKG_CONFIG --libs uuid`;
                 ^^^^^^^^
> +		 STATIC_LIBBLKID=`$PKG_CONFIG --static --libs uuid`],
                 ^^^^^^^^^^^^^^^
> +		[AC_MSG_ERROR([external uuid library not found])],
> +		[$LIBUUID])
> +	UUID_CMT=#
> +	AC_MSG_RESULT([Disabling private uuid library])

I'll have a corrected patch checked into e2fsprogs.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Sun, Jun 28, 2009 at 15:34, Theodore Tso<tytso@mit.edu> wrote:

> I'll have a corrected patch checked into e2fsprogs.

Very nice. Thanks!

It seems, that /usr/bin/uuidgen is installed, even when:
  --disable-libblkid
  --disable-libuuid
  --disable-uuidd
is given.


And another thing is your custom "silent build" which can not be
disabled. Our build system requires the command output for fancy
analysis, so it would be good if it could be disabled, like it can for
the kernel (V=1). Any ideas, or do I miss some switch?

Thanks,
Kay

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
> 
> And another thing is your custom "silent build" which can not be
> disabled. Our build system requires the command output for fancy
> analysis, so it would be good if it could be disabled, like it can for
> the kernel (V=1). Any ideas, or do I miss some switch?
> 

Is a configure-level switch all that you need?  I hadn't done a
make-level switch because I was trying to avoid adding a requirement
of using GNU make in building e2fsprogs, since it gets used by *BSD
and Solaris systems as well.  (And in fact some of the recent UUID bug
fixes come from FreeBSD bug reports, and I suspect FreeBSD will
continue to use UUID library from e2fsprogs rather than pulling in
util-linux-ng....)

						- Ted

			

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Wed, Jul 1, 2009 at 23:43, Theodore Tso<tytso-3s7WtUTddSA@public.gmane.org> wrote:
> On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
>>
>> And another thing is your custom "silent build" which can not be
>> disabled. Our build system requires the command output for fancy
>> analysis, so it would be good if it could be disabled, like it can for
>> the kernel (V=1). Any ideas, or do I miss some switch?
>
> Is a configure-level switch all that you need?  I hadn't done a
> make-level switch because I was trying to avoid adding a requirement
> of using GNU make in building e2fsprogs, since it gets used by *BSD
> and Solaris systems as well.  (And in fact some of the recent UUID bug
> fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> continue to use UUID library from e2fsprogs rather than pulling in
> util-linux-ng....)

Anything would work, that resolves the '@' to nothing and puts out the
command, an environment var or a switch.

In older udev releases, before we switched to automake, I had
something like this, which behaves a bit like the Linux kernel build,
and V=1 switches off the silent mode:

  V =
  ifeq ($(strip $(V)),)
    E = @echo
    Q = @
  else
    E = @\#
    Q =
  endif
  export E Q

 ...

  $(E) "  CC      " $@
  $(Q) $(CC) -c $(CFLAGS) $< -o $@

  ...

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Wednesday 01 July 2009 17:52:11 Kay Sievers wrote:
> On Wed, Jul 1, 2009 at 23:43, Theodore Tso<tytso@mit.edu> wrote:
> > On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
> >> And another thing is your custom "silent build" which can not be
> >> disabled. Our build system requires the command output for fancy
> >> analysis, so it would be good if it could be disabled, like it can for
> >> the kernel (V=1). Any ideas, or do I miss some switch?
> >
> > Is a configure-level switch all that you need?  I hadn't done a
> > make-level switch because I was trying to avoid adding a requirement
> > of using GNU make in building e2fsprogs, since it gets used by *BSD
> > and Solaris systems as well.  (And in fact some of the recent UUID bug
> > fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> > continue to use UUID library from e2fsprogs rather than pulling in
> > util-linux-ng....)
>
> Anything would work, that resolves the '@' to nothing and puts out the
> command, an environment var or a switch.
>
> In older udev releases, before we switched to automake, I had
> something like this, which behaves a bit like the Linux kernel build,
> and V=1 switches off the silent mode:

why not just use automake-1.11's silent-rules option.  then you dont have to 
waste time reinventing the wheel.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Thu, Jul 2, 2009 at 00:35, Mike Frysinger<vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> wrote:

>> In older udev releases, before we switched to automake, I had
>> something like this, which behaves a bit like the Linux kernel build,
>> and V=1 switches off the silent mode:
>
> why not just use automake-1.11's silent-rules option.  then you dont have to
> waste time reinventing the wheel.

I do. :) But e2fsprogs don't use automake, only autoconf.

Kay
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

On Wednesday 01 July 2009 18:39:23 Kay Sievers wrote:
> On Thu, Jul 2, 2009 at 00:35, Mike Frysinger<vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> wrote:
> >> In older udev releases, before we switched to automake, I had
> >> something like this, which behaves a bit like the Linux kernel build,
> >> and V=1 switches off the silent mode:
> >
> > why not just use automake-1.11's silent-rules option.  then you dont have
> > to waste time reinventing the wheel.
>
> I do. :) But e2fsprogs don't use automake, only autoconf.

ah you're right of course.  i keep forgetting i have to send patches to fix up 
e2fsprogs Makefile.in's ... :/
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > In older udev releases, before we switched to automake, I had
> > something like this, which behaves a bit like the Linux kernel build,
> > and V=1 switches off the silent mode:
> 
> why not just use automake-1.11's silent-rules option.  then you dont have to 
> waste time reinventing the wheel.

Because I consider automake the spawn of Satan?  :-)

							- Ted

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On Wednesday 01 July 2009 20:58:58 Theodore Tso wrote:
> On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > > In older udev releases, before we switched to automake, I had
> > > something like this, which behaves a bit like the Linux kernel build,
> > > and V=1 switches off the silent mode:
> >
> > why not just use automake-1.11's silent-rules option.  then you dont have
> > to waste time reinventing the wheel.
>
> Because I consider automake the spawn of Satan?  :-)

i'll have you know Satan's wheel is awfully shiny ...

Kay's rules look like they should be fairly straightforward to drop into 
e2fsprogs.  personally i'd use:
E = @:
when V=1, but this is probably just splitting hairs
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Thu, Jul 2, 2009 at 03:15, Mike Frysinger<vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> wrote:
> On Wednesday 01 July 2009 20:58:58 Theodore Tso wrote:
>> On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
>> > > In older udev releases, before we switched to automake, I had
>> > > something like this, which behaves a bit like the Linux kernel build,
>> > > and V=1 switches off the silent mode:
>> >
>> > why not just use automake-1.11's silent-rules option.  then you dont have
>> > to waste time reinventing the wheel.
>>
>> Because I consider automake the spawn of Satan?  :-)

Yeah, it is. It's strange what these tools produce. But it sees it's
slowly getting better over time not worse - so there is hope. Even the
recent libtool looks ok now. And I don't really miss the check for
FORTRAN, which seems to have disappeared here recently. :)

> i'll have you know Satan's wheel is awfully shiny ...

Heh, yeah. If you do not check-in the created stuff into git, and use:
  git clean -d -X -f
  autoreconf --install --symlink
to bootstrap a repo, stuff looks pretty good, I think. You just need
to be able to convince yourself not to look into the generated files.
:)

On the other hand the silent rules and "make distcheck" and all these
things which come along with automake are just great to have.

> Kay's rules look like they should be fairly straightforward to drop into
> e2fsprogs.  personally i'd use:
> E = @:
> when V=1, but this is probably just splitting hairs

Ah nice, looks good to me, if that works.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
> > Kay's rules look like they should be fairly straightforward to drop into
> > e2fsprogs.  personally i'd use:
> > E = @:
> > when V=1, but this is probably just splitting hairs
> 
> Ah nice, looks good to me, if that works.

Take a look at what I've checked into e2fsprogs' maint branch; it was
largely based on what you suggested.

If someone can point me at an autoconf test that determines whether or
not we're using gmake, I could even set up something which sucks in a
Makefile fragment that enhances what we can do for developers who are
using GNU make.  (i.e., if you're using GNU make, "make V=1" will
DTRT, but if you're using a Solaris or BSD make, you'll have to settle
for "configure --enable-verbose-makecmds")

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Thu, Jul 2, 2009 at 16:25, Theodore Tso<tytso@mit.edu> wrote:
> On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
>> > Kay's rules look like they should be fairly straightforward to drop into
>> > e2fsprogs.  personally i'd use:
>> > E = @:
>> > when V=1, but this is probably just splitting hairs
>>
>> Ah nice, looks good to me, if that works.
>
> Take a look at what I've checked into e2fsprogs' maint branch; it was
> largely based on what you suggested.
>
> If someone can point me at an autoconf test that determines whether or
> not we're using gmake, I could even set up something which sucks in a
> Makefile fragment that enhances what we can do for developers who are
> using GNU make.  (i.e., if you're using GNU make, "make V=1" will
> DTRT, but if you're using a Solaris or BSD make, you'll have to settle
> for "configure --enable-verbose-makecmds")

I tried, and it works fine for me with the  --enable-verbose-makecmds.

Thanks a lot,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Thursday 02 July 2009 10:25:15 Theodore Tso wrote:
> On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
> > > Kay's rules look like they should be fairly straightforward to drop
> > > into e2fsprogs.  personally i'd use:
> > > E = @:
> > > when V=1, but this is probably just splitting hairs
> >
> > Ah nice, looks good to me, if that works.
>
> Take a look at what I've checked into e2fsprogs' maint branch; it was
> largely based on what you suggested.
>
> If someone can point me at an autoconf test that determines whether or
> not we're using gmake, I could even set up something which sucks in a
> Makefile fragment that enhances what we can do for developers who are
> using GNU make.  (i.e., if you're using GNU make, "make V=1" will
> DTRT, but if you're using a Solaris or BSD make, you'll have to settle
> for "configure --enable-verbose-makecmds")

two methods:
 - http://autoconf-archive.cryp.to/check_gnu_make.html
 - a local "GNUmakefile" will be processed by GNU make only, and be done 
before the normal Makefile
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Thu, Jul 02, 2009 at 11:51:08AM -0400, Mike Frysinger wrote:
> > If someone can point me at an autoconf test that determines whether or
> > not we're using gmake, I could even set up something which sucks in a
> > Makefile fragment that enhances what we can do for developers who are
> > using GNU make.  (i.e., if you're using GNU make, "make V=1" will
> > DTRT, but if you're using a Solaris or BSD make, you'll have to settle
> > for "configure --enable-verbose-makecmds")
> 
> two methods:
>  - http://autoconf-archive.cryp.to/check_gnu_make.html

Very cool, that was just what I was looking for.  Thanks!!

     	   	    	      	    	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Matthew Burgess]

On Sun, 28 Jun 2009 09:34:30 -0400, Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org> wrote:

> I'll have a corrected patch checked into e2fsprogs.

Hi,

I get the following output when trying to compile e2fsprogs-1.41.7
against util-linux-ng-2.16-rc1's installed versions of libuuid &
libblkid:

	CC ../../e2fsck/profile.c
	CC prof_err.c
make[3]: *** No rule to make target `-L/tools/lib', needed by `e2fsck'.  Stop.
make[3]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build/e2fsck'
make[2]: *** [all-progs-recursive] Error 1
make[2]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build'

This was after doing:

../configure --prefix=/tools --disable-libblkid --disable-libuuid

This appears to stem from the following bits of the Makefile:

e2fsck: $(OBJS)  $(DEPLIBS)
DEPLIBS= $(LIBEXT2FS) $(LIBCOM_ERR) $(DEPLIBBLKID) $(DEPLIBUUID) $(DEPLIBE2P)
DEPLIBBLKID =   $(LIBUUID)
LIBUUID = -L/tools/lib -luuid

So, DEPLIBBLKID appears to be getting set even if the building of libuuid &
libblkid has been disabled.  Should DEPLIBBLKID & DEPLIBUUID even be included
in DEPLIBS in that circumstance?

Thanks,

Matt.

--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Wed, Jul 01, 2009 at 03:04:43PM -0600, Matthew Burgess wrote:
> On Sun, 28 Jun 2009 09:34:30 -0400, Theodore Tso <tytso@mit.edu> wrote:
> 
> > I'll have a corrected patch checked into e2fsprogs.
> 
> Hi,
> 
> I get the following output when trying to compile e2fsprogs-1.41.7
> against util-linux-ng-2.16-rc1's installed versions of libuuid &
> libblkid

Thanks for pointing that out.  Apparently GNU make wasn't failing when
"-luuid" was in the dependency, which is why I didn't notice this
earlier.  I'm not sure why it complains with "-L/tools/lib", but not
with "-luuid", but whatever.  I've checked the following into the
e2fsprogs maint branch.

							- Ted

commit 4a1e15a8babb2176a427f40c92b7ac1e3bf7346d
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed Jul 1 17:20:24 2009 -0400

    Fix compilation problem when building with --disable-uuid
    
    The MCONFIG.in file used $(LIBUUID) in the definition of DEPLIBBLKID,
    when it should have used $(DEPLIBUUID) instead.
    
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/MCONFIG.in b/MCONFIG.in
index cec3631..9596e56 100644
--- a/MCONFIG.in
+++ b/MCONFIG.in
@@ -79,7 +79,7 @@ LIBBLKID = @LIBBLKID@ @PRIVATE_LIBS_CMT@ $(LIBUUID)
 LIBINTL = @LIBINTL@
 DEPLIBSS = $(LIB)/libss@LIB_EXT@
 DEPLIBUUID = @DEPLIBUUID@
-DEPLIBBLKID = @DEPLIBBLKID@ @PRIVATE_LIBS_CMT@ $(LIBUUID)
+DEPLIBBLKID = @DEPLIBBLKID@ @PRIVATE_LIBS_CMT@ $(DEPLIBUUID)
 
 STATIC_LIBSS = $(LIB)/libss@STATIC_LIB_EXT@ @DLOPEN_LIB@
 STATIC_LIBCOM_ERR = $(LIB)/libcom_err@STATIC_LIB_EXT@ @SEM_INIT_LIB@

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On Wednesday 01 July 2009 17:28:44 Theodore Tso wrote:
> On Wed, Jul 01, 2009 at 03:04:43PM -0600, Matthew Burgess wrote:
> > On Sun, 28 Jun 2009 09:34:30 -0400, Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org> wrote:
> > > I'll have a corrected patch checked into e2fsprogs.
> >
> > I get the following output when trying to compile e2fsprogs-1.41.7
> > against util-linux-ng-2.16-rc1's installed versions of libuuid &
> > libblkid
>
> Thanks for pointing that out.  Apparently GNU make wasn't failing when
> "-luuid" was in the dependency, which is why I didn't notice this
> earlier.  I'm not sure why it complains with "-L/tools/lib", but not
> with "-luuid", but whatever.  I've checked the following into the
> e2fsprogs maint branch.

that's because -lfoo is an extension that GNU make supports (albeit, kind of a 
lame one).  com_err has a similar problem:
http://sourceforge.net/tracker/?func=detail&aid=2813809&group_id=2406&atid=302406
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Wed, Jul 01, 2009 at 05:42:26PM -0400, Mike Frysinger wrote:
> that's because -lfoo is an extension that GNU make supports (albeit, kind of a 
> lame one).  com_err has a similar problem:
> http://sourceforge.net/tracker/?func=detail&aid=2813809&group_id=2406&atid=302406

I've checked in a fix for this in the maint branch of e2fsprogs.

     	     	      	       	      	    - Ted



--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

On Wednesday 01 July 2009 22:26:52 Theodore Tso wrote:
> On Wed, Jul 01, 2009 at 05:42:26PM -0400, Mike Frysinger wrote:
> > that's because -lfoo is an extension that GNU make supports (albeit, kind
> > of a lame one).  com_err has a similar problem:
> > http://sourceforge.net/tracker/?func=detail&aid=2813809&group_id=2406&ati
> >d=302406
>
> I've checked in a fix for this in the maint branch of e2fsprogs.

is the tracker the best place to submit bugs/patches ?  or should i send them 
elsewhere ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Theodore Tso]

On Wed, Jul 01, 2009 at 10:41:06PM -0400, Mike Frysinger wrote:
> 
> is the tracker the best place to submit bugs/patches ?  or should i
> send them elsewhere ?
> 

I also pay attention to the Debian bug tracker and Ubuntu launchpad
(although very often there's a huge number of uninformed users that
tend to add far more noise than useful information on the latter).
I'll also pay attention to Red Hat and SuSE bugzillas if someone
points me at the bug report, although I don't regularly scan those.
So for generic bugs the SF tracker works fine.

For patches, just send them to linux-ext4 mailing list; I am using
patchwork:

	http://patchwork.ozlabs.org/project/linux-ext4/list/

... to make sure patches don't get dropped.

							- Ted





--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Thursday 02 July 2009 00:03:53 Theodore Tso wrote:
> So for generic bugs the SF tracker works fine.
>
> For patches, just send them to linux-ext4 mailing list; I am using
> patchwork:
>
> 	http://patchwork.ozlabs.org/project/linux-ext4/list/
>
> ... to make sure patches don't get dropped.

ok, that works for me
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] configure.in: add --disable-libuuid option (Was:libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

[Kay Sievers]

On Wed, Jul 1, 2009 at 23:28, Theodore Tso<tytso-3s7WtUTddSA@public.gmane.org> wrote:
> On Wed, Jul 01, 2009 at 03:04:43PM -0600, Matthew Burgess wrote:
>> I get the following output when trying to compile e2fsprogs-1.41.7
>> against util-linux-ng-2.16-rc1's installed versions of libuuid &
>> libblkid
>
> Thanks for pointing that out.  Apparently GNU make wasn't failing when
> "-luuid" was in the dependency, which is why I didn't notice this
> earlier.  I'm not sure why it complains with "-L/tools/lib", but not
> with "-luuid", but whatever.  I've checked the following into the
> e2fsprogs maint branch.

I had a similar issue, caused by a wrong libdir in the util-linux's
*.pc files. They have libdir=/lib instead libdir=/usr/lib, and in some
setups the devel-symlink isn't found, which is usually in /usr.

Only the local build on one of my boxes failed, but editing the .pc
files solved the problem.

(The real location of the .so image does not matter, it's a detail
hidden and handled by the ld loader, and the .pc files should always
poit to the devel symlink to the .so.)

Kay
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html