All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] xend: pass-through: fix regression in the ordering of the output of xm pci list
@ 2009-07-21 11:12 Simon Horman
  0 siblings, 0 replies; only message in thread
From: Simon Horman @ 2009-07-21 11:12 UTC (permalink / raw)
  To: xen-devel

changeset "python: Remove tab indents" (19937:e845326ae203)
introduces a minor regression in the multi-function PCI pass-through
code by causing bogus return values from the sort function
which is used to order the output of "xm pci list".

Signed-off-by: Simon Horman <horms@verge.net.au>

Index: xen-unstable.hg/tools/python/xen/xm/main.py
===================================================================
--- xen-unstable.hg.orig/tools/python/xen/xm/main.py	2009-07-21 18:51:29.000000000 +1000
+++ xen-unstable.hg/tools/python/xen/xm/main.py	2009-07-21 18:51:41.000000000 +1000
@@ -2234,7 +2234,7 @@ def xm_pci_list(args):
             vdevfn = AUTO_PHP_SLOT
         else:
             vdevfn = x['vdevfn']
-            return (vdevfn << 32) | \
+        return (vdevfn << 32) | \
                    PCI_BDF(x['domain'], x['bus'], x['slot'], x['func'])
     devs.sort(None, f)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-21 11:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-21 11:12 [patch] xend: pass-through: fix regression in the ordering of the output of xm pci list Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.