All of
 help / color / mirror / Atom feed
From: Frans Pop <>
Cc:, Ingo Molnar <>,
Subject: [PATCH] x86: minor Makefile simplification through use of cc-ifversion
Date: Thu, 23 Jul 2009 20:56:27 +0200	[thread overview]
Message-ID: <> (raw)

Signed-off-by: Frans Pop <>

Change was suggested by Sam Ravnborg; see
Tested to work correctly.

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 1b68659..1f3851a 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y)
         # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
         # a lot more stack due to the lack of sharing of stacklots:
-        KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
-                echo $(call cc-option,-fno-unit-at-a-time); fi ;)
+        KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \
+				$(call cc-option,-fno-unit-at-a-time))
         # CPU-specific tuning. Anything which can be shared with UML should go here.
         include $(srctree)/arch/x86/Makefile_32.cpu

             reply	other threads:[~2009-07-23 18:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 18:56 Frans Pop [this message]
2009-07-23 21:25 ` Sam Ravnborg
2009-07-24  9:26 ` Amerigo Wang
2009-08-04 13:15 ` [tip:x86/kbuild] x86: Simplify the Makefile in a minor way " tip-bot for Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86: minor Makefile simplification through use of cc-ifversion' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.