* [PATCH 7/9] drivers/rtc: correct error-handling code
@ 2009-07-28 15:55 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-07-28 15:55 UTC (permalink / raw)
To: p_gortmaker, a.zummo, rtc-linux, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
This code is not executed before ds1307->rtc has been successfully
initialized to the result of calling rtc_device_register. Thus the test
that ds1307->rtc is not NULL is always true.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@match exists@
expression x, E;
statement S1, S2;
@@
x = rtc_device_register(...)
... when != x = E
(
* if (x == NULL || ...) S1 else S2
|
* if (x == NULL && ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/rtc/rtc-ds1307.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 47a93c0..eb99ee4 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -896,8 +896,7 @@ read_rtc:
return 0;
exit_irq:
- if (ds1307->rtc)
- rtc_device_unregister(ds1307->rtc);
+ rtc_device_unregister(ds1307->rtc);
exit_free:
kfree(ds1307);
return err;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 7/9] drivers/rtc: correct error-handling code
@ 2009-07-28 15:55 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-07-28 15:55 UTC (permalink / raw)
To: p_gortmaker, a.zummo, rtc-linux, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
This code is not executed before ds1307->rtc has been successfully
initialized to the result of calling rtc_device_register. Thus the test
that ds1307->rtc is not NULL is always true.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@match exists@
expression x, E;
statement S1, S2;
@@
x = rtc_device_register(...)
... when != x = E
(
* if (x = NULL || ...) S1 else S2
|
* if (x = NULL && ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/rtc/rtc-ds1307.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 47a93c0..eb99ee4 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -896,8 +896,7 @@ read_rtc:
return 0;
exit_irq:
- if (ds1307->rtc)
- rtc_device_unregister(ds1307->rtc);
+ rtc_device_unregister(ds1307->rtc);
exit_free:
kfree(ds1307);
return err;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [rtc-linux] [PATCH 7/9] drivers/rtc: correct error-handling code
2009-07-28 15:55 ` Julia Lawall
@ 2009-07-28 16:31 ` Wolfram Sang
-1 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2009-07-28 16:31 UTC (permalink / raw)
To: rtc-linux; +Cc: p_gortmaker, a.zummo, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Tue, Jul 28, 2009 at 05:55:33PM +0200, Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> This code is not executed before ds1307->rtc has been successfully
> initialized to the result of calling rtc_device_register. Thus the test
> that ds1307->rtc is not NULL is always true.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
>
> x = rtc_device_register(...)
> ... when != x = E
> (
> * if (x == NULL || ...) S1 else S2
> |
> * if (x == NULL && ...) S1 else S2
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rtc-linux] [PATCH 7/9] drivers/rtc: correct error-handling
@ 2009-07-28 16:31 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2009-07-28 16:31 UTC (permalink / raw)
To: rtc-linux; +Cc: p_gortmaker, a.zummo, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Tue, Jul 28, 2009 at 05:55:33PM +0200, Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> This code is not executed before ds1307->rtc has been successfully
> initialized to the result of calling rtc_device_register. Thus the test
> that ds1307->rtc is not NULL is always true.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
>
> x = rtc_device_register(...)
> ... when != x = E
> (
> * if (x == NULL || ...) S1 else S2
> |
> * if (x == NULL && ...) S1 else S2
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-28 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-28 15:55 [PATCH 7/9] drivers/rtc: correct error-handling code Julia Lawall
2009-07-28 15:55 ` Julia Lawall
2009-07-28 16:31 ` [rtc-linux] " Wolfram Sang
2009-07-28 16:31 ` [rtc-linux] [PATCH 7/9] drivers/rtc: correct error-handling Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.