* [PATCH 10/15] arch/mips: Use DIV_ROUND_CLOSEST
@ 2009-08-02 8:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-02 8:48 UTC (permalink / raw)
To: ralf, linux-mips, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression x,__divisor;
@@
- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/mips/nxp/pnx8550/common/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/nxp/pnx8550/common/time.c b/arch/mips/nxp/pnx8550/common/time.c
index 8df43e9..18b1927 100644
--- a/arch/mips/nxp/pnx8550/common/time.c
+++ b/arch/mips/nxp/pnx8550/common/time.c
@@ -138,7 +138,7 @@ __init void plat_time_init(void)
* HZ timer interrupts per second.
*/
mips_hpt_frequency = 27UL * ((1000000UL * n)/(m * pow2p));
- cpj = (mips_hpt_frequency + HZ / 2) / HZ;
+ cpj = DIV_ROUND_CLOSEST(mips_hpt_frequency, HZ);
write_c0_count(0);
timer_ack();
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 10/15] arch/mips: Use DIV_ROUND_CLOSEST
@ 2009-08-02 8:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-02 8:48 UTC (permalink / raw)
To: ralf, linux-mips, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression x,__divisor;
@@
- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/mips/nxp/pnx8550/common/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/nxp/pnx8550/common/time.c b/arch/mips/nxp/pnx8550/common/time.c
index 8df43e9..18b1927 100644
--- a/arch/mips/nxp/pnx8550/common/time.c
+++ b/arch/mips/nxp/pnx8550/common/time.c
@@ -138,7 +138,7 @@ __init void plat_time_init(void)
* HZ timer interrupts per second.
*/
mips_hpt_frequency = 27UL * ((1000000UL * n)/(m * pow2p));
- cpj = (mips_hpt_frequency + HZ / 2) / HZ;
+ cpj = DIV_ROUND_CLOSEST(mips_hpt_frequency, HZ);
write_c0_count(0);
timer_ack();
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 10/15] arch/mips: Use DIV_ROUND_CLOSEST
2009-08-02 8:48 ` Julia Lawall
@ 2009-08-02 18:41 ` Ralf Baechle
-1 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2009-08-02 18:41 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-mips, linux-kernel, kernel-janitors
On Sun, Aug 02, 2009 at 10:48:08AM +0200, Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
Applied. Thanks Julia!
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 10/15] arch/mips: Use DIV_ROUND_CLOSEST
@ 2009-08-02 18:41 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2009-08-02 18:41 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-mips, linux-kernel, kernel-janitors
On Sun, Aug 02, 2009 at 10:48:08AM +0200, Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
Applied. Thanks Julia!
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-02 18:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-02 8:48 [PATCH 10/15] arch/mips: Use DIV_ROUND_CLOSEST Julia Lawall
2009-08-02 8:48 ` Julia Lawall
2009-08-02 18:41 ` Ralf Baechle
2009-08-02 18:41 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.