[PATCH] microblaze: convert to asm-generic/hardirq.h

[PATCH] microblaze: convert to asm-generic/hardirq.h

[Christoph Hellwig]

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
--- linux-2.6.orig/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:32:58.596148711 +0200
+++ linux-2.6/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:56:30.691912378 +0200
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
--- linux-2.6.orig/arch/microblaze/kernel/irq.c	2009-07-27 14:53:45.847149312 +0200
+++ linux-2.6/arch/microblaze/kernel/irq.c	2009-07-27 14:56:37.121902184 +0200
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)

Re: [microblaze-uclinux] [PATCH] microblaze: convert to asm-generic/hardirq.h

[Michal Simek]

Hi Christoph,

Can you please change your patch title?
You are removing ack_bad_irq not convert to hardirq.h

But anyway will be worth to remove it from other archs too.

Thanks,
Michal

Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
> ===================================================================
> --- linux-2.6.orig/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:32:58.596148711 +0200
> +++ linux-2.6/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:56:30.691912378 +0200
> @@ -12,8 +12,6 @@
>  /* should be defined in each interrupt controller driver */
>  extern unsigned int get_irq(struct pt_regs *regs);
>  
> -#define ack_bad_irq ack_bad_irq
> -void ack_bad_irq(unsigned int irq);
>  #include <asm-generic/hardirq.h>
>  
>  #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
> Index: linux-2.6/arch/microblaze/kernel/irq.c
> ===================================================================
> --- linux-2.6.orig/arch/microblaze/kernel/irq.c	2009-07-27 14:53:45.847149312 +0200
> +++ linux-2.6/arch/microblaze/kernel/irq.c	2009-07-27 14:56:37.121902184 +0200
> @@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
>  }
>  EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
>  
> -/*
> - * 'what should we do if we get a hw irq event on an illegal vector'.
> - * each architecture has to answer this themselves.
> - */
> -void ack_bad_irq(unsigned int irq)
> -{
> -	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
> -}
> -
>  static u32 concurrent_irq;
>  
>  void do_IRQ(struct pt_regs *regs)
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@itee.uq.edu.au
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
> 
> 


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Re: [microblaze-uclinux] [PATCH] microblaze: convert to asm-generic/hardirq.h

[Christoph Hellwig]

On Thu, Aug 06, 2009 at 04:55:40PM +0200, Michal Simek wrote:
> Hi Christoph,
> 
> Can you please change your patch title?
> You are removing ack_bad_irq not convert to hardirq.h
> 
> But anyway will be worth to remove it from other archs too.

Oh sorry, I copied the patch from various other architectures I touched
at the same time.  I have been wading throug all architectures to
convert them to asm-generic/hardirq.h and the generic ack_bad_irq and
sent out lots of patches for it.  A couple of architectures do count
bad irqs instead of just printing a message, but even those counters
could be unified.  The only genirq architectecture that does something
weird in ack_bad_irq is mips.

--


Subject: microblaze: use the generic ack_bad_irq implementation
From: Christoph Hellwig <hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
===================================================================
--- linux-2.6.orig/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:32:58.596148711 +0200
+++ linux-2.6/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:56:30.691912378 +0200
@@ -12,8 +12,6 @@
 /* should be defined in each interrupt controller driver */
 extern unsigned int get_irq(struct pt_regs *regs);
 
-#define ack_bad_irq ack_bad_irq
-void ack_bad_irq(unsigned int irq);
 #include <asm-generic/hardirq.h>
 
 #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
Index: linux-2.6/arch/microblaze/kernel/irq.c
===================================================================
--- linux-2.6.orig/arch/microblaze/kernel/irq.c	2009-07-27 14:53:45.847149312 +0200
+++ linux-2.6/arch/microblaze/kernel/irq.c	2009-07-27 14:56:37.121902184 +0200
@@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
 }
 EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
 
-/*
- * 'what should we do if we get a hw irq event on an illegal vector'.
- * each architecture has to answer this themselves.
- */
-void ack_bad_irq(unsigned int irq)
-{
-	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
-}
-
 static u32 concurrent_irq;
 
 void do_IRQ(struct pt_regs *regs)

Re: [microblaze-uclinux] [PATCH] microblaze: convert to asm-generic/hardirq.h

[Michal Simek]

Christoph Hellwig wrote:
> On Thu, Aug 06, 2009 at 04:55:40PM +0200, Michal Simek wrote:
>> Hi Christoph,
>>
>> Can you please change your patch title?
>> You are removing ack_bad_irq not convert to hardirq.h
>>
>> But anyway will be worth to remove it from other archs too.
> 
> Oh sorry, I copied the patch from various other architectures I touched
> at the same time.  I have been wading throug all architectures to
> convert them to asm-generic/hardirq.h and the generic ack_bad_irq and
> sent out lots of patches for it.  A couple of architectures do count
> bad irqs instead of just printing a message, but even those counters
> could be unified.  The only genirq architectecture that does something
> weird in ack_bad_irq is mips.

No worries. Added to next branch.

Thanks,
Michal


> 
> --
> 
> 
> Subject: microblaze: use the generic ack_bad_irq implementation
> From: Christoph Hellwig <hch@lst.de>
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/arch/microblaze/include/asm/hardirq.h
> ===================================================================
> --- linux-2.6.orig/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:32:58.596148711 +0200
> +++ linux-2.6/arch/microblaze/include/asm/hardirq.h	2009-07-27 14:56:30.691912378 +0200
> @@ -12,8 +12,6 @@
>  /* should be defined in each interrupt controller driver */
>  extern unsigned int get_irq(struct pt_regs *regs);
>  
> -#define ack_bad_irq ack_bad_irq
> -void ack_bad_irq(unsigned int irq);
>  #include <asm-generic/hardirq.h>
>  
>  #endif /* _ASM_MICROBLAZE_HARDIRQ_H */
> Index: linux-2.6/arch/microblaze/kernel/irq.c
> ===================================================================
> --- linux-2.6.orig/arch/microblaze/kernel/irq.c	2009-07-27 14:53:45.847149312 +0200
> +++ linux-2.6/arch/microblaze/kernel/irq.c	2009-07-27 14:56:37.121902184 +0200
> @@ -30,15 +30,6 @@ unsigned int irq_of_parse_and_map(struct
>  }
>  EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
>  
> -/*
> - * 'what should we do if we get a hw irq event on an illegal vector'.
> - * each architecture has to answer this themselves.
> - */
> -void ack_bad_irq(unsigned int irq)
> -{
> -	printk(KERN_WARNING "unexpected IRQ trap at vector %02x\n", irq);
> -}
> -
>  static u32 concurrent_irq;
>  
>  void do_IRQ(struct pt_regs *regs)
> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@itee.uq.edu.au
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
> 
> 

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian