All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards...
@ 2009-07-13 19:13 Michael Evans
  2009-07-13 20:01 ` Wolfgang Denk
  2009-08-08  9:58 ` Wolfgang Denk
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Evans @ 2009-07-13 19:13 UTC (permalink / raw)
  To: u-boot


Updated as per comments to use SOC (system-on-chip) variable.  Also updated diff layout to be compatible with other patches.

Regards,  Mike.

Description:
The attached patch corrects an error in the
examples/Makefile which causes the applications in the examples
directory to hang on OMAP3 based boards.  The current Makefile sets
-Ttext during linking to 0x0c100000 which is outside of addressable
SDRAM memory.  The script corrects the existing ifeq...else...endif
logic to look at the VENDOR tag rather than the CPU tag.

The
patch affects the following configs: omap3_beagle_config,
omap3_overo_config, omap3_evm_config, omap3_pandora_config,
omap3_zoom1_config and omap3_zoom2_config.

Signed-off-by: Michael Evans <horse_dung@hotmail.com>

Patch:
diff --git a/examples/Makefile b/examples/Makefile
--- a/examples/Makefile    2009-07-03 12:38:48.000000000 +0100
+++ b/examples/Makefile    2009-07-13 10:35:03.000000000 +0100
@@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
 ifeq ($(BOARD),omap2420h4)
 LOAD_ADDR = 0x80300000
 else
-ifeq ($(CPU),omap3)
+ifeq ($(SOC),omap3)
 LOAD_ADDR = 0x80300000
 else
 LOAD_ADDR = 0xc100000


From: horse_dung@hotmail.com
To: u-boot at lists.denx.de
Subject: PATCH: Fix examples for OMAP3 boards...
Date: Thu, 18 Jun 2009 10:34:54 +0100








--- examples/Makefile.orig    2009-06-18 10:14:44.000000000 +0100
+++ examples/Makefile    2009-06-18 10:14:52.000000000 +0100
@@ -33,7 +33,7 @@ ifeq ($(ARCH),arm) 
 ifeq ($(BOARD),omap2420h4)
 LOAD_ADDR = 0x80300000
 else
-ifeq ($(CPU),omap3)
+ifeq ($(VENDOR),omap3)
 LOAD_ADDR = 0x80300000
 else
 LOAD_ADDR = 0xc100000


Beyond Hotmail - see what else you can do with Windows Live. Find out more.
_________________________________________________________________
Get the best of MSN on your mobile
http://clk.atdmt.com/UKM/go/147991039/direct/01/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards...
  2009-07-13 19:13 [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards Michael Evans
@ 2009-07-13 20:01 ` Wolfgang Denk
  2009-08-08  9:58 ` Wolfgang Denk
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-07-13 20:01 UTC (permalink / raw)
  To: u-boot

Dear Michael Evans,

In message <COL112-W346B71981DA8D3CE1F25A1EB220@phx.gbl> you wrote:
>
> Updated as per comments to use SOC (system-on-chip) variable.  Also updated diff layout to be compatible with other patches.
>
> Regards,  Mike.

Please stick to patch posting rules (line length, commit message,
comments below "---" line; and, first of all: please use
git-format-patch to format the patch and don't mess with the format
then.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of programmers carrying screwdrivers."      - Chip Salzenberg

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards...
  2009-07-13 19:13 [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards Michael Evans
  2009-07-13 20:01 ` Wolfgang Denk
@ 2009-08-08  9:58 ` Wolfgang Denk
  2009-08-09 19:23   ` Michael Evans
  1 sibling, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2009-08-08  9:58 UTC (permalink / raw)
  To: u-boot

Dear Michael Evans,

In message <COL112-W346B71981DA8D3CE1F25A1EB220@phx.gbl> you wrote:
> 
> Updated as per comments to use SOC (system-on-chip) variable.  Also updated=
>  diff layout to be compatible with other patches.
> 
> Regards=2C  Mike.
> 
> Description:
> The attached patch corrects an error in the
> examples/Makefile which causes the applications in the examples
> directory to hang on OMAP3 based boards.  The current Makefile sets
> -Ttext during linking to 0x0c100000 which is outside of addressable
> SDRAM memory.  The script corrects the existing ifeq...else...endif
> logic to look at the VENDOR tag rather than the CPU tag.
> 
> The
> patch affects the following configs: omap3_beagle_config,
> omap3_overo_config, omap3_evm_config, omap3_pandora_config,
> omap3_zoom1_config and omap3_zoom2_config.
>
> Signed-off-by: Michael Evans <horse_dung@hotmail.com>
>
> Patch:
> diff --git a/examples/Makefile b/examples/Makefile
> --- a/examples/Makefile    2009-07-03 12:38:48.000000000 +0100
> +++ b/examples/Makefile    2009-07-13 10:35:03.000000000 +0100
> @@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
>  ifeq ($(BOARD),omap2420h4)
>  LOAD_ADDR = 0x80300000
>  else
> -ifeq ($(CPU),omap3)
> +ifeq ($(SOC),omap3)
>  LOAD_ADDR = 0x80300000
>  else
>  LOAD_ADDR = 0xc100000

Applied, after manually fixing the aforementioned issues.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hello! I'm from outer space,  and I've made myself look like a signa-
ture.  While  you  are reading this, I'm having sex with your eyes. I
know it feels good to you, because you're smiling. I'm very horny, so
send me to someone else when you've had enough. Thanks!
                              Sincerely, A Stranger in a Strange Land

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards...
  2009-08-08  9:58 ` Wolfgang Denk
@ 2009-08-09 19:23   ` Michael Evans
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Evans @ 2009-08-09 19:23 UTC (permalink / raw)
  To: u-boot


Many thanks Wolfgang, not been able to do this myself as my develompent board had to be returned for repair...

> To: horse_dung at hotmail.com
> CC: u-boot at lists.denx.de
> From: wd at denx.de
> Subject: Re: [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards...
> Date: Sat, 8 Aug 2009 11:58:15 +0200
> 
> Dear Michael Evans,
> 
> In message <COL112-W346B71981DA8D3CE1F25A1EB220@phx.gbl> you wrote:
> > 
> > Updated as per comments to use SOC (system-on-chip) variable.  Also updated=
> >  diff layout to be compatible with other patches.
> > 
> > Regards=2C  Mike.
> > 
> > Description:
> > The attached patch corrects an error in the
> > examples/Makefile which causes the applications in the examples
> > directory to hang on OMAP3 based boards.  The current Makefile sets
> > -Ttext during linking to 0x0c100000 which is outside of addressable
> > SDRAM memory.  The script corrects the existing ifeq...else...endif
> > logic to look at the VENDOR tag rather than the CPU tag.
> > 
> > The
> > patch affects the following configs: omap3_beagle_config,
> > omap3_overo_config, omap3_evm_config, omap3_pandora_config,
> > omap3_zoom1_config and omap3_zoom2_config.
> >
> > Signed-off-by: Michael Evans <horse_dung@hotmail.com>
> >
> > Patch:
> > diff --git a/examples/Makefile b/examples/Makefile
> > --- a/examples/Makefile    2009-07-03 12:38:48.000000000 +0100
> > +++ b/examples/Makefile    2009-07-13 10:35:03.000000000 +0100
> > @@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
> >  ifeq ($(BOARD),omap2420h4)
> >  LOAD_ADDR = 0x80300000
> >  else
> > -ifeq ($(CPU),omap3)
> > +ifeq ($(SOC),omap3)
> >  LOAD_ADDR = 0x80300000
> >  else
> >  LOAD_ADDR = 0xc100000
> 
> Applied, after manually fixing the aforementioned issues.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Hello! I'm from outer space,  and I've made myself look like a signa-
> ture.  While  you  are reading this, I'm having sex with your eyes. I
> know it feels good to you, because you're smiling. I'm very horny, so
> send me to someone else when you've had enough. Thanks!
>                               Sincerely, A Stranger in a Strange Land

_________________________________________________________________

Upgrade to Internet Explorer 8 Optimised for MSN.  

http://extras.uk.msn.com/internet-explorer-8/?ocid=T010MSN07A0716U

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-09 19:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-13 19:13 [U-Boot] PATCH: (Updated) Fix examples for OMAP3 boards Michael Evans
2009-07-13 20:01 ` Wolfgang Denk
2009-08-08  9:58 ` Wolfgang Denk
2009-08-09 19:23   ` Michael Evans

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.