* [PATCH] x86: reget cfg_new in case reuse/move irq_desc
@ 2009-08-04 15:58 Yinghai Lu
2009-08-08 15:02 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2009-08-04 15:58 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin; +Cc: linux-kernel
when irq_desc is moved, we need to make sure to use right cfg_new
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/apic/io_apic.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -3153,6 +3153,7 @@ unsigned int create_irq_nr(unsigned int
continue;
desc_new = move_irq_desc(desc_new, node);
+ cfg_new = desc_new->chip_data;
if (__assign_irq_vector(new, cfg_new, apic->target_cpus()) == 0)
irq = new;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: reget cfg_new in case reuse/move irq_desc
2009-08-04 15:58 [PATCH] x86: reget cfg_new in case reuse/move irq_desc Yinghai Lu
@ 2009-08-08 15:02 ` Ingo Molnar
0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-08-08 15:02 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Thomas Gleixner, H. Peter Anvin, linux-kernel
* Yinghai Lu <yinghai@kernel.org> wrote:
> when irq_desc is moved, we need to make sure to use right cfg_new
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> arch/x86/kernel/apic/io_apic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
> +++ linux-2.6/arch/x86/kernel/apic/io_apic.c
> @@ -3153,6 +3153,7 @@ unsigned int create_irq_nr(unsigned int
> continue;
>
> desc_new = move_irq_desc(desc_new, node);
> + cfg_new = desc_new->chip_data;
>
i suspect we need this for .31? Did you see any actual bug due to
this? (if yes, how did it look like?)
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] x86: reget cfg_new in case reuse/move irq_desc
@ 2009-09-27 7:21 Yinghai Lu
0 siblings, 0 replies; 3+ messages in thread
From: Yinghai Lu @ 2009-09-27 7:21 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin; +Cc: linux-kernel
when irq_desc is moved, we need to make sure to use right cfg_new
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/apic/io_apic.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -3169,6 +3169,7 @@ unsigned int create_irq_nr(unsigned int
continue;
desc_new = move_irq_desc(desc_new, node);
+ cfg_new = desc_new->chip_data;
if (__assign_irq_vector(new, cfg_new, apic->target_cpus()) == 0)
irq = new;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-27 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-04 15:58 [PATCH] x86: reget cfg_new in case reuse/move irq_desc Yinghai Lu
2009-08-08 15:02 ` Ingo Molnar
2009-09-27 7:21 Yinghai Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.