* [PATCH] Input: Fix cleaning up KEY_STROBEs after error in tosakbd_probe()
@ 2009-08-21 14:05 Roel Kluin
2009-08-21 16:12 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-08-21 14:05 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input, Andrew Morton
Direct to fail2 to gpio_free() the KEY_STROBEs as well as the KEY_SENSEs.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Or is there an obscure reason why this shouldn't happen?
diff --git a/drivers/input/keyboard/tosakbd.c b/drivers/input/keyboard/tosakbd.c
index 677276b..72c06ef 100644
--- a/drivers/input/keyboard/tosakbd.c
+++ b/drivers/input/keyboard/tosakbd.c
@@ -344,7 +344,7 @@ static int __devinit tosakbd_probe(struct platform_device *pdev) {
" direction for GPIO %d, error %d\n",
gpio, error);
gpio_free(gpio);
- goto fail;
+ goto fail2;
}
}
@@ -353,7 +353,7 @@ static int __devinit tosakbd_probe(struct platform_device *pdev) {
if (error) {
printk(KERN_ERR "tosakbd: Unable to register input device, "
"error: %d\n", error);
- goto fail;
+ goto fail2;
}
printk(KERN_INFO "input: Tosa Keyboard Registered\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: Fix cleaning up KEY_STROBEs after error in tosakbd_probe()
2009-08-21 14:05 [PATCH] Input: Fix cleaning up KEY_STROBEs after error in tosakbd_probe() Roel Kluin
@ 2009-08-21 16:12 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-08-21 16:12 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-input, Andrew Morton
On Fri, Aug 21, 2009 at 04:05:44PM +0200, Roel Kluin wrote:
> Direct to fail2 to gpio_free() the KEY_STROBEs as well as the KEY_SENSEs.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied, thank you Roel.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-21 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-21 14:05 [PATCH] Input: Fix cleaning up KEY_STROBEs after error in tosakbd_probe() Roel Kluin
2009-08-21 16:12 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.