* [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create
@ 2009-08-26 11:37 Christoph Hellwig
2009-09-03 15:46 ` Christoph Hellwig
2009-09-03 16:35 ` [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create Alex Elder
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-08-26 11:37 UTC (permalink / raw)
To: xfs
We added the ENOSPC handling patch in xfs_create just after it got mered
with xfs_mkdir. Change the log reservation to the variable for either
the create or mkdir value so it does the right thing if get here for creating
a directory.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/xfs/xfs_vnodeops.c
===================================================================
--- xfs.orig/fs/xfs/xfs_vnodeops.c 2009-08-24 11:35:52.794261954 -0300
+++ xfs/fs/xfs/xfs_vnodeops.c 2009-08-24 11:36:25.466636450 -0300
@@ -1479,8 +1479,8 @@ xfs_create(
if (error == ENOSPC) {
/* flush outstanding delalloc blocks and retry */
xfs_flush_inodes(dp);
- error = xfs_trans_reserve(tp, resblks, XFS_CREATE_LOG_RES(mp), 0,
- XFS_TRANS_PERM_LOG_RES, XFS_CREATE_LOG_COUNT);
+ error = xfs_trans_reserve(tp, resblks, log_res, 0,
+ XFS_TRANS_PERM_LOG_RES, log_count);
}
if (error == ENOSPC) {
/* No space at all so try a "no-allocation" reservation */
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create
2009-08-26 11:37 [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create Christoph Hellwig
@ 2009-09-03 15:46 ` Christoph Hellwig
2009-09-03 16:35 ` [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-09-03 15:46 UTC (permalink / raw)
To: xfs
ping?
On Wed, Aug 26, 2009 at 07:37:36AM -0400, Christoph Hellwig wrote:
> We added the ENOSPC handling patch in xfs_create just after it got mered
> with xfs_mkdir. Change the log reservation to the variable for either
> the create or mkdir value so it does the right thing if get here for creating
> a directory.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_vnodeops.c 2009-08-24 11:35:52.794261954 -0300
> +++ xfs/fs/xfs/xfs_vnodeops.c 2009-08-24 11:36:25.466636450 -0300
> @@ -1479,8 +1479,8 @@ xfs_create(
> if (error == ENOSPC) {
> /* flush outstanding delalloc blocks and retry */
> xfs_flush_inodes(dp);
> - error = xfs_trans_reserve(tp, resblks, XFS_CREATE_LOG_RES(mp), 0,
> - XFS_TRANS_PERM_LOG_RES, XFS_CREATE_LOG_COUNT);
> + error = xfs_trans_reserve(tp, resblks, log_res, 0,
> + XFS_TRANS_PERM_LOG_RES, log_count);
> }
> if (error == ENOSPC) {
> /* No space at all so try a "no-allocation" reservation */
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create
2009-08-26 11:37 [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create Christoph Hellwig
2009-09-03 15:46 ` Christoph Hellwig
@ 2009-09-03 16:35 ` Alex Elder
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2009-09-03 16:35 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> We added the ENOSPC handling patch in xfs_create just after it got mered
> with xfs_mkdir. Change the log reservation to the variable for either
> the create or mkdir value so it does the right thing if get here for creating
> a directory.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_vnodeops.c 2009-08-24 11:35:52.794261954 -0300
> +++ xfs/fs/xfs/xfs_vnodeops.c 2009-08-24 11:36:25.466636450 -0300
> @@ -1479,8 +1479,8 @@ xfs_create(
> if (error == ENOSPC) {
> /* flush outstanding delalloc blocks and retry */
> xfs_flush_inodes(dp);
> - error = xfs_trans_reserve(tp, resblks, XFS_CREATE_LOG_RES(mp), 0,
> - XFS_TRANS_PERM_LOG_RES, XFS_CREATE_LOG_COUNT);
> + error = xfs_trans_reserve(tp, resblks, log_res, 0,
> + XFS_TRANS_PERM_LOG_RES, log_count);
> }
> if (error == ENOSPC) {
> /* No space at all so try a "no-allocation" reservation */
>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-03 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-26 11:37 [PATCH] xfs: use correct log reservation when handling ENOSPC in xfs_create Christoph Hellwig
2009-09-03 15:46 ` Christoph Hellwig
2009-09-03 16:35 ` [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.