All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 05/12] fix broken migration
Date: Thu, 27 Aug 2009 14:36:45 -0300	[thread overview]
Message-ID: <20090827173645.GB5746@mothafucka.localdomain> (raw)
In-Reply-To: <m3y6p6ciif.fsf@neno.mitica>

On Thu, Aug 27, 2009 at 12:33:44AM +0200, Juan Quintela wrote:
> Glauber Costa <glommer@redhat.com> wrote:
> > While fixing migration with -S, commit
> > 89befdd1a6b18215153b8976682d57b7d03d5782 broke the rest of us. Poor
> > glommer, with a poor family, spare him his life from this monstruosity.
> >
> > Since the unconditional vm_start, not autostart was the villain, I'm putting
> > back autostart. Let me know if you prefer other solutions, it doesn't really matter,
> > doesn't really matter to me.
> >
> > Any way the wind blows...
> 
> Please drop this one.  I agree with bonzini here.
> It breaks completely incoming migration, and conflicts with semantics of
> next one.
wrong semantics is not a problem here, as long as we keep the same semantics.

For master, I can agree that the work you've done leave us at a better shape, but
for stable-0.10, this patch is totally needed for migration to work.

  parent reply	other threads:[~2009-08-27 17:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26 13:05 [Qemu-devel] [GIT PULL] 0.10.7 stable release Glauber Costa
2009-08-26 13:05 ` [Qemu-devel] [PATCH 01/12] fix for bad macaddr of e1000 in Windows 2003 server with original MS driver Glauber Costa
2009-08-26 13:05   ` [Qemu-devel] [PATCH 02/12] Handle BH's queued by AIO completions in qemu_aio_flush() Glauber Costa
2009-08-26 13:05     ` [Qemu-devel] [PATCH 03/12] BACKPORT: Add save/restore support to the LSI logic SCSI device model Glauber Costa
2009-08-26 13:05       ` [Qemu-devel] [PATCH 04/12] vmdk: Fix backing file handling Glauber Costa
2009-08-26 13:05         ` [Qemu-devel] [PATCH 05/12] fix broken migration Glauber Costa
2009-08-26 13:05           ` [Qemu-devel] [PATCH 06/12] fix migration to obey -S Glauber Costa
2009-08-26 13:05             ` [Qemu-devel] [PATCH 07/12] BACKPORT: vnc: fix copyrect screen corruption Glauber Costa
2009-08-26 13:05               ` [Qemu-devel] [PATCH 08/12] e1000.c doesn't properly emulate EERD and ICS registers Glauber Costa
2009-08-26 13:05                 ` [Qemu-devel] [PATCH 09/12] make windows notice media change Glauber Costa
2009-08-26 13:05                   ` [Qemu-devel] [PATCH 10/12] BACKPORT: Fix segfault of qemu-system-arm with PXA target Glauber Costa
2009-08-26 13:05                     ` [Qemu-devel] [PATCH 11/12] Fix detached migration with exec Glauber Costa
2009-08-26 13:05                       ` [Qemu-devel] [PATCH 12/12] Don't segfault when changing VNC password on an SDL display Glauber Costa
2009-08-27  7:54                       ` [Qemu-devel] Re: [PATCH 11/12] Fix detached migration with exec Chris Lalancette
2009-10-01  9:21               ` [Qemu-devel] [PATCH 07/12] BACKPORT: vnc: fix copyrect screen corruption Mark McLoughlin
2009-08-26 18:15           ` [Qemu-devel] Re: [PATCH 05/12] fix broken migration Paolo Bonzini
     [not found]           ` <m3y6p6ciif.fsf@neno.mitica>
2009-08-27 17:36             ` Glauber Costa [this message]
2009-08-28  7:47               ` Paolo Bonzini
2009-08-26 17:50 ` [Qemu-devel] [GIT PULL] 0.10.7 stable release Chris Webb
2009-08-27  1:14   ` Glauber Costa
2009-08-27  8:56     ` Chris Webb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090827173645.GB5746@mothafucka.localdomain \
    --to=glommer@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@trasno.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.