From: Mel Gorman <mel@csn.ul.ie> To: Lee Schermerhorn <lee.schermerhorn@hp.com> Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Nishanth Aravamudan <nacc@us.ibm.com>, David Rientjes <rientjes@google.com>, linux-numa@vger.kernel.org, Adam Litke <agl@us.ibm.com>, Andy Whitcroft <apw@canonical.com>, eric.whitney@hp.com Subject: Re: [PATCH 4/6] hugetlb: introduce alloc_nodemask_of_node Date: Tue, 1 Sep 2009 15:49:32 +0100 [thread overview] Message-ID: <20090901144932.GB7548@csn.ul.ie> (raw) In-Reply-To: <20090828160338.11080.51282.sendpatchset@localhost.localdomain> On Fri, Aug 28, 2009 at 12:03:38PM -0400, Lee Schermerhorn wrote: > [PATCH 4/6] - hugetlb: introduce alloc_nodemask_of_node() > > Against: 2.6.31-rc7-mmotm-090827-0057 > > New in V5 of series > > Introduce nodemask macro to allocate a nodemask and > initialize it to contain a single node, using the macro > init_nodemask_of_node() factored out of the nodemask_of_node() > macro. > > alloc_nodemask_of_node() coded as a macro to avoid header > dependency hell. > > This will be used to construct the huge pages "nodes_allowed" > nodemask for a single node when a persistent huge page > pool page count is modified via a per node sysfs attribute. > > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> > > include/linux/nodemask.h | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > Index: linux-2.6.31-rc7-mmotm-090827-0057/include/linux/nodemask.h > =================================================================== > --- linux-2.6.31-rc7-mmotm-090827-0057.orig/include/linux/nodemask.h 2009-08-28 09:21:19.000000000 -0400 > +++ linux-2.6.31-rc7-mmotm-090827-0057/include/linux/nodemask.h 2009-08-28 09:21:29.000000000 -0400 > @@ -245,18 +245,34 @@ static inline int __next_node(int n, con > return min_t(int,MAX_NUMNODES,find_next_bit(srcp->bits, MAX_NUMNODES, n+1)); > } > > +#define init_nodemask_of_nodes(mask, node) \ > + nodes_clear(*(mask)); \ > + node_set((node), *(mask)); > + Is the done thing to either make this a static inline or else wrap it in a do { } while(0) ? The reasoning being that if this is used as part of an another statement (e.g. a for loop) that it'll actually compile instead of throw up weird error messages. > #define nodemask_of_node(node) \ > ({ \ > typeof(_unused_nodemask_arg_) m; \ > if (sizeof(m) == sizeof(unsigned long)) { \ > m.bits[0] = 1UL<<(node); \ > } else { \ > - nodes_clear(m); \ > - node_set((node), m); \ > + init_nodemask_of_nodes(&m, (node)); \ > } \ > m; \ > }) > > +/* > + * returns pointer to kmalloc()'d nodemask initialized to contain the > + * specified node. Caller must free with kfree(). > + */ > +#define alloc_nodemask_of_node(node) \ > +({ \ > + typeof(_unused_nodemask_arg_) *nmp; \ > + nmp = kmalloc(sizeof(*nmp), GFP_KERNEL); \ > + if (nmp) \ > + init_nodemask_of_nodes(nmp, (node)); \ > + nmp; \ > +}) > + Otherwise, it looks ok. > #define first_unset_node(mask) __first_unset_node(&(mask)) > static inline int __first_unset_node(const nodemask_t *maskp) > { > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie> To: Lee Schermerhorn <lee.schermerhorn@hp.com> Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Nishanth Aravamudan <nacc@us.ibm.com>, David Rientjes <rientjes@google.com>, linux-numa@vger.kernel.org, Adam Litke <agl@us.ibm.com>, Andy Whitcroft <apw@canonical.com>, eric.whitney@hp.com Subject: Re: [PATCH 4/6] hugetlb: introduce alloc_nodemask_of_node Date: Tue, 1 Sep 2009 15:49:32 +0100 [thread overview] Message-ID: <20090901144932.GB7548@csn.ul.ie> (raw) In-Reply-To: <20090828160338.11080.51282.sendpatchset@localhost.localdomain> On Fri, Aug 28, 2009 at 12:03:38PM -0400, Lee Schermerhorn wrote: > [PATCH 4/6] - hugetlb: introduce alloc_nodemask_of_node() > > Against: 2.6.31-rc7-mmotm-090827-0057 > > New in V5 of series > > Introduce nodemask macro to allocate a nodemask and > initialize it to contain a single node, using the macro > init_nodemask_of_node() factored out of the nodemask_of_node() > macro. > > alloc_nodemask_of_node() coded as a macro to avoid header > dependency hell. > > This will be used to construct the huge pages "nodes_allowed" > nodemask for a single node when a persistent huge page > pool page count is modified via a per node sysfs attribute. > > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> > > include/linux/nodemask.h | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > Index: linux-2.6.31-rc7-mmotm-090827-0057/include/linux/nodemask.h > =================================================================== > --- linux-2.6.31-rc7-mmotm-090827-0057.orig/include/linux/nodemask.h 2009-08-28 09:21:19.000000000 -0400 > +++ linux-2.6.31-rc7-mmotm-090827-0057/include/linux/nodemask.h 2009-08-28 09:21:29.000000000 -0400 > @@ -245,18 +245,34 @@ static inline int __next_node(int n, con > return min_t(int,MAX_NUMNODES,find_next_bit(srcp->bits, MAX_NUMNODES, n+1)); > } > > +#define init_nodemask_of_nodes(mask, node) \ > + nodes_clear(*(mask)); \ > + node_set((node), *(mask)); > + Is the done thing to either make this a static inline or else wrap it in a do { } while(0) ? The reasoning being that if this is used as part of an another statement (e.g. a for loop) that it'll actually compile instead of throw up weird error messages. > #define nodemask_of_node(node) \ > ({ \ > typeof(_unused_nodemask_arg_) m; \ > if (sizeof(m) == sizeof(unsigned long)) { \ > m.bits[0] = 1UL<<(node); \ > } else { \ > - nodes_clear(m); \ > - node_set((node), m); \ > + init_nodemask_of_nodes(&m, (node)); \ > } \ > m; \ > }) > > +/* > + * returns pointer to kmalloc()'d nodemask initialized to contain the > + * specified node. Caller must free with kfree(). > + */ > +#define alloc_nodemask_of_node(node) \ > +({ \ > + typeof(_unused_nodemask_arg_) *nmp; \ > + nmp = kmalloc(sizeof(*nmp), GFP_KERNEL); \ > + if (nmp) \ > + init_nodemask_of_nodes(nmp, (node)); \ > + nmp; \ > +}) > + Otherwise, it looks ok. > #define first_unset_node(mask) __first_unset_node(&(mask)) > static inline int __first_unset_node(const nodemask_t *maskp) > { > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
next prev parent reply other threads:[~2009-09-01 14:49 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-08-28 16:03 [PATCH 0/6] hugetlb: V5 constrain allocation/free based on task mempolicy Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-08-28 16:03 ` [PATCH 1/6] hugetlb: rework hstate_next_node_* functions Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-08-28 16:03 ` [PATCH 2/6] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-09-03 18:39 ` David Rientjes 2009-09-03 18:39 ` David Rientjes 2009-08-28 16:03 ` [PATCH 3/6] hugetlb: derive huge pages nodes allowed from task mempolicy Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-09-01 14:47 ` Mel Gorman 2009-09-01 14:47 ` Mel Gorman 2009-09-03 19:22 ` David Rientjes 2009-09-03 19:22 ` David Rientjes 2009-09-03 20:15 ` Lee Schermerhorn 2009-09-03 20:15 ` Lee Schermerhorn 2009-09-03 20:49 ` David Rientjes 2009-09-03 20:49 ` David Rientjes 2009-08-28 16:03 ` [PATCH 4/6] hugetlb: introduce alloc_nodemask_of_node Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-09-01 14:49 ` Mel Gorman [this message] 2009-09-01 14:49 ` Mel Gorman 2009-09-01 16:42 ` Lee Schermerhorn 2009-09-01 16:42 ` Lee Schermerhorn 2009-09-03 18:34 ` David Rientjes 2009-09-03 18:34 ` David Rientjes 2009-09-03 20:49 ` Lee Schermerhorn 2009-09-03 21:03 ` David Rientjes 2009-09-03 21:03 ` David Rientjes 2009-08-28 16:03 ` [PATCH 5/6] hugetlb: add per node hstate attributes Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-09-01 15:20 ` Mel Gorman 2009-09-01 15:20 ` Mel Gorman 2009-09-03 19:52 ` David Rientjes 2009-09-03 19:52 ` David Rientjes 2009-09-03 20:41 ` Lee Schermerhorn 2009-09-03 20:41 ` Lee Schermerhorn 2009-09-03 21:02 ` David Rientjes 2009-09-03 21:02 ` David Rientjes 2009-09-04 14:30 ` Lee Schermerhorn 2009-09-04 14:30 ` Lee Schermerhorn 2009-08-28 16:03 ` [PATCH 6/6] hugetlb: update hugetlb documentation for mempolicy based management Lee Schermerhorn 2009-08-28 16:03 ` Lee Schermerhorn 2009-09-03 20:07 ` David Rientjes 2009-09-03 20:07 ` David Rientjes 2009-09-03 21:09 ` Lee Schermerhorn 2009-09-03 21:09 ` Lee Schermerhorn 2009-09-03 21:25 ` David Rientjes 2009-09-08 10:44 ` Mel Gorman 2009-09-08 10:44 ` Mel Gorman 2009-09-08 19:51 ` David Rientjes 2009-09-08 20:04 ` Mel Gorman 2009-09-08 20:04 ` Mel Gorman 2009-09-08 20:18 ` David Rientjes 2009-09-08 21:41 ` Mel Gorman 2009-09-08 21:41 ` Mel Gorman 2009-09-08 22:54 ` David Rientjes 2009-09-09 8:16 ` Mel Gorman 2009-09-09 8:16 ` Mel Gorman 2009-09-09 20:44 ` David Rientjes 2009-09-10 12:26 ` Mel Gorman 2009-09-10 12:26 ` Mel Gorman 2009-09-11 22:27 ` David Rientjes 2009-09-11 22:27 ` David Rientjes 2009-09-14 13:33 ` Mel Gorman 2009-09-14 14:15 ` Lee Schermerhorn 2009-09-14 14:15 ` Lee Schermerhorn 2009-09-14 15:41 ` Mel Gorman 2009-09-14 15:41 ` Mel Gorman 2009-09-14 19:15 ` David Rientjes 2009-09-14 19:15 ` David Rientjes 2009-09-15 11:48 ` Mel Gorman 2009-09-15 11:48 ` Mel Gorman 2009-09-14 19:14 ` David Rientjes 2009-09-14 19:14 ` David Rientjes 2009-09-14 21:28 ` David Rientjes 2009-09-16 10:21 ` Mel Gorman 2009-09-03 20:42 ` Randy Dunlap 2009-09-04 15:23 ` Lee Schermerhorn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090901144932.GB7548@csn.ul.ie \ --to=mel@csn.ul.ie \ --cc=agl@us.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=apw@canonical.com \ --cc=eric.whitney@hp.com \ --cc=lee.schermerhorn@hp.com \ --cc=linux-mm@kvack.org \ --cc=linux-numa@vger.kernel.org \ --cc=nacc@us.ibm.com \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.