* [PATCH] ext3: Don't update superblock write time when filesystem is read-only
@ 2009-09-16 15:21 Theodore Ts'o
2009-09-16 17:27 ` Jan Kara
2009-09-17 14:46 ` Eric Sandeen
0 siblings, 2 replies; 7+ messages in thread
From: Theodore Ts'o @ 2009-09-16 15:21 UTC (permalink / raw)
To: Jan Kara; +Cc: Ext4 Developers List, Theodore Ts'o
This avoids updating the superblock write time when we are mounting
the root file system read/only but we need to replay the journal; at
that point, for people who are east of GMT and who make their clock
tick in localtime for Windows bug-for-bug compatibility, and this will
cause e2fsck to complain and force a full file system check.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
fs/ext3/super.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index a8d80a7..62c86af 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2321,7 +2321,18 @@ static int ext3_commit_super(struct super_block *sb,
if (!sbh)
return error;
- es->s_wtime = cpu_to_le32(get_seconds());
+ /*
+ * If the file system is mounted read-only, don't update the
+ * superblock write time. This avoids updating the superblock
+ * write time when we are mounting the root file system
+ * read/only but we need to replay the journal; at that point,
+ * for people who are east of GMT and who make their clock
+ * tick in localtime for Windows bug-for-bug compatibility,
+ * the clock is set in the future, and this will cause e2fsck
+ * to complain and force a full file system check.
+ */
+ if (!(sb->s_flags & MS_RDONLY))
+ es->s_wtime = cpu_to_le32(get_seconds());
es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));
es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));
BUFFER_TRACE(sbh, "marking dirty");
--
1.6.3.2.1.gb9f7d.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
2009-09-16 15:21 [PATCH] ext3: Don't update superblock write time when filesystem is read-only Theodore Ts'o
@ 2009-09-16 17:27 ` Jan Kara
2009-09-17 14:46 ` Eric Sandeen
1 sibling, 0 replies; 7+ messages in thread
From: Jan Kara @ 2009-09-16 17:27 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, Ext4 Developers List
On Wed 16-09-09 11:21:13, Theodore Ts'o wrote:
> This avoids updating the superblock write time when we are mounting
> the root file system read/only but we need to replay the journal; at
> that point, for people who are east of GMT and who make their clock
> tick in localtime for Windows bug-for-bug compatibility, and this will
> cause e2fsck to complain and force a full file system check.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Thanks. Added to my tree.
Honza
> ---
> fs/ext3/super.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index a8d80a7..62c86af 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2321,7 +2321,18 @@ static int ext3_commit_super(struct super_block *sb,
>
> if (!sbh)
> return error;
> - es->s_wtime = cpu_to_le32(get_seconds());
> + /*
> + * If the file system is mounted read-only, don't update the
> + * superblock write time. This avoids updating the superblock
> + * write time when we are mounting the root file system
> + * read/only but we need to replay the journal; at that point,
> + * for people who are east of GMT and who make their clock
> + * tick in localtime for Windows bug-for-bug compatibility,
> + * the clock is set in the future, and this will cause e2fsck
> + * to complain and force a full file system check.
> + */
> + if (!(sb->s_flags & MS_RDONLY))
> + es->s_wtime = cpu_to_le32(get_seconds());
> es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));
> es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));
> BUFFER_TRACE(sbh, "marking dirty");
> --
> 1.6.3.2.1.gb9f7d.dirty
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
2009-09-16 15:21 [PATCH] ext3: Don't update superblock write time when filesystem is read-only Theodore Ts'o
2009-09-16 17:27 ` Jan Kara
@ 2009-09-17 14:46 ` Eric Sandeen
1 sibling, 0 replies; 7+ messages in thread
From: Eric Sandeen @ 2009-09-17 14:46 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, Ext4 Developers List
Theodore Ts'o wrote:
> This avoids updating the superblock write time when we are mounting
> the root file system read/only but we need to replay the journal; at
> that point, for people who are east of GMT and who make their clock
> tick in localtime for Windows bug-for-bug compatibility, and this will
> cause e2fsck to complain and force a full file system check.
Just out of curiosity, why does e2fsck even care? Why is a fairly
common & explainable time delta the trigger for a full fsck?
It seems like this solution may have some implications for forensics, etc.
Thanks,
-Eric
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> fs/ext3/super.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index a8d80a7..62c86af 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2321,7 +2321,18 @@ static int ext3_commit_super(struct super_block *sb,
>
> if (!sbh)
> return error;
> - es->s_wtime = cpu_to_le32(get_seconds());
> + /*
> + * If the file system is mounted read-only, don't update the
> + * superblock write time. This avoids updating the superblock
> + * write time when we are mounting the root file system
> + * read/only but we need to replay the journal; at that point,
> + * for people who are east of GMT and who make their clock
> + * tick in localtime for Windows bug-for-bug compatibility,
> + * the clock is set in the future, and this will cause e2fsck
> + * to complain and force a full file system check.
> + */
> + if (!(sb->s_flags & MS_RDONLY))
> + es->s_wtime = cpu_to_le32(get_seconds());
> es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));
> es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));
> BUFFER_TRACE(sbh, "marking dirty");
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
2009-10-05 14:01 ` Theodore Tso
@ 2009-10-05 14:55 ` Jan Kara
0 siblings, 0 replies; 7+ messages in thread
From: Jan Kara @ 2009-10-05 14:55 UTC (permalink / raw)
To: Theodore Tso; +Cc: Jan Kara, Linux Kernel Developers List, sandeen
On Mon 05-10-09 10:01:18, Theodore Tso wrote:
> On Mon, Oct 05, 2009 at 02:24:09PM +0200, Jan Kara wrote:
> > On Sat 03-10-09 23:12:38, Theodore Ts'o wrote:
> > > This avoids updating the superblock write time when we are mounting
> > > the root file system read/only but we need to replay the journal; at
> > > that point, for people who are east of GMT and who make their clock
> > > tick in localtime for Windows bug-for-bug compatibility, and this will
> > > cause e2fsck to complain and force a full file system check.
> > Thanks, the patch is queued in my queue already. I just held it for a
> > while because Eric also had a valid point - maybe fsck is too strict when
> > it forces a full filesystem check just because the superblock write time is
> > in future? On a pc-class hw, clocks go often wrong. Even I remember setting
> > system clock on my desktop a few hours back because it just gets out of
> > sync and I don't run NTP...
> > So I'm not against your patch because it can help in some cases and
> > it's not a big deal but I think a proper fix would be in fsck...
>
> Regardless of whether fsck relaxes its check, if the filesystem is
> mounted read-only, I don't think the last write time should change...
Yeah, that's also a reasonable argument, although in fact the filesystem
has changed (we replayed the journal) so I can also see a reason to keep
updating it.
Anyway, as I said above, I'm not against the patch. I'll push it to Linus
this week.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
2009-10-05 12:24 ` Jan Kara
@ 2009-10-05 14:01 ` Theodore Tso
2009-10-05 14:55 ` Jan Kara
0 siblings, 1 reply; 7+ messages in thread
From: Theodore Tso @ 2009-10-05 14:01 UTC (permalink / raw)
To: Jan Kara; +Cc: Linux Kernel Developers List, sandeen
On Mon, Oct 05, 2009 at 02:24:09PM +0200, Jan Kara wrote:
> On Sat 03-10-09 23:12:38, Theodore Ts'o wrote:
> > This avoids updating the superblock write time when we are mounting
> > the root file system read/only but we need to replay the journal; at
> > that point, for people who are east of GMT and who make their clock
> > tick in localtime for Windows bug-for-bug compatibility, and this will
> > cause e2fsck to complain and force a full file system check.
> Thanks, the patch is queued in my queue already. I just held it for a
> while because Eric also had a valid point - maybe fsck is too strict when
> it forces a full filesystem check just because the superblock write time is
> in future? On a pc-class hw, clocks go often wrong. Even I remember setting
> system clock on my desktop a few hours back because it just gets out of
> sync and I don't run NTP...
> So I'm not against your patch because it can help in some cases and
> it's not a big deal but I think a proper fix would be in fsck...
Regardless of whether fsck relaxes its check, if the filesystem is
mounted read-only, I don't think the last write time should change...
- Ted
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext3: Don't update superblock write time when filesystem is read-only
2009-10-04 3:12 Theodore Ts'o
@ 2009-10-05 12:24 ` Jan Kara
2009-10-05 14:01 ` Theodore Tso
0 siblings, 1 reply; 7+ messages in thread
From: Jan Kara @ 2009-10-05 12:24 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Jan Kara, Linux Kernel Developers List, sandeen
On Sat 03-10-09 23:12:38, Theodore Ts'o wrote:
> This avoids updating the superblock write time when we are mounting
> the root file system read/only but we need to replay the journal; at
> that point, for people who are east of GMT and who make their clock
> tick in localtime for Windows bug-for-bug compatibility, and this will
> cause e2fsck to complain and force a full file system check.
Thanks, the patch is queued in my queue already. I just held it for a
while because Eric also had a valid point - maybe fsck is too strict when
it forces a full filesystem check just because the superblock write time is
in future? On a pc-class hw, clocks go often wrong. Even I remember setting
system clock on my desktop a few hours back because it just gets out of
sync and I don't run NTP...
So I'm not against your patch because it can help in some cases and
it's not a big deal but I think a proper fix would be in fsck...
Honza
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> fs/ext3/super.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 72743d3..7a520a8 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2321,7 +2321,18 @@ static int ext3_commit_super(struct super_block *sb,
>
> if (!sbh)
> return error;
> - es->s_wtime = cpu_to_le32(get_seconds());
> + /*
> + * If the file system is mounted read-only, don't update the
> + * superblock write time. This avoids updating the superblock
> + * write time when we are mounting the root file system
> + * read/only but we need to replay the journal; at that point,
> + * for people who are east of GMT and who make their clock
> + * tick in localtime for Windows bug-for-bug compatibility,
> + * the clock is set in the future, and this will cause e2fsck
> + * to complain and force a full file system check.
> + */
> + if (!(sb->s_flags & MS_RDONLY))
> + es->s_wtime = cpu_to_le32(get_seconds());
> es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));
> es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));
> BUFFER_TRACE(sbh, "marking dirty");
> --
> 1.6.4.4.2.g31f8e.dirty
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ext3: Don't update superblock write time when filesystem is read-only
@ 2009-10-04 3:12 Theodore Ts'o
2009-10-05 12:24 ` Jan Kara
0 siblings, 1 reply; 7+ messages in thread
From: Theodore Ts'o @ 2009-10-04 3:12 UTC (permalink / raw)
To: Jan Kara; +Cc: Linux Kernel Developers List, Theodore Ts'o
This avoids updating the superblock write time when we are mounting
the root file system read/only but we need to replay the journal; at
that point, for people who are east of GMT and who make their clock
tick in localtime for Windows bug-for-bug compatibility, and this will
cause e2fsck to complain and force a full file system check.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
fs/ext3/super.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 72743d3..7a520a8 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2321,7 +2321,18 @@ static int ext3_commit_super(struct super_block *sb,
if (!sbh)
return error;
- es->s_wtime = cpu_to_le32(get_seconds());
+ /*
+ * If the file system is mounted read-only, don't update the
+ * superblock write time. This avoids updating the superblock
+ * write time when we are mounting the root file system
+ * read/only but we need to replay the journal; at that point,
+ * for people who are east of GMT and who make their clock
+ * tick in localtime for Windows bug-for-bug compatibility,
+ * the clock is set in the future, and this will cause e2fsck
+ * to complain and force a full file system check.
+ */
+ if (!(sb->s_flags & MS_RDONLY))
+ es->s_wtime = cpu_to_le32(get_seconds());
es->s_free_blocks_count = cpu_to_le32(ext3_count_free_blocks(sb));
es->s_free_inodes_count = cpu_to_le32(ext3_count_free_inodes(sb));
BUFFER_TRACE(sbh, "marking dirty");
--
1.6.4.4.2.g31f8e.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-10-05 14:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-16 15:21 [PATCH] ext3: Don't update superblock write time when filesystem is read-only Theodore Ts'o
2009-09-16 17:27 ` Jan Kara
2009-09-17 14:46 ` Eric Sandeen
2009-10-04 3:12 Theodore Ts'o
2009-10-05 12:24 ` Jan Kara
2009-10-05 14:01 ` Theodore Tso
2009-10-05 14:55 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.