All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze.
@ 2009-09-15 16:50 Lennart Sorensen
  2009-09-17  7:38 ` Greg Ungerer
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-15 16:50 UTC (permalink / raw)
  To: linux-kernel
  Cc: Len Sorensen, Greg Ungerer, Yoshinori Sato, microblaze-uclinux

Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
to show kilobytes as claimed rather than number of pages.

Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
index 9942f24..3342f49 100644
--- a/arch/h8300/mm/init.c
+++ b/arch/h8300/mm/init.c
@@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk ("Freeing initrd memory: %dk freed\n", pages);
+	printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 
diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
index b1703c6..f3236d0 100644
--- a/arch/m68knommu/mm/init.c
+++ b/arch/m68knommu/mm/init.c
@@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
+	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 
diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
index f207f1a..ed5f96b 100644
--- a/arch/microblaze/mm/init.c
+++ b/arch/microblaze/mm/init.c
@@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
+	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze.
  2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
@ 2009-09-17  7:38 ` Greg Ungerer
  2009-09-17  8:56   ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
  2009-09-17 13:23 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Yoshinori Sato
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 16+ messages in thread
From: Greg Ungerer @ 2009-09-17  7:38 UTC (permalink / raw)
  To: Lennart Sorensen
  Cc: linux-kernel, Greg Ungerer, Yoshinori Sato, microblaze-uclinux

Hi Lennart,

Lennart Sorensen wrote:
> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
> to show kilobytes as claimed rather than number of pages.
> 
> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

Looks ok to me. I can take and push the m68knommu part separately.
Or if Andrew wants to take it all as one, here is an:

Acked-by: Greg Ungerer <gerg@uclinux.org>


Regards
Greg


> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
> index 9942f24..3342f49 100644
> --- a/arch/h8300/mm/init.c
> +++ b/arch/h8300/mm/init.c
> @@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk ("Freeing initrd memory: %dk freed\n", pages);
> +	printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
> index b1703c6..f3236d0 100644
> --- a/arch/m68knommu/mm/init.c
> +++ b/arch/m68knommu/mm/init.c
> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index f207f1a..ed5f96b 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd
  2009-09-17  7:38 ` Greg Ungerer
@ 2009-09-17  8:56   ` Michal Simek
  2009-09-17 15:21     ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Lennart Sorensen
  0 siblings, 1 reply; 16+ messages in thread
From: Michal Simek @ 2009-09-17  8:56 UTC (permalink / raw)
  To: microblaze-uclinux
  Cc: Lennart Sorensen, linux-kernel, Greg Ungerer, Yoshinori Sato



Greg Ungerer wrote:
> Hi Lennart,
> 
> Lennart Sorensen wrote:
>> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
>> to show kilobytes as claimed rather than number of pages.
>>
>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> 
> Looks ok to me. I can take and push the m68knommu part separately.
> Or if Andrew wants to take it all as one, here is an:
> 
> Acked-by: Greg Ungerer <gerg@uclinux.org>

As Greg wrote. It will be the best to push it separately. IMHO it
will be faster. It is up to you. If you want to add it to microblaze
branch please send only patch for microblaze.

If not.

Acked-by: Michal Simek <monstr@monstr.eu>


Thanks,
Michal



> 
> 
> Regards
> Greg
> 
> 
>> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
>> index 9942f24..3342f49 100644
>> --- a/arch/h8300/mm/init.c
>> +++ b/arch/h8300/mm/init.c
>> @@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk ("Freeing initrd memory: %dk freed\n", pages);
>> +    printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE
>> / 1024));
>>  }
>>  #endif
>>  
>> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
>> index b1703c6..f3236d0 100644
>> --- a/arch/m68knommu/mm/init.c
>> +++ b/arch/m68knommu/mm/init.c
>> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>> +    printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages *
>> (PAGE_SIZE / 1024));
>>  }
>>  #endif
>>  
>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>> index f207f1a..ed5f96b 100644
>> --- a/arch/microblaze/mm/init.c
>> +++ b/arch/microblaze/mm/init.c
>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned
>> long end)
>>          totalram_pages++;
>>          pages++;
>>      }
>> -    printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>> +    printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages *
>> (PAGE_SIZE / 1024));
>>  }
>>  #endif
>>  
>>
> 

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze.
  2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
  2009-09-17  7:38 ` Greg Ungerer
@ 2009-09-17 13:23 ` Yoshinori Sato
  2009-09-17 15:46 ` Lennart Sorensen
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Yoshinori Sato @ 2009-09-17 13:23 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: linux-kernel, Greg Ungerer, microblaze-uclinux

At Tue, 15 Sep 2009 12:50:37 -0400,
Lennart Sorensen wrote:
> 
> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
> to show kilobytes as claimed rather than number of pages.
> 
> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> 
> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
> index 9942f24..3342f49 100644
> --- a/arch/h8300/mm/init.c
> +++ b/arch/h8300/mm/init.c
> @@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk ("Freeing initrd memory: %dk freed\n", pages);
> +	printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
> index b1703c6..f3236d0 100644
> --- a/arch/m68knommu/mm/init.c
> +++ b/arch/m68knommu/mm/init.c
> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index f207f1a..ed5f96b 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  

Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd
  2009-09-17  8:56   ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
@ 2009-09-17 15:21     ` Lennart Sorensen
  2009-09-17 15:39       ` [microblaze-uclinux] =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
  0 siblings, 1 reply; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:21 UTC (permalink / raw)
  To: Michal Simek
  Cc: microblaze-uclinux, linux-kernel, Greg Ungerer, Yoshinori Sato

On Thu, Sep 17, 2009 at 10:56:16AM +0200, Michal Simek wrote:
> Greg Ungerer wrote:
> > Hi Lennart,
> > 
> > Lennart Sorensen wrote:
> >> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
> >> to show kilobytes as claimed rather than number of pages.
> >>
> >> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> > 
> > Looks ok to me. I can take and push the m68knommu part separately.
> > Or if Andrew wants to take it all as one, here is an:
> > 
> > Acked-by: Greg Ungerer <gerg@uclinux.org>
> 
> As Greg wrote. It will be the best to push it separately. IMHO it
> will be faster. It is up to you. If you want to add it to microblaze
> branch please send only patch for microblaze.
> 
> If not.
> 
> Acked-by: Michal Simek <monstr@monstr.eu>

Oh right how silly of me.  3 seperate patches would have been nicer I
guess.  The original code is certainly copied from one place to the others
although I have no idea which architecture was the first to get it wrong.

Would everyone prefer I made 3 patches instead and resent them?

-- 
Len Sorensen

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [microblaze-uclinux] Re: =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd
  2009-09-17 15:21     ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Lennart Sorensen
@ 2009-09-17 15:39       ` Michal Simek
  2009-09-17 15:50         ` Lennart Sorensen
  0 siblings, 1 reply; 16+ messages in thread
From: Michal Simek @ 2009-09-17 15:39 UTC (permalink / raw)
  To: microblaze-uclinux
  Cc: Michal Simek, linux-kernel, Greg Ungerer, Yoshinori Sato



lsorense@csclub.uwaterloo.ca wrote:
> On Thu, Sep 17, 2009 at 10:56:16AM +0200, Michal Simek wrote:
>> Greg Ungerer wrote:
>>> Hi Lennart,
>>>
>>> Lennart Sorensen wrote:
>>>> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
>>>> to show kilobytes as claimed rather than number of pages.
>>>>
>>>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>> Looks ok to me. I can take and push the m68knommu part separately.
>>> Or if Andrew wants to take it all as one, here is an:
>>>
>>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>> As Greg wrote. It will be the best to push it separately. IMHO it
>> will be faster. It is up to you. If you want to add it to microblaze
>> branch please send only patch for microblaze.
>>
>> If not.
>>
>> Acked-by: Michal Simek <monstr@monstr.eu>
> 
> Oh right how silly of me.  3 seperate patches would have been nicer I
> guess.  The original code is certainly copied from one place to the others
> although I have no idea which architecture was the first to get it wrong.
> 
> Would everyone prefer I made 3 patches instead and resent them?

Just do it for microblaze

Thanks,
Michal


> 

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze.
  2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
  2009-09-17  7:38 ` Greg Ungerer
  2009-09-17 13:23 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Yoshinori Sato
@ 2009-09-17 15:46 ` Lennart Sorensen
  2009-09-17 15:47   ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze Lennart Sorensen
  2009-09-17 15:48 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300 Lennart Sorensen
  2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
  4 siblings, 1 reply; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:46 UTC (permalink / raw)
  To: linux-kernel; +Cc: microblaze-uclinux

Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
claimed rather than number of pages.

Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
index f207f1a..ed5f96b 100644
--- a/arch/microblaze/mm/init.c
+++ b/arch/microblaze/mm/init.c
@@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
+	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
  2009-09-17 15:46 ` Lennart Sorensen
@ 2009-09-17 15:47   ` Lennart Sorensen
  2009-09-21 12:39     ` Michal Simek
  0 siblings, 1 reply; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: microblaze-uclinux

Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
claimed rather than number of pages.

Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
index f207f1a..ed5f96b 100644
--- a/arch/microblaze/mm/init.c
+++ b/arch/microblaze/mm/init.c
@@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
+	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 
-- 
Len Sorensen

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300.
  2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
                   ` (2 preceding siblings ...)
  2009-09-17 15:46 ` Lennart Sorensen
@ 2009-09-17 15:48 ` Lennart Sorensen
  2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
  4 siblings, 0 replies; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:48 UTC (permalink / raw)
  To: linux-kernel; +Cc: Yoshinori Sato

Fix "Freeing initrd memory:" message on h8300 to show kilobytes as
claimed rather than number of pages.

Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
index 9942f24..3342f49 100644
--- a/arch/h8300/mm/init.c
+++ b/arch/h8300/mm/init.c
@@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk ("Freeing initrd memory: %dk freed\n", pages);
+	printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 
-- 
Len Sorensen

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu.
  2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
                   ` (3 preceding siblings ...)
  2009-09-17 15:48 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300 Lennart Sorensen
@ 2009-09-17 15:49 ` Lennart Sorensen
  2009-09-18  0:58   ` Greg Ungerer
  4 siblings, 1 reply; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:49 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Ungerer

Fix "Freeing initrd memory:" message m68knommu to show kilobytes as
claimed rather than number of pages.

Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
index b1703c6..f3236d0 100644
--- a/arch/m68knommu/mm/init.c
+++ b/arch/m68knommu/mm/init.c
@@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
 		totalram_pages++;
 		pages++;
 	}
-	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
+	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
 }
 #endif
 
-- 
Len Sorensen

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [microblaze-uclinux] Re: =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd
  2009-09-17 15:39       ` [microblaze-uclinux] =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
@ 2009-09-17 15:50         ` Lennart Sorensen
  0 siblings, 0 replies; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-17 15:50 UTC (permalink / raw)
  To: Michal Simek
  Cc: microblaze-uclinux, linux-kernel, Greg Ungerer, Yoshinori Sato

On Thu, Sep 17, 2009 at 05:39:10PM +0200, Michal Simek wrote:
> 
> 
> lsorense@csclub.uwaterloo.ca wrote:
> > On Thu, Sep 17, 2009 at 10:56:16AM +0200, Michal Simek wrote:
> >> Greg Ungerer wrote:
> >>> Hi Lennart,
> >>>
> >>> Lennart Sorensen wrote:
> >>>> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
> >>>> to show kilobytes as claimed rather than number of pages.
> >>>>
> >>>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> >>> Looks ok to me. I can take and push the m68knommu part separately.
> >>> Or if Andrew wants to take it all as one, here is an:
> >>>
> >>> Acked-by: Greg Ungerer <gerg@uclinux.org>
> >> As Greg wrote. It will be the best to push it separately. IMHO it
> >> will be faster. It is up to you. If you want to add it to microblaze
> >> branch please send only patch for microblaze.
> >>
> >> If not.
> >>
> >> Acked-by: Michal Simek <monstr@monstr.eu>
> > 
> > Oh right how silly of me.  3 seperate patches would have been nicer I
> > guess.  The original code is certainly copied from one place to the others
> > although I have no idea which architecture was the first to get it wrong.
> > 
> > Would everyone prefer I made 3 patches instead and resent them?
> 
> Just do it for microblaze

Well I just sent a seperate one for each.  I misspelled h8300 (as h3800)
in the comment before.

-- 
Len Sorensen

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu.
  2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
@ 2009-09-18  0:58   ` Greg Ungerer
  0 siblings, 0 replies; 16+ messages in thread
From: Greg Ungerer @ 2009-09-18  0:58 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: linux-kernel, Greg Ungerer

Hi Lennart,

Lennart Sorensen wrote:
> Fix "Freeing initrd memory:" message m68knommu to show kilobytes as
> claimed rather than number of pages.
> 
> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

Looks good. I have applied to the m68knommu git tree.

Regards
Greg


> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
> index b1703c6..f3236d0 100644
> --- a/arch/m68knommu/mm/init.c
> +++ b/arch/m68knommu/mm/init.c
> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
  2009-09-17 15:47   ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze Lennart Sorensen
@ 2009-09-21 12:39     ` Michal Simek
  2009-09-21 13:32       ` Lennart Sorensen
  0 siblings, 1 reply; 16+ messages in thread
From: Michal Simek @ 2009-09-21 12:39 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: linux-kernel, microblaze-uclinux

Added to next branch.

There were some problems which I fixed.
1. long first description
2. missing microblaze: at the beginning
3. line longer than 80chars

Thanks,
Michal


Lennart Sorensen wrote:
> Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
> claimed rather than number of pages.
> 
> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
> 
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index f207f1a..ed5f96b 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
  2009-09-21 12:39     ` Michal Simek
@ 2009-09-21 13:32       ` Lennart Sorensen
  2009-09-21 16:34         ` Michal Simek
  0 siblings, 1 reply; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-21 13:32 UTC (permalink / raw)
  To: michal.simek; +Cc: linux-kernel, microblaze-uclinux

On Mon, Sep 21, 2009 at 02:39:18PM +0200, Michal Simek wrote:
> Added to next branch.
>
> There were some problems which I fixed.
> 1. long first description
> 2. missing microblaze: at the beginning

Missing what?

> 3. line longer than 80chars

Hmm, I thought for sure I had checkpatch.pl claiming all my lines
were OK.  Odd.  Clearly the one below is longer though.  How strange.

>
> Lennart Sorensen wrote:
>> Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
>> claimed rather than number of pages.
>>
>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>
>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>> index f207f1a..ed5f96b 100644
>> --- a/arch/microblaze/mm/init.c
>> +++ b/arch/microblaze/mm/init.c
>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>  		totalram_pages++;
>>  		pages++;
>>  	}
>> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>>  }
>>  #endif
>>  

-- 
Len Sorensen

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
  2009-09-21 13:32       ` Lennart Sorensen
@ 2009-09-21 16:34         ` Michal Simek
  2009-09-21 18:03           ` Lennart Sorensen
  0 siblings, 1 reply; 16+ messages in thread
From: Michal Simek @ 2009-09-21 16:34 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: linux-kernel, microblaze-uclinux

Lennart Sorensen wrote:
> On Mon, Sep 21, 2009 at 02:39:18PM +0200, Michal Simek wrote:
>> Added to next branch.
>>
>> There were some problems which I fixed.
>> 1. long first description
>> 2. missing microblaze: at the beginning

I want to have "microblaze:" at the beginning of email/commit message.
It is much clear for mailing list, Linus and me.

Thanks,
Michal

> 
> Missing what?
> 
>> 3. line longer than 80chars
> 
> Hmm, I thought for sure I had checkpatch.pl claiming all my lines
> were OK.  Odd.  Clearly the one below is longer though.  How strange.
> 
>> Lennart Sorensen wrote:
>>> Fix "Freeing initrd memory:" message on microblaze to show kilobytes as
>>> claimed rather than number of pages.
>>>
>>> Signed-off-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
>>>
>>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>>> index f207f1a..ed5f96b 100644
>>> --- a/arch/microblaze/mm/init.c
>>> +++ b/arch/microblaze/mm/init.c
>>> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>>>  		totalram_pages++;
>>>  		pages++;
>>>  	}
>>> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
>>> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>>>  }
>>>  #endif
>>>  
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze.
  2009-09-21 16:34         ` Michal Simek
@ 2009-09-21 18:03           ` Lennart Sorensen
  0 siblings, 0 replies; 16+ messages in thread
From: Lennart Sorensen @ 2009-09-21 18:03 UTC (permalink / raw)
  To: michal.simek; +Cc: linux-kernel, microblaze-uclinux

On Mon, Sep 21, 2009 at 06:34:01PM +0200, Michal Simek wrote:
> I want to have "microblaze:" at the beginning of email/commit message.
> It is much clear for mailing list, Linus and me.

Hmm, OK.  That makes some sense.  I hadn't ever noticed that being
a trend.

-- 
Len Sorensen

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2009-09-21 18:02 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-15 16:50 [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Lennart Sorensen
2009-09-17  7:38 ` Greg Ungerer
2009-09-17  8:56   ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
2009-09-17 15:21     ` =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Lennart Sorensen
2009-09-17 15:39       ` [microblaze-uclinux] =?us-ascii?Q?=5Bmicroblaze=2Duclinux=5D=20Re=3A=20=5BPATCH=5D=20Actually=20show=20KiB=20rather=20than=20pages=20in=20=22Freeing=20initrd Michal Simek
2009-09-17 15:50         ` Lennart Sorensen
2009-09-17 13:23 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze Yoshinori Sato
2009-09-17 15:46 ` Lennart Sorensen
2009-09-17 15:47   ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on microblaze Lennart Sorensen
2009-09-21 12:39     ` Michal Simek
2009-09-21 13:32       ` Lennart Sorensen
2009-09-21 16:34         ` Michal Simek
2009-09-21 18:03           ` Lennart Sorensen
2009-09-17 15:48 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h8300 Lennart Sorensen
2009-09-17 15:49 ` [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on m68knommu Lennart Sorensen
2009-09-18  0:58   ` Greg Ungerer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.