linux-next: input-current tree build failure

linux-next: input-current tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Hi Dmitry,

Today's linux-next build (x86_64 allmodconfig) failed like this:

In file included from drivers/input/serio/i8042.c:23:
include/linux/i8042.h: In function 'i8042_check_port_owner':
include/linux/i8042.h:58: error: parameter name omitted
drivers/input/serio/i8042.c: At top level:
drivers/input/serio/i8042.c:130: error: redefinition of 'i8042_lock_chip'
include/linux/i8042.h:45: note: previous definition of 'i8042_lock_chip' was here
drivers/input/serio/i8042.c:136: error: redefinition of 'i8042_unlock_chip'
include/linux/i8042.h:49: note: previous definition of 'i8042_unlock_chip' was here
drivers/input/serio/i8042.c:246: error: redefinition of 'i8042_command'
include/linux/i8042.h:53: note: previous definition of 'i8042_command' was here
drivers/input/serio/i8042.c:1193: error: redefinition of 'i8042_check_port_owner'
include/linux/i8042.h:58: note: previous definition of 'i8042_check_port_owner' was here

Caused by commit 1f57f19e6245c5534c3518a8455419461ec06778 ("Input: libps2
- additional locking for i8042 ports").

Please, if you add code that depends on a CONFIG option, build it with
and without the options set ...

I have used the input-current tree from next-20090916 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: input-current tree build failure

[Dmitry Torokhov]

Hi Stephen,

On Thu, Sep 17, 2009 at 11:12:28AM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> In file included from drivers/input/serio/i8042.c:23:
> include/linux/i8042.h: In function 'i8042_check_port_owner':
> include/linux/i8042.h:58: error: parameter name omitted
> drivers/input/serio/i8042.c: At top level:
> drivers/input/serio/i8042.c:130: error: redefinition of 'i8042_lock_chip'
> include/linux/i8042.h:45: note: previous definition of 'i8042_lock_chip' was here
> drivers/input/serio/i8042.c:136: error: redefinition of 'i8042_unlock_chip'
> include/linux/i8042.h:49: note: previous definition of 'i8042_unlock_chip' was here
> drivers/input/serio/i8042.c:246: error: redefinition of 'i8042_command'
> include/linux/i8042.h:53: note: previous definition of 'i8042_command' was here
> drivers/input/serio/i8042.c:1193: error: redefinition of 'i8042_check_port_owner'
> include/linux/i8042.h:58: note: previous definition of 'i8042_check_port_owner' was here
> 
> Caused by commit 1f57f19e6245c5534c3518a8455419461ec06778 ("Input: libps2
> - additional locking for i8042 ports").
> 
> Please, if you add code that depends on a CONFIG option, build it with
> and without the options set ...
> 

I did ;) ... but not as module, sorry about this, will fix in a moment.

-- 
Dmitry