All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alok Kataria <akataria@vmware.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Chris Wright <chrisw@sous-sol.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
	Greg KH <greg@kroah.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Paravirtualization on VMware's Platform [VMI].
Date: Sun, 20 Sep 2009 09:42:47 +0200	[thread overview]
Message-ID: <20090920074247.GA5733@elte.hu> (raw)
In-Reply-To: <1253419185.3253.21.camel@ank32.eng.vmware.com>


* Alok Kataria <akataria@vmware.com> wrote:

> Here is the patch which actually removes the vmi code.
> 
> Signed-off-by: Alok N Kataria <akataria@vmware.com>
> ---
> 
>  Documentation/kernel-parameters.txt |    2 
>  arch/x86/Kconfig                    |   10 
>  arch/x86/include/asm/vmi.h          |  269 ----------
>  arch/x86/include/asm/vmi_time.h     |   98 ----
>  arch/x86/kernel/Makefile            |    1 
>  arch/x86/kernel/setup.c             |    7 
>  arch/x86/kernel/smpboot.c           |    9 
>  arch/x86/kernel/vmi_32.c            |  913 -----------------------------------
>  arch/x86/kernel/vmiclock_32.c       |  321 ------------
>  9 files changed, 1 insertions(+), 1629 deletions(-)
>  delete mode 100644 arch/x86/include/asm/vmi.h
>  delete mode 100644 arch/x86/include/asm/vmi_time.h
>  delete mode 100644 arch/x86/kernel/vmi_32.c
>  delete mode 100644 arch/x86/kernel/vmiclock_32.c

The thing is, the overwhelming majority of vmware users dont benefit 
from hardware features like nested page tables yet. So this needs to be 
done _way_ more carefully, with a proper sunset period of a couple of 
kernel cycles.

This is as if Intel had sent a patch to desupport say Core2 
optimizations, now that Nehalem is out.

'Virtual hardware' is no different in this respect: until users benefit 
from something we want to keep it, even if the vendor would like to sell 
new hardware and would like the new hardware to have an edge over the 
installed base.

If we were able to rip out all (or most) of paravirt from arch/x86 it 
would be tempting for other technical reasons - but the patch above is 
well localized.

	Ingo

  reply	other threads:[~2009-09-20  7:43 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18  0:17 Paravirtualization on VMware's Platform [VMI] Alok Kataria
2009-09-18  0:34 ` Chris Wright
2009-09-18  0:53   ` Jeremy Fitzhardinge
2009-09-18  0:58     ` Chris Wright
2009-09-18  1:43       ` Alok Kataria
2009-09-19  7:43 ` Avi Kivity
2009-09-19 22:44 ` Greg KH
2009-09-20  1:04   ` Jeremy Fitzhardinge
2009-09-20  3:56   ` Alok Kataria
2009-09-20  3:59   ` Alok Kataria
2009-09-20  7:42     ` Ingo Molnar [this message]
2009-09-20  7:52       ` Arjan van de Ven
2009-09-20  9:00         ` Avi Kivity
2009-09-20 15:49           ` Jeremy Fitzhardinge
2009-09-20 19:00             ` Avi Kivity
2009-09-20 19:00               ` Avi Kivity
2009-09-22  8:09             ` Ingo Molnar
2009-09-22 16:52               ` Jeremy Fitzhardinge
2009-09-22 18:02                 ` Ingo Molnar
2009-09-22 18:16                   ` Jeremy Fitzhardinge
2009-09-22 19:04                     ` Ingo Molnar
2009-09-22 19:30                       ` Jeremy Fitzhardinge
2009-09-22  7:22           ` Rusty Russell
2009-09-22 16:53             ` Jeremy Fitzhardinge
2009-09-22 19:30       ` Alok Kataria
2009-09-22 19:47         ` Jeremy Fitzhardinge
2009-09-22 19:47           ` Jeremy Fitzhardinge
2009-09-22 21:27         ` H. Peter Anvin
2009-09-22 21:54           ` Alok Kataria
2009-09-22 22:58             ` H. Peter Anvin
2009-09-23  7:29         ` Gerd Hoffmann
2009-09-29  0:45           ` Alok Kataria
2009-09-29  2:25             ` H. Peter Anvin
2009-09-29  2:25               ` H. Peter Anvin
2009-09-29  3:00               ` Alok Kataria
2009-09-29  9:01                 ` Chris Wright
2009-09-29 17:25                   ` Alok Kataria
2009-09-29 17:27                     ` H. Peter Anvin
2009-09-29 17:36                       ` Alok Kataria
2009-09-29 18:21                     ` Chris Wright
2009-10-08 20:24                 ` [tip:x86/urgent] x86, vmi: Mark VMI deprecated and schedule it for remval tip-bot for Alok Kataria
2009-10-08 20:34                 ` [tip:x86/urgent] x86, vmi: Mark VMI deprecated and schedule it for removal tip-bot for Alok Kataria
2009-09-29  8:08             ` Paravirtualization on VMware's Platform [VMI] Arjan van de Ven
2009-09-29 16:49               ` Alok Kataria
2009-09-29 16:51                 ` H. Peter Anvin
2009-09-29 17:55                 ` Learning question regarding virtio and partvirt_ops Hank Janssen
2009-09-29 19:02                   ` Brian Jackson
2009-10-02  3:00                 ` Paravirtualization on VMware's Platform [VMI] Eric W. Biederman
2009-10-02  3:00                   ` Eric W. Biederman
2009-10-02  4:45                   ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090920074247.GA5733@elte.hu \
    --to=mingo@elte.hu \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=greg@kroah.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.osdl.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.