* [PATCH] xfs: stop calling filemap_fdatawait inside ->fsync
@ 2009-09-26 19:55 Christoph Hellwig
2009-10-07 22:23 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-09-26 19:55 UTC (permalink / raw)
To: xfs
Now that the VFS actually waits for the data I/O to complete before
calling into ->fsync we can stop doing it ourselves.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/xfs/linux-2.6/xfs_file.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_file.c 2009-09-26 14:09:24.933003650 -0300
+++ linux-2.6/fs/xfs/linux-2.6/xfs_file.c 2009-09-26 14:09:46.804256831 -0300
@@ -176,14 +176,7 @@ xfs_file_fsync(
struct dentry *dentry,
int datasync)
{
- struct inode *inode = dentry->d_inode;
struct xfs_inode *ip = XFS_I(inode);
- int error;
-
- /* capture size updates in I/O completion before writing the inode. */
- error = filemap_fdatawait(inode->i_mapping);
- if (error)
- return error;
xfs_iflags_clear(ip, XFS_ITRUNCATED);
return -xfs_fsync(ip);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] xfs: stop calling filemap_fdatawait inside ->fsync
2009-09-26 19:55 [PATCH] xfs: stop calling filemap_fdatawait inside ->fsync Christoph Hellwig
@ 2009-10-07 22:23 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2009-10-07 22:23 UTC (permalink / raw)
To: Christoph Hellwig, xfs
Christoph Hellwig wrote:
> Now that the VFS actually waits for the data I/O to complete before
> calling into ->fsync we can stop doing it ourselves.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_file.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_file.c 2009-09-26 14:09:24.933003650 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_file.c 2009-09-26 14:09:46.804256831 -0300
> @@ -176,14 +176,7 @@ xfs_file_fsync(
> struct dentry *dentry,
> int datasync)
> {
> - struct inode *inode = dentry->d_inode;
> struct xfs_inode *ip = XFS_I(inode);
> - int error;
> -
> - /* capture size updates in I/O completion before writing the inode. */
> - error = filemap_fdatawait(inode->i_mapping);
> - if (error)
> - return error;
>
> xfs_iflags_clear(ip, XFS_ITRUNCATED);
> return -xfs_fsync(ip);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-07 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-26 19:55 [PATCH] xfs: stop calling filemap_fdatawait inside ->fsync Christoph Hellwig
2009-10-07 22:23 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.