All of lore.kernel.org
 help / color / mirror / Atom feed
* + drm-fix-radeon-warnings-when-config_debug_fs.patch added to -mm tree
@ 2009-09-28 23:19 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-09-28 23:19 UTC (permalink / raw)
  To: mm-commits; +Cc: mikpe, airlied


The patch titled
     drm: fix radeon warnings when !CONFIG_DEBUG_FS
has been added to the -mm tree.  Its filename is
     drm-fix-radeon-warnings-when-config_debug_fs.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: drm: fix radeon warnings when !CONFIG_DEBUG_FS
From: Mikael Pettersson <mikpe@it.uu.se>

Compiling the radeon DRM driver with !CONFIG_DEBUG_FS throws the following
warnings:

drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_debugfs_init':
drivers/gpu/drm/radeon/radeon_ttm.c:714: warning: unused variable 'i'
drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
drivers/gpu/drm/radeon/radeon_ttm.c:692: warning: 'radeon_mem_types_list' defined but not used
drivers/gpu/drm/radeon/radeon_ttm.c:693: warning: 'radeon_mem_types_names' defined but not used

Fix: move these variables inside the #if defined(CONFIG_DEBUG_FS) block in
radeon_ttm_debugsfs_init(), which is the only place using them.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/gpu/drm/radeon/radeon_ttm.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff -puN drivers/gpu/drm/radeon/radeon_ttm.c~drm-fix-radeon-warnings-when-config_debug_fs drivers/gpu/drm/radeon/radeon_ttm.c
--- a/drivers/gpu/drm/radeon/radeon_ttm.c~drm-fix-radeon-warnings-when-config_debug_fs
+++ a/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -689,9 +689,6 @@ struct ttm_backend *radeon_ttm_backend_c
 
 #define RADEON_DEBUGFS_MEM_TYPES 2
 
-static struct drm_info_list radeon_mem_types_list[RADEON_DEBUGFS_MEM_TYPES];
-static char radeon_mem_types_names[RADEON_DEBUGFS_MEM_TYPES][32];

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-28 23:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-28 23:19 + drm-fix-radeon-warnings-when-config_debug_fs.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.