* [PATCH] rotary_encoder: fix relative axis support
@ 2009-10-01 0:33 H Hartley Sweeten
2009-10-01 9:25 ` Daniel Mack
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2009-10-01 0:33 UTC (permalink / raw)
To: linux-input; +Cc: Daniel Mack
When the rotart_encoder driver is used to report relative axis
information the "steps" in the platform data could be missing
since it's not relevant.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Daniel Mack <daniel@caiaq.de>
---
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
index c806fbf..3b9f588 100644
--- a/drivers/input/misc/rotary_encoder.c
+++ b/drivers/input/misc/rotary_encoder.c
@@ -106,8 +106,8 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
struct input_dev *input;
int err;
- if (!pdata || !pdata->steps) {
- dev_err(&pdev->dev, "invalid platform data\n");
+ if (!pdata) {
+ dev_err(&pdev->dev, "missing platform data\n");
return -ENOENT;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rotary_encoder: fix relative axis support
2009-10-01 0:33 [PATCH] rotary_encoder: fix relative axis support H Hartley Sweeten
@ 2009-10-01 9:25 ` Daniel Mack
2009-10-06 5:05 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mack @ 2009-10-01 9:25 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-input
On Wed, Sep 30, 2009 at 08:33:26PM -0400, H Hartley Sweeten wrote:
> When the rotart_encoder driver is used to report relative axis
> information the "steps" in the platform data could be missing
> since it's not relevant.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Daniel Mack <daniel@caiaq.de>
Acked-by: Daniel Mack <daniel@caiaq.de>
Thanks!
> ---
>
> diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
> index c806fbf..3b9f588 100644
> --- a/drivers/input/misc/rotary_encoder.c
> +++ b/drivers/input/misc/rotary_encoder.c
> @@ -106,8 +106,8 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
> struct input_dev *input;
> int err;
>
> - if (!pdata || !pdata->steps) {
> - dev_err(&pdev->dev, "invalid platform data\n");
> + if (!pdata) {
> + dev_err(&pdev->dev, "missing platform data\n");
> return -ENOENT;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rotary_encoder: fix relative axis support
2009-10-01 9:25 ` Daniel Mack
@ 2009-10-06 5:05 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2009-10-06 5:05 UTC (permalink / raw)
To: Daniel Mack; +Cc: H Hartley Sweeten, linux-input
On Thu, Oct 01, 2009 at 11:25:48AM +0200, Daniel Mack wrote:
> On Wed, Sep 30, 2009 at 08:33:26PM -0400, H Hartley Sweeten wrote:
> > When the rotart_encoder driver is used to report relative axis
> > information the "steps" in the platform data could be missing
> > since it's not relevant.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Daniel Mack <daniel@caiaq.de>
>
> Acked-by: Daniel Mack <daniel@caiaq.de>
>
Applied, thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-06 5:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-01 0:33 [PATCH] rotary_encoder: fix relative axis support H Hartley Sweeten
2009-10-01 9:25 ` Daniel Mack
2009-10-06 5:05 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.