All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: Jeff Moyer <jmoyer@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
	Valdis.Kletnieks@vt.edu, Mike Galbraith <efault@gmx.de>,
	Ingo Molnar <mingo@elte.hu>,
	Ulrich Lukas <stellplatz-nr.13a@datenparkplatz.de>,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, dm-devel@redhat.com,
	nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com,
	mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it,
	ryov@valinux.co.jp, fernando@oss.ntt.co.jp,
	dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
	righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, agk@redhat.com,
	akpm@linux-foundation.org, peterz@infradead.org,
	jmarchan@redhat.com, torvalds@linux-foundation.org,
	riel@redhat.com
Subject: Re: Do we support ioprio on SSDs with NCQ (Was: Re: IO scheduler based IO controller V10)
Date: Tue, 6 Oct 2009 10:41:20 +0200	[thread overview]
Message-ID: <20091006084120.GJ5216@kernel.dk> (raw)
In-Reply-To: <4e5e476b0910051409x33f8365flf32e8e7548d72e79@mail.gmail.com>

On Mon, Oct 05 2009, Corrado Zoccolo wrote:
> On Mon, Oct 5, 2009 at 5:06 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
> > Corrado Zoccolo <czoccolo@gmail.com> writes:
> >
> >> Moreover, I suggest removing also the slice_resid part, since its
> >> semantics doesn't seem consistent.
> >> When computed, it is not the residency, but the remaining time slice.
> >
> > It stands for residual, not residency.  Make more sense?
> It makes sense when computed, but not when used in rb_key computation.
> Why should we postpone queues that where preempted, instead of giving
> them a boost?

We should not, if it is/was working correctly, it should allow both for
increase/descrease of tree position (hence it's a long and can go
negative) to account for both over and under time.

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: dhaval@linux.vnet.ibm.com, peterz@infradead.org,
	dm-devel@redhat.com, dpshah@google.com, agk@redhat.com,
	balbir@linux.vnet.ibm.com, paolo.valente@unimore.it,
	jmarchan@redhat.com, fernando@oss.ntt.co.jp,
	Ulrich Lukas <stellplatz-nr.13a@datenparkplatz.de>,
	mikew@google.com, Jeff Moyer <jmoyer@redhat.com>,
	nauman@google.com, Ingo Molnar <mingo@elte.hu>,
	Vivek Goyal <vgoyal@redhat.com>,
	m-ikeda@ds.jp.nec.com, riel@redhat.com, lizf@cn.fujitsu.com,
	fchecconi@gmail.com, Valdis.Kletnieks@vt.edu,
	containers@lists.linux-foundation.org,
	Mike Galbraith <efault@gmx.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	righi.andrea@gmail.com, torvalds@linux-foundation.org
Subject: Re: Do we support ioprio on SSDs with NCQ (Was: Re: IO scheduler based IO controller V10)
Date: Tue, 6 Oct 2009 10:41:20 +0200	[thread overview]
Message-ID: <20091006084120.GJ5216@kernel.dk> (raw)
In-Reply-To: <4e5e476b0910051409x33f8365flf32e8e7548d72e79@mail.gmail.com>

On Mon, Oct 05 2009, Corrado Zoccolo wrote:
> On Mon, Oct 5, 2009 at 5:06 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
> > Corrado Zoccolo <czoccolo@gmail.com> writes:
> >
> >> Moreover, I suggest removing also the slice_resid part, since its
> >> semantics doesn't seem consistent.
> >> When computed, it is not the residency, but the remaining time slice.
> >
> > It stands for residual, not residency.  Make more sense?
> It makes sense when computed, but not when used in rb_key computation.
> Why should we postpone queues that where preempted, instead of giving
> them a boost?

We should not, if it is/was working correctly, it should allow both for
increase/descrease of tree position (hence it's a long and can go
negative) to account for both over and under time.

-- 
Jens Axboe

  parent reply	other threads:[~2009-10-06  8:41 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 10:55 IO scheduler based IO controller V10 Corrado Zoccolo
2009-10-02 11:04 ` Jens Axboe
     [not found] ` <200910021255.27689.czoccolo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-02 11:04   ` Jens Axboe
2009-10-02 12:49   ` Vivek Goyal
2009-10-02 12:49 ` Vivek Goyal
2009-10-02 12:49   ` Vivek Goyal
     [not found]   ` <20091002124921.GA4494-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-10-02 15:27     ` Corrado Zoccolo
2009-10-02 15:27       ` Corrado Zoccolo
2009-10-02 15:31       ` Vivek Goyal
2009-10-02 15:31         ` Vivek Goyal
     [not found]       ` <4e5e476b0910020827s23e827b1n847c64e355999d4a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-02 15:31         ` Vivek Goyal
2009-10-02 15:32         ` Mike Galbraith
2009-10-02 15:32       ` Mike Galbraith
2009-10-02 15:32         ` Mike Galbraith
2009-10-02 15:40         ` Vivek Goyal
2009-10-02 15:40           ` Vivek Goyal
     [not found]           ` <20091002154020.GC4494-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-10-02 16:03             ` Mike Galbraith
2009-10-02 16:50             ` Valdis.Kletnieks-PjAqaU27lzQ
2009-10-02 16:03           ` Mike Galbraith
2009-10-02 16:50           ` Valdis.Kletnieks
2009-10-02 16:50             ` Valdis.Kletnieks
     [not found]             ` <12774.1254502217-+bZmOdGhbsPr6rcHtW+onFJE71vCis6O@public.gmane.org>
2009-10-02 19:58               ` Vivek Goyal
2009-10-02 19:58             ` Vivek Goyal
2009-10-02 19:58               ` Vivek Goyal
2009-10-02 22:14               ` Corrado Zoccolo
2009-10-02 22:14                 ` Corrado Zoccolo
     [not found]                 ` <4e5e476b0910021514i1b461229t667bed94fd67f140-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-02 22:27                   ` Vivek Goyal
2009-10-02 22:27                 ` Vivek Goyal
2009-10-02 22:27                   ` Vivek Goyal
2009-10-03 12:43                   ` Corrado Zoccolo
2009-10-03 13:38                     ` Do we support ioprio on SSDs with NCQ (Was: Re: IO scheduler based IO controller V10) Vivek Goyal
2009-10-03 13:38                       ` Vivek Goyal
2009-10-04  9:15                       ` Corrado Zoccolo
2009-10-04 12:11                         ` Vivek Goyal
2009-10-04 12:46                           ` Corrado Zoccolo
2009-10-04 16:20                             ` Fabio Checconi
     [not found]                               ` <20091004162005.GH4650-f9ZlEuEWxVeACYmtYXMKmw@public.gmane.org>
2009-10-05 21:21                                 ` Corrado Zoccolo
2009-10-05 21:21                               ` Corrado Zoccolo
2009-10-05 21:21                                 ` Corrado Zoccolo
     [not found]                             ` <4e5e476b0910040546h5f77cd1fo3172fe5c229eb579-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-05 15:06                               ` Jeff Moyer
2009-10-05 15:06                                 ` Jeff Moyer
2009-10-05 21:09                                 ` Corrado Zoccolo
2009-10-05 21:09                                   ` Corrado Zoccolo
     [not found]                                   ` <4e5e476b0910051409x33f8365flf32e8e7548d72e79-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-06  8:41                                     ` Jens Axboe
2009-10-06  8:41                                   ` Jens Axboe [this message]
2009-10-06  8:41                                     ` Jens Axboe
     [not found]                                     ` <20091006084120.GJ5216-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2009-10-06  9:00                                       ` Corrado Zoccolo
2009-10-06  9:00                                     ` Corrado Zoccolo
2009-10-06  9:00                                       ` Corrado Zoccolo
     [not found]                                       ` <4e5e476b0910060200i7c028b3fr4c235bf5f18c3aa1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-06 18:53                                         ` Jens Axboe
2009-10-06 18:53                                       ` Jens Axboe
2009-10-06 18:53                                         ` Jens Axboe
     [not found]                                 ` <x49my457uef.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2009-10-05 21:09                                   ` Corrado Zoccolo
2009-10-06 21:36                               ` Vivek Goyal
2009-10-06 21:36                             ` Vivek Goyal
2009-10-06 21:36                               ` Vivek Goyal
     [not found]                     ` <4e5e476b0910030543o776fb505ka0ce38da9d83b33c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-03 13:38                       ` Vivek Goyal
     [not found]                   ` <20091002222756.GG4494-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-10-03 12:43                     ` IO scheduler based IO controller V10 Corrado Zoccolo
     [not found]               ` <20091002195815.GE4494-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-10-02 22:14                 ` Corrado Zoccolo
     [not found]         ` <1254497520.10392.11.camel-YqMYhexLQo1vAv1Ojkdn7Q@public.gmane.org>
2009-10-02 15:40           ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091006084120.GJ5216@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=czoccolo@gmail.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=dpshah@google.com \
    --cc=efault@gmx.de \
    --cc=fchecconi@gmail.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=jmarchan@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=m-ikeda@ds.jp.nec.com \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=nauman@google.com \
    --cc=paolo.valente@unimore.it \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=righi.andrea@gmail.com \
    --cc=ryov@valinux.co.jp \
    --cc=stellplatz-nr.13a@datenparkplatz.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.