* [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries
[not found] <200910041304.n94D4EM3012660@d01av01.pok.ibm.com>
@ 2009-10-05 14:20 ` Anthony Liguori
2009-10-05 14:30 ` Aurelien Jarno
0 siblings, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2009-10-05 14:20 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Aurelien Jarno
Hi Aurelien,
Could you revert this commit? This breaks save/restore to older guests
and is misusing the savevm versioning mechanism.
Thanks,
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries
2009-10-05 14:20 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries Anthony Liguori
@ 2009-10-05 14:30 ` Aurelien Jarno
2009-10-06 9:29 ` Amit Shah
0 siblings, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2009-10-05 14:30 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Anthony Liguori, qemu-devel
On Mon, Oct 05, 2009 at 09:20:09AM -0500, Anthony Liguori wrote:
> Hi Aurelien,
>
> Could you revert this commit? This breaks save/restore to older guests
> and is misusing the savevm versioning mechanism.
>
Done. Stefan, please see with Anthony for other eepro100 patches.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries
2009-10-05 14:30 ` Aurelien Jarno
@ 2009-10-06 9:29 ` Amit Shah
2009-10-06 9:38 ` Aurelien Jarno
0 siblings, 1 reply; 5+ messages in thread
From: Amit Shah @ 2009-10-06 9:29 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: Anthony Liguori, qemu-devel
On (Mon) Oct 05 2009 [16:30:52], Aurelien Jarno wrote:
> On Mon, Oct 05, 2009 at 09:20:09AM -0500, Anthony Liguori wrote:
> > Hi Aurelien,
> >
> > Could you revert this commit? This breaks save/restore to older guests
> > and is misusing the savevm versioning mechanism.
> >
>
> Done. Stefan, please see with Anthony for other eepro100 patches.
Can you also please indicate in the commit log why a particular commit
is being reverted?
Amit
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries
2009-10-06 9:29 ` Amit Shah
@ 2009-10-06 9:38 ` Aurelien Jarno
2009-10-06 11:25 ` Amit Shah
0 siblings, 1 reply; 5+ messages in thread
From: Aurelien Jarno @ 2009-10-06 9:38 UTC (permalink / raw)
To: Amit Shah; +Cc: Anthony Liguori, qemu-devel
On Tue, Oct 06, 2009 at 02:59:54PM +0530, Amit Shah wrote:
> On (Mon) Oct 05 2009 [16:30:52], Aurelien Jarno wrote:
> > On Mon, Oct 05, 2009 at 09:20:09AM -0500, Anthony Liguori wrote:
> > > Hi Aurelien,
> > >
> > > Could you revert this commit? This breaks save/restore to older guests
> > > and is misusing the savevm versioning mechanism.
> > >
> >
> > Done. Stefan, please see with Anthony for other eepro100 patches.
>
> Can you also please indicate in the commit log why a particular commit
> is being reverted?
Given it has already been committed, is it still possible to do that?
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries
2009-10-06 9:38 ` Aurelien Jarno
@ 2009-10-06 11:25 ` Amit Shah
0 siblings, 0 replies; 5+ messages in thread
From: Amit Shah @ 2009-10-06 11:25 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: Anthony Liguori, qemu-devel
On (Tue) Oct 06 2009 [11:38:11], Aurelien Jarno wrote:
> On Tue, Oct 06, 2009 at 02:59:54PM +0530, Amit Shah wrote:
> > On (Mon) Oct 05 2009 [16:30:52], Aurelien Jarno wrote:
> > > On Mon, Oct 05, 2009 at 09:20:09AM -0500, Anthony Liguori wrote:
> > > > Hi Aurelien,
> > > >
> > > > Could you revert this commit? This breaks save/restore to older guests
> > > > and is misusing the savevm versioning mechanism.
> > > >
> > >
> > > Done. Stefan, please see with Anthony for other eepro100 patches.
> >
> > Can you also please indicate in the commit log why a particular commit
> > is being reverted?
>
> Given it has already been committed, is it still possible to do that?
No; sadly, history cannot be rewritten.
Amit
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-10-06 11:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200910041304.n94D4EM3012660@d01av01.pok.ibm.com>
2009-10-05 14:20 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 3031efa] eepro100: Remove unused device status entries Anthony Liguori
2009-10-05 14:30 ` Aurelien Jarno
2009-10-06 9:29 ` Amit Shah
2009-10-06 9:38 ` Aurelien Jarno
2009-10-06 11:25 ` Amit Shah
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.