* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
@ 2009-10-06 5:15 Demian Martin
2009-10-06 12:21 ` Harald Welte
0 siblings, 1 reply; 9+ messages in thread
From: Demian Martin @ 2009-10-06 5:15 UTC (permalink / raw)
To: liboat; +Cc: tiwai, alsa-devel, HaraldWelte, LoganLi, lydiawang
Li Bo:
I'm not sure how changing the sample rate for SPDIF would have an effect of
the SNR if you are only passing digital signals. I have had excellent
measured results with the Via chipsets at all sample rates up to 192 KHz at
24 bits on the digital output. Perhaps you can explain how you measured the
performance and that may explain your results. Normally if all of the data
of the original file is present then any limit on SNR is a function of the
DAC. If the data is not the same as the original file then there are more
serious issues to be resolved, and it probably would not be useable with
Dolby Digital or DTS.
Higher sample rates for digital content and digital interfaces are becoming
more common and I think it would be a serious mistake to limit the
performance of the platform.
>Hi, Takashi
>According to our HW test, S/PDIF at 48K sample rate has best SNR, so this
limit can make >S/PDIF work better.
Demian Martin
Product Design Service
784 Cary Drive
San Leandro, CA 94577
209 613 6990
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-06 5:15 [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams Demian Martin
@ 2009-10-06 12:21 ` Harald Welte
2009-10-08 5:31 ` Li Bo
0 siblings, 1 reply; 9+ messages in thread
From: Harald Welte @ 2009-10-06 12:21 UTC (permalink / raw)
To: Demian Martin; +Cc: liboat, tiwai, alsa-devel, lydiawang, LoganLi
Hi all,
I agree with the previous posts in this thread.
The use of > 48kHz sample rate is common use today, so if the hardware supports
it, the driver should not disable it.
Since there are some users that successfully use SPDIF with > 48kHz, it cannot
be a general hardware problem. If there's a general hardware problem, then
it would never work for anyone.
If there are some codec chips/variants/versions, or even certain boards that
have bad SPDIf signal performance, then we should black-list those bad
chips/versions/boards, rather than disable the feature for everyone.
Also, as far as I understand, the worst thing that can happen when a "too high"
sample rate is used: It will not work for some users on some hardware. That,
I think, is acceptable (if no workaround / black-list can be created).
This would be different if there are other effects: If the high sample rate
would cause some hardware-lock-up or similar, then it definitely needs to be
disabled.
Regards,
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-06 12:21 ` Harald Welte
@ 2009-10-08 5:31 ` Li Bo
0 siblings, 0 replies; 9+ messages in thread
From: Li Bo @ 2009-10-08 5:31 UTC (permalink / raw)
To: Harald Welte; +Cc: tiwai, Demian Martin, alsa-devel, lydiawang, LoganLi
On Tue, Oct 6, 2009 at 8:21 PM, Harald Welte <laforge@gnumonks.org> wrote:
> Hi all,
>
> I agree with the previous posts in this thread.
>
> The use of > 48kHz sample rate is common use today, so if the hardware supports
> it, the driver should not disable it.
>
> Since there are some users that successfully use SPDIF with > 48kHz, it cannot
> be a general hardware problem. If there's a general hardware problem, then
> it would never work for anyone.
>
> If there are some codec chips/variants/versions, or even certain boards that
> have bad SPDIf signal performance, then we should black-list those bad
> chips/versions/boards, rather than disable the feature for everyone.
>
> Also, as far as I understand, the worst thing that can happen when a "too high"
> sample rate is used: It will not work for some users on some hardware. That,
> I think, is acceptable (if no workaround / black-list can be created).
>
> This would be different if there are other effects: If the high sample rate
> would cause some hardware-lock-up or similar, then it definitely needs to be
> disabled.
>
> Regards,
> --
> - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
> ============================================================================
> "Privacy in residential applications is a desirable marketing option."
> (ETSI EN 300 175-7 Ch. A6)
>
Hi, All
According to the discussion, this patch is canceled, thank you for suggestion.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-06 4:57 ` Li Bo
@ 2009-10-06 6:05 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2009-10-06 6:05 UTC (permalink / raw)
To: Li Bo; +Cc: LoganLi, alsa-devel, HaraldWelte, lydiawang
At Tue, 6 Oct 2009 12:57:14 +0800,
Li Bo wrote:
>
> Sorry, I meant better stability, not SNR.
What kind of stability do you mean?
A sort of hardware limitation? Any software workaround is needed?
thanks,
Takashi
> On Tue, Oct 6, 2009 at 12:41 PM, Li Bo <liboat@gmail.com> wrote:
> > Hi, Takashi
> > According to our HW test, S/PDIF at 48K sample rate has best SNR, so
> > this limit can make S/PDIF work better.
> >
> > On Mon, Oct 5, 2009 at 11:14 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> At Mon, 5 Oct 2009 22:27:43 +0800,
> >> Li Bo wrote:
> >>>
> >>> [ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
> >>>
> >>> Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
> >>
> >> Any reason?
> >>
> >>
> >> Takashi
> >>
> >>>
> >>> Index: sound-2.6/sound/pci/hda/patch_via.c
> >>> ===================================================================
> >>> --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-10-05 15:11:02.000000000 +0800
> >>> +++ sound-2.6/sound/pci/hda/patch_via.c 2009-10-05 15:11:04.000000000 +0800
> >>> @@ -1228,6 +1228,7 @@
> >>> .substreams = 1,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> /* NID is set in via_build_pcms */
> >>> .ops = {
> >>> .open = via_dig_playback_pcm_open,
> >>> @@ -1241,6 +1242,7 @@
> >>> .substreams = 1,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> };
> >>>
> >>> static int via_build_controls(struct hda_codec *codec)
> >>> @@ -2042,6 +2044,7 @@
> >>> .substreams = 1,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> /* NID is set in via_build_pcms */
> >>> .ops = {
> >>> .open = via_dig_playback_pcm_open,
> >>> @@ -2657,6 +2660,7 @@
> >>> .substreams = 1,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> /* NID is set in via_build_pcms */
> >>> .ops = {
> >>> .open = via_dig_playback_pcm_open,
> >>> @@ -3137,6 +3141,7 @@
> >>> .substreams = 2,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> /* NID is set in via_build_pcms */
> >>> .ops = {
> >>> .open = via_dig_playback_pcm_open,
> >>> @@ -3581,6 +3586,7 @@
> >>> .substreams = 2,
> >>> .channels_min = 2,
> >>> .channels_max = 2,
> >>> + .rates = SNDRV_PCM_RATE_48000,
> >>> /* NID is set in via_build_pcms */
> >>> .ops = {
> >>> .open = via_dig_playback_pcm_open,
> >>>
> >>
> >
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-06 4:41 ` Li Bo
@ 2009-10-06 4:57 ` Li Bo
2009-10-06 6:05 ` Takashi Iwai
0 siblings, 1 reply; 9+ messages in thread
From: Li Bo @ 2009-10-06 4:57 UTC (permalink / raw)
To: Takashi Iwai; +Cc: LoganLi, alsa-devel, HaraldWelte, lydiawang
Sorry, I meant better stability, not SNR.
On Tue, Oct 6, 2009 at 12:41 PM, Li Bo <liboat@gmail.com> wrote:
> Hi, Takashi
> According to our HW test, S/PDIF at 48K sample rate has best SNR, so
> this limit can make S/PDIF work better.
>
> On Mon, Oct 5, 2009 at 11:14 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> At Mon, 5 Oct 2009 22:27:43 +0800,
>> Li Bo wrote:
>>>
>>> [ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
>>>
>>> Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
>>
>> Any reason?
>>
>>
>> Takashi
>>
>>>
>>> Index: sound-2.6/sound/pci/hda/patch_via.c
>>> ===================================================================
>>> --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-10-05 15:11:02.000000000 +0800
>>> +++ sound-2.6/sound/pci/hda/patch_via.c 2009-10-05 15:11:04.000000000 +0800
>>> @@ -1228,6 +1228,7 @@
>>> .substreams = 1,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> /* NID is set in via_build_pcms */
>>> .ops = {
>>> .open = via_dig_playback_pcm_open,
>>> @@ -1241,6 +1242,7 @@
>>> .substreams = 1,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> };
>>>
>>> static int via_build_controls(struct hda_codec *codec)
>>> @@ -2042,6 +2044,7 @@
>>> .substreams = 1,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> /* NID is set in via_build_pcms */
>>> .ops = {
>>> .open = via_dig_playback_pcm_open,
>>> @@ -2657,6 +2660,7 @@
>>> .substreams = 1,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> /* NID is set in via_build_pcms */
>>> .ops = {
>>> .open = via_dig_playback_pcm_open,
>>> @@ -3137,6 +3141,7 @@
>>> .substreams = 2,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> /* NID is set in via_build_pcms */
>>> .ops = {
>>> .open = via_dig_playback_pcm_open,
>>> @@ -3581,6 +3586,7 @@
>>> .substreams = 2,
>>> .channels_min = 2,
>>> .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> /* NID is set in via_build_pcms */
>>> .ops = {
>>> .open = via_dig_playback_pcm_open,
>>>
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-05 15:14 ` Takashi Iwai
2009-10-06 0:07 ` Robert Hancock
@ 2009-10-06 4:41 ` Li Bo
2009-10-06 4:57 ` Li Bo
1 sibling, 1 reply; 9+ messages in thread
From: Li Bo @ 2009-10-06 4:41 UTC (permalink / raw)
To: Takashi Iwai; +Cc: LoganLi, alsa-devel, HaraldWelte, lydiawang
Hi, Takashi
According to our HW test, S/PDIF at 48K sample rate has best SNR, so
this limit can make S/PDIF work better.
On Mon, Oct 5, 2009 at 11:14 PM, Takashi Iwai <tiwai@suse.de> wrote:
> At Mon, 5 Oct 2009 22:27:43 +0800,
> Li Bo wrote:
>>
>> [ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
>>
>> Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
>
> Any reason?
>
>
> Takashi
>
>>
>> Index: sound-2.6/sound/pci/hda/patch_via.c
>> ===================================================================
>> --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-10-05 15:11:02.000000000 +0800
>> +++ sound-2.6/sound/pci/hda/patch_via.c 2009-10-05 15:11:04.000000000 +0800
>> @@ -1228,6 +1228,7 @@
>> .substreams = 1,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> /* NID is set in via_build_pcms */
>> .ops = {
>> .open = via_dig_playback_pcm_open,
>> @@ -1241,6 +1242,7 @@
>> .substreams = 1,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> };
>>
>> static int via_build_controls(struct hda_codec *codec)
>> @@ -2042,6 +2044,7 @@
>> .substreams = 1,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> /* NID is set in via_build_pcms */
>> .ops = {
>> .open = via_dig_playback_pcm_open,
>> @@ -2657,6 +2660,7 @@
>> .substreams = 1,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> /* NID is set in via_build_pcms */
>> .ops = {
>> .open = via_dig_playback_pcm_open,
>> @@ -3137,6 +3141,7 @@
>> .substreams = 2,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> /* NID is set in via_build_pcms */
>> .ops = {
>> .open = via_dig_playback_pcm_open,
>> @@ -3581,6 +3586,7 @@
>> .substreams = 2,
>> .channels_min = 2,
>> .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> /* NID is set in via_build_pcms */
>> .ops = {
>> .open = via_dig_playback_pcm_open,
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-05 15:14 ` Takashi Iwai
@ 2009-10-06 0:07 ` Robert Hancock
2009-10-06 4:41 ` Li Bo
1 sibling, 0 replies; 9+ messages in thread
From: Robert Hancock @ 2009-10-06 0:07 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Li Bo, alsa-devel, HaraldWelte, LoganLi, lydiawang
On Mon, Oct 5, 2009 at 9:14 AM, Takashi Iwai <tiwai@suse.de> wrote:
> At Mon, 5 Oct 2009 22:27:43 +0800,
> Li Bo wrote:
>>
>> [ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
>>
>> Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
>
> Any reason?
Indeed, if this is required it's a pretty bad limitation..
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
2009-10-05 14:27 Li Bo
@ 2009-10-05 15:14 ` Takashi Iwai
2009-10-06 0:07 ` Robert Hancock
2009-10-06 4:41 ` Li Bo
0 siblings, 2 replies; 9+ messages in thread
From: Takashi Iwai @ 2009-10-05 15:14 UTC (permalink / raw)
To: Li Bo; +Cc: LoganLi, alsa-devel, HaraldWelte, lydiawang
At Mon, 5 Oct 2009 22:27:43 +0800,
Li Bo wrote:
>
> [ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
>
> Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
Any reason?
Takashi
>
> Index: sound-2.6/sound/pci/hda/patch_via.c
> ===================================================================
> --- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-10-05 15:11:02.000000000 +0800
> +++ sound-2.6/sound/pci/hda/patch_via.c 2009-10-05 15:11:04.000000000 +0800
> @@ -1228,6 +1228,7 @@
> .substreams = 1,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> /* NID is set in via_build_pcms */
> .ops = {
> .open = via_dig_playback_pcm_open,
> @@ -1241,6 +1242,7 @@
> .substreams = 1,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> };
>
> static int via_build_controls(struct hda_codec *codec)
> @@ -2042,6 +2044,7 @@
> .substreams = 1,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> /* NID is set in via_build_pcms */
> .ops = {
> .open = via_dig_playback_pcm_open,
> @@ -2657,6 +2660,7 @@
> .substreams = 1,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> /* NID is set in via_build_pcms */
> .ops = {
> .open = via_dig_playback_pcm_open,
> @@ -3137,6 +3141,7 @@
> .substreams = 2,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> /* NID is set in via_build_pcms */
> .ops = {
> .open = via_dig_playback_pcm_open,
> @@ -3581,6 +3586,7 @@
> .substreams = 2,
> .channels_min = 2,
> .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> /* NID is set in via_build_pcms */
> .ops = {
> .open = via_dig_playback_pcm_open,
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams.
@ 2009-10-05 14:27 Li Bo
2009-10-05 15:14 ` Takashi Iwai
0 siblings, 1 reply; 9+ messages in thread
From: Li Bo @ 2009-10-05 14:27 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, LoganLi, HaraldWelte, lydiawang
[ALSA] HDA VIA: Add 48K sample rate limit for S/PDIF streams.
Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
Index: sound-2.6/sound/pci/hda/patch_via.c
===================================================================
--- sound-2.6.orig/sound/pci/hda/patch_via.c 2009-10-05 15:11:02.000000000 +0800
+++ sound-2.6/sound/pci/hda/patch_via.c 2009-10-05 15:11:04.000000000 +0800
@@ -1228,6 +1228,7 @@
.substreams = 1,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
/* NID is set in via_build_pcms */
.ops = {
.open = via_dig_playback_pcm_open,
@@ -1241,6 +1242,7 @@
.substreams = 1,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
};
static int via_build_controls(struct hda_codec *codec)
@@ -2042,6 +2044,7 @@
.substreams = 1,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
/* NID is set in via_build_pcms */
.ops = {
.open = via_dig_playback_pcm_open,
@@ -2657,6 +2660,7 @@
.substreams = 1,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
/* NID is set in via_build_pcms */
.ops = {
.open = via_dig_playback_pcm_open,
@@ -3137,6 +3141,7 @@
.substreams = 2,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
/* NID is set in via_build_pcms */
.ops = {
.open = via_dig_playback_pcm_open,
@@ -3581,6 +3586,7 @@
.substreams = 2,
.channels_min = 2,
.channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
/* NID is set in via_build_pcms */
.ops = {
.open = via_dig_playback_pcm_open,
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-10-08 5:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-06 5:15 [PATCH 18/31] HDA patch_via.c: Add 48K sample rate limit for S/PDIF streams Demian Martin
2009-10-06 12:21 ` Harald Welte
2009-10-08 5:31 ` Li Bo
-- strict thread matches above, loose matches on Subject: below --
2009-10-05 14:27 Li Bo
2009-10-05 15:14 ` Takashi Iwai
2009-10-06 0:07 ` Robert Hancock
2009-10-06 4:41 ` Li Bo
2009-10-06 4:57 ` Li Bo
2009-10-06 6:05 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.