* LVM2 daemons/dmeventd/Makefile.in tools/Makefi ...
@ 2009-10-13 1:31 agk
2009-10-13 8:14 ` Zdenek Kabelac
0 siblings, 1 reply; 2+ messages in thread
From: agk @ 2009-10-13 1:31 UTC (permalink / raw)
To: lvm-devel
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2009-10-13 01:31:10
Modified files:
daemons/dmeventd: Makefile.in
tools : Makefile.in
Log message:
More build cleanups (linker parameter ordering).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/Makefile.in.diff?cvsroot=lvm2&r1=1.27&r2=1.28
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/Makefile.in.diff?cvsroot=lvm2&r1=1.101&r2=1.102
--- LVM2/daemons/dmeventd/Makefile.in 2009/10/05 13:46:01 1.27
+++ LVM2/daemons/dmeventd/Makefile.in 2009/10/13 01:31:10 1.28
@@ -45,8 +45,8 @@
LIBS += -ldl -ldevmapper -lpthread
dmeventd: $(LIB_SHARED) $(VERSIONED_SHLIB) dmeventd.o
- $(CC) $(CFLAGS) $(LDFLAGS) -o $@ dmeventd.o \
- -L. -ldevmapper-event $(LIBS) -rdynamic
+ $(CC) $(CFLAGS) $(LDFLAGS) -L. -o $@ dmeventd.o \
+ -ldevmapper-event $(LIBS) -rdynamic
.PHONY: install_dynamic install_static install_include \
install_pkgconfig install_dmeventd
--- LVM2/tools/Makefile.in 2009/10/05 13:46:03 1.101
+++ LVM2/tools/Makefile.in 2009/10/13 01:31:10 1.102
@@ -112,13 +112,12 @@
device-mapper: $(TARGETS_DM)
dmsetup: dmsetup.o $(top_builddir)/libdm/libdevmapper.$(LIB_SUFFIX)
- $(CC) $(CFLAGS) $(LDFLAGS) -o $@ dmsetup.o \
- -L$(top_builddir)/libdm -ldevmapper $(LIBS) $(LIB_PTHREAD)
+ $(CC) $(CFLAGS) $(LDFLAGS) -L$(top_builddir)/libdm \
+ -o $@ dmsetup.o -ldevmapper $(LIBS) $(LIB_PTHREAD)
dmsetup.static: dmsetup.o $(interfacedir)/libdevmapper.a
- $(CC) $(CFLAGS) $(LDFLAGS) -o $@ dmsetup.o -static \
- -L$(interfacedir) -ldevmapper $(LIBS) \
- $(LIB_PTHREAD)
+ $(CC) $(CFLAGS) $(LDFLAGS) -static -L$(interfacedir) \
+ -o $@ dmsetup.o -ldevmapper $(LIBS) $(LIB_PTHREAD)
all: device-mapper
@@ -127,8 +126,9 @@
$(LVMLIBS) $(LIBS) $(LIB_PTHREAD) -rdynamic
lvm.static: $(OBJECTS) lvm-static.o $(top_builddir)/lib/liblvm-internal.a $(interfacedir)/libdevmapper.a
- $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJECTS) lvm-static.o -static \
- -L$(interfacedir) $(LVMLIBS) $(LIBS) $(LIB_PTHREAD) -rdynamic
+ $(CC) $(CFLAGS) $(LDFLAGS) -static -L$(interfacedir) -o $@ \
+ $(OBJECTS) lvm-static.o $(LVMLIBS) $(LIBS) $(LIB_PTHREAD) \
+ -rdynamic
liblvm2cmd.a: $(top_builddir)/lib/liblvm-internal.a $(OBJECTS) lvmcmdlib.o lvm2cmd.o
cat $(top_builddir)/lib/liblvm-internal.a > $@
^ permalink raw reply [flat|nested] 2+ messages in thread
* LVM2 daemons/dmeventd/Makefile.in tools/Makefi ...
2009-10-13 1:31 LVM2 daemons/dmeventd/Makefile.in tools/Makefi agk
@ 2009-10-13 8:14 ` Zdenek Kabelac
0 siblings, 0 replies; 2+ messages in thread
From: Zdenek Kabelac @ 2009-10-13 8:14 UTC (permalink / raw)
To: lvm-devel
Dne 13.10.2009 03:31, agk at sourceware.org napsal(a):
> CVSROOT: /cvs/lvm2
> Module name: LVM2
> Changes by: agk at sourceware.org 2009-10-13 01:31:10
>
> Modified files:
> daemons/dmeventd: Makefile.in
> tools : Makefile.in
>
> Log message:
> More build cleanups (linker parameter ordering).
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/dmeventd/Makefile.in.diff?cvsroot=lvm2&r1=1.27&r2=1.28
> http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/Makefile.in.diff?cvsroot=lvm2&r1=1.101&r2=1.102
>
> --- LVM2/daemons/dmeventd/Makefile.in 2009/10/05 13:46:01 1.27
> +++ LVM2/daemons/dmeventd/Makefile.in 2009/10/13 01:31:10 1.28
> @@ -45,8 +45,8 @@
> LIBS += -ldl -ldevmapper -lpthread
>
> dmeventd: $(LIB_SHARED) $(VERSIONED_SHLIB) dmeventd.o
> - $(CC) $(CFLAGS) $(LDFLAGS) -o $@ dmeventd.o \
> - -L. -ldevmapper-event $(LIBS) -rdynamic
> + $(CC) $(CFLAGS) $(LDFLAGS) -L. -o $@ dmeventd.o \
> + -ldevmapper-event $(LIBS) -rdynamic
>
Hmm - why moving '-L' library path in before '-o' option?
I think the '-L' should be rather right before '-l' library
(i.e. part of LVMLIBS)
LVMLIBS += -L. -ldevmapper-event -lpthread -ldevmapper
or maybe even more complex (eventually partially placed in make.tmpl.in)
DEVMAPLIBS = -L. -ldevmapper
DEVMAPELIBS = -L. -ldevmapper-event -lpthread
LVMLIBS += $(DEVMAPELIBS) $(DEVMAPLIBS)
And actually - why the -L. is used ? We are already changing LDFLAGS in
make.tmpl to support separate build directory. Thus I think -L. should be
possibly avoided in this case ?
Zdenek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-13 1:31 LVM2 daemons/dmeventd/Makefile.in tools/Makefi agk
2009-10-13 8:14 ` Zdenek Kabelac
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.