[PATCH] spufs: Fix test in spufs_switch_log_read()

[PATCH] spufs: Fix test in spufs_switch_log_read()

[Roel Kluin]

size_t len cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Or can this test be removed?

diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index 884e8bc..d4f304f 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -2494,7 +2494,7 @@ static ssize_t spufs_switch_log_read(struct file *file, char __user *buf,
 	struct spu_context *ctx = SPUFS_I(inode)->i_ctx;
 	int error = 0, cnt = 0;
 
-	if (!buf || len < 0)
+	if (!buf || (ssize_t)len < 0)
 		return -EINVAL;
 
 	error = spu_acquire(ctx);

Re: [Cbe-oss-dev] [PATCH] spufs: Fix test in spufs_switch_log_read()

[Jeremy Kerr]

Roel,

> Or can this test be removed?

I'd prefer just to remove the test.

Cheers,


Jeremy

Re: [Cbe-oss-dev] [PATCH] spufs: Fix test in spufs_switch_log_read()

[Arnd Bergmann]

On Tuesday 13 October 2009, Jeremy Kerr wrote:
> > Or can this test be removed?
> 
> I'd prefer just to remove the test.

Yes, sounds good.

	Arnd <><

Re: [Cbe-oss-dev] [PATCH] spufs: Fix test in spufs_switch_log_read()

[Roel Kluin]

size_t len cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
>>> Or can this test be removed?
>>
>> I'd prefer just to remove the test.
> 
> Yes, sounds good.

If you meant only the left-hand part, here you go:

diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c
index 884e8bc..64a4c2d 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -2494,7 +2494,7 @@ static ssize_t spufs_switch_log_read(struct file *file, char __user *buf,
 	struct spu_context *ctx = SPUFS_I(inode)->i_ctx;
 	int error = 0, cnt = 0;
 
-	if (!buf || len < 0)
+	if (!buf)
 		return -EINVAL;
 
 	error = spu_acquire(ctx);

Re: [Cbe-oss-dev] [PATCH] spufs: Fix test in spufs_switch_log_read()

[Jeremy Kerr]

Roel,

> size_t len cannot be less than 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Thanks!

Jeremy