* linux-next: net tree build warnings
@ 2009-10-14 4:20 Stephen Rothwell
2009-10-14 4:34 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2009-10-14 4:20 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-next, linux-kernel, Arnaldo Carvalho de Melo
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
Hi Dave,
Today's linux-next build (powerpc ppc44x_defconfig) produced these
warnings:
In file included from net/socket.c:94:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/core/scm.c:36:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_sockglue.c:37:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ipv6_sockglue.c:53:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
CONFIG_COMPAT is not set.
Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
Introduce recvmmsg socket syscall").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: linux-next: net tree build warnings
2009-10-14 4:20 linux-next: net tree build warnings Stephen Rothwell
@ 2009-10-14 4:34 ` Stephen Rothwell
2009-10-14 22:11 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2009-10-14 4:34 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-next, linux-kernel, Arnaldo Carvalho de Melo
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
Hi Dave,
On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> warnings:
>
> In file included from net/socket.c:94:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/core/scm.c:36:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/ipv4/ip_sockglue.c:37:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/ipv6/ipv6_sockglue.c:53:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
>
> CONFIG_COMPAT is not set.
>
> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> Introduce recvmmsg socket syscall").
I also get these for i386 and sparc32 defconfig builds.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: linux-next: net tree build warnings
2009-10-14 4:34 ` Stephen Rothwell
@ 2009-10-14 22:11 ` David Miller
2009-10-15 1:55 ` Arnaldo Carvalho de Melo
2009-10-17 2:10 ` [PATCH 1/1] " Arnaldo Carvalho de Melo
0 siblings, 2 replies; 9+ messages in thread
From: David Miller @ 2009-10-14 22:11 UTC (permalink / raw)
To: sfr; +Cc: linux-next, linux-kernel, acme
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 14 Oct 2009 15:34:50 +1100
> On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Today's linux-next build (powerpc ppc44x_defconfig) produced these
>> warnings:
>>
>> In file included from net/socket.c:94:
>> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
>>
>> CONFIG_COMPAT is not set.
>>
>> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
>> Introduce recvmmsg socket syscall").
...
>
> I also get these for i386 and sparc32 defconfig builds.
I've asked Arnaldo to work on fixing this.
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: linux-next: net tree build warnings
2009-10-14 22:11 ` David Miller
@ 2009-10-15 1:55 ` Arnaldo Carvalho de Melo
2009-10-17 2:10 ` [PATCH 1/1] " Arnaldo Carvalho de Melo
1 sibling, 0 replies; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-10-15 1:55 UTC (permalink / raw)
To: David Miller; +Cc: sfr, linux-next, linux-kernel
Em Wed, Oct 14, 2009 at 03:11:37PM -0700, David Miller escreveu:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 14 Oct 2009 15:34:50 +1100
>
> > On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> >> warnings:
> >>
> >> In file included from net/socket.c:94:
> >> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> >>
> >> CONFIG_COMPAT is not set.
> >>
> >> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> >> Introduce recvmmsg socket syscall").
> ...
> >
> > I also get these for i386 and sparc32 defconfig builds.
>
> I've asked Arnaldo to work on fixing this.
I'll fix that early tomorrow.
- Arnaldo
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/1] Re: linux-next: net tree build warnings
2009-10-14 22:11 ` David Miller
2009-10-15 1:55 ` Arnaldo Carvalho de Melo
@ 2009-10-17 2:10 ` Arnaldo Carvalho de Melo
2009-10-20 8:09 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-10-17 2:10 UTC (permalink / raw)
To: David Miller; +Cc: sfr, linux-next, linux-kernel
Em Wed, Oct 14, 2009 at 03:11:37PM -0700, David Miller escreveu:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 14 Oct 2009 15:34:50 +1100
> > On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> >> warnings:
> >> In file included from net/socket.c:94:
> >> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> >> CONFIG_COMPAT is not set.
> >> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> >> Introduce recvmmsg socket syscall").
> > I also get these for i386 and sparc32 defconfig builds.
This one should fix it, thanks for the report!
- Arnaldo
>From ea9776634ed9b0b4a92c53002ea225bca143f47e Mon Sep 17 00:00:00 2001
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Fri, 16 Oct 2009 23:07:15 -0300
Subject: [PATCH] net: Avoid compiler warning for mmsghdr when CONFIG_COMPAT is not selected
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
include/net/compat.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/net/compat.h b/include/net/compat.h
index 9679f05..3c7d4e3 100644
--- a/include/net/compat.h
+++ b/include/net/compat.h
@@ -33,7 +33,11 @@ extern int compat_sock_get_timestamp(struct sock *, struct timeval __user *);
extern int compat_sock_get_timestampns(struct sock *, struct timespec __user *);
#else /* defined(CONFIG_COMPAT) */
-#define compat_msghdr msghdr /* to avoid compiler warnings */
+/*
+ * To avoid compiler warnings:
+ */
+#define compat_msghdr msghdr
+#define compat_mmsghdr mmsghdr
#endif /* defined(CONFIG_COMPAT) */
extern int get_compat_msghdr(struct msghdr *, struct compat_msghdr __user *);
--
1.6.2.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] Re: linux-next: net tree build warnings
2009-10-17 2:10 ` [PATCH 1/1] " Arnaldo Carvalho de Melo
@ 2009-10-20 8:09 ` David Miller
2009-10-20 8:14 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2009-10-20 8:09 UTC (permalink / raw)
To: acme; +Cc: sfr, linux-next, linux-kernel
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri, 16 Oct 2009 23:10:24 -0300
> Subject: [PATCH] net: Avoid compiler warning for mmsghdr when CONFIG_COMPAT is not selected
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Applied, please CC: networking patches to netdev in the future.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] Re: linux-next: net tree build warnings
2009-10-20 8:09 ` David Miller
@ 2009-10-20 8:14 ` Stephen Rothwell
2009-10-20 8:18 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2009-10-20 8:14 UTC (permalink / raw)
To: David Miller; +Cc: acme, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi Dave,
On Tue, 20 Oct 2009 01:09:43 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> Applied, please CC: networking patches to netdev in the future.
Should I maybe cc all the linux-next emails about the net tree to netdev?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] Re: linux-next: net tree build warnings
2009-10-20 8:14 ` Stephen Rothwell
@ 2009-10-20 8:18 ` David Miller
2009-10-20 8:22 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2009-10-20 8:18 UTC (permalink / raw)
To: sfr; +Cc: acme, linux-next, linux-kernel
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 20 Oct 2009 19:14:57 +1100
> On Tue, 20 Oct 2009 01:09:43 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>>
>> Applied, please CC: networking patches to netdev in the future.
>
> Should I maybe cc all the linux-next emails about the net tree to netdev?
Sure, that would help me track things.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-10-20 8:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-14 4:20 linux-next: net tree build warnings Stephen Rothwell
2009-10-14 4:34 ` Stephen Rothwell
2009-10-14 22:11 ` David Miller
2009-10-15 1:55 ` Arnaldo Carvalho de Melo
2009-10-17 2:10 ` [PATCH 1/1] " Arnaldo Carvalho de Melo
2009-10-20 8:09 ` David Miller
2009-10-20 8:14 ` Stephen Rothwell
2009-10-20 8:18 ` David Miller
2009-10-20 8:22 ` Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.