All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Valentin Eduardo (Nokia-D/Helsinki)"
	<eduardo.valentin@nokia.com>,
	"Nurkkala Eero.An (EXT-Offcode/Oulu)"
	<ext-Eero.Nurkkala@nokia.com>
Subject: Re: [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode
Date: Tue, 27 Oct 2009 12:00:09 +0000	[thread overview]
Message-ID: <20091027120009.GA19323@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200910271317.52638.peter.ujfalusi@nokia.com>

On Tue, Oct 27, 2009 at 01:17:52PM +0200, Peter Ujfalusi wrote:
> On Tuesday 27 October 2009 13:07:23 Nurkkala Eero.An (EXT-Offcode/Oulu) wrote:

> > You may wish to double read the message above, as it's quite
> > confusing =)

> Yes it is ;)
> I have left one spinlock around the dma_op_mode, when it also protects the 
> mcbsp->active, so that is why that last sentence.

I have to confess that I'm still not entirely clear what the lock is
supposed to be doing or why it's OK to drop it.  I gather that it's just
that dmap_on_mode() doesn't need a lock at all?

  reply	other threads:[~2009-10-27 12:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 11:00 [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode Peter Ujfalusi
2009-10-27 11:07 ` Eero Nurkkala
2009-10-27 11:17   ` Peter Ujfalusi
2009-10-27 12:00     ` Mark Brown [this message]
2009-10-27 12:04       ` Eero Nurkkala
2009-10-27 12:04       ` [alsa-devel] " Peter Ujfalusi
2009-10-27 14:00   ` Jarkko Nikula
2009-10-28  5:52     ` Peter Ujfalusi
2009-10-28  6:53       ` Eero Nurkkala
2009-10-29  6:35         ` Peter Ujfalusi
2009-10-29  7:15           ` [alsa-devel] " Jarkko Nikula
2009-11-09  7:49             ` Peter Ujfalusi
2009-11-09 13:18               ` Mark Brown
2009-10-29  7:13         ` [alsa-devel] " Jarkko Nikula
2009-11-12 22:17 ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091027120009.GA19323@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=eduardo.valentin@nokia.com \
    --cc=ext-Eero.Nurkkala@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.