From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
To: "Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode
Date: Tue, 27 Oct 2009 13:07:23 +0200 [thread overview]
Message-ID: <1256641643.30157.339.camel@eenurkka-desktop> (raw)
In-Reply-To: <1256641215-26131-1-git-send-email-peter.ujfalusi@nokia.com>
On Tue, 2009-10-27 at 12:00 +0100, Ujfalusi Peter (Nokia-D/Tampere)
wrote:
> The use of the spin lock, which supposed to protect the the
> dma_op_mode causing "INFO: inconsistent lock state" on
> playback start.
> Remove the spin locks around the dma_op_mode, when it's
> purpuse is to protect the dma_op_mode.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
You may wish to double read the message above, as it's quite
confusing =)
Otherwise, that spinlocking is highly unnecessary and things are
far better without than with it. The only case it could be useful
is in SMPs, but OMAPs are not such quite yet - and when they
are, things will need to be re-though anyway.
- Eero
next prev parent reply other threads:[~2009-10-27 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 11:00 [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode Peter Ujfalusi
2009-10-27 11:07 ` Eero Nurkkala [this message]
2009-10-27 11:17 ` Peter Ujfalusi
2009-10-27 12:00 ` Mark Brown
2009-10-27 12:04 ` Eero Nurkkala
2009-10-27 12:04 ` [alsa-devel] " Peter Ujfalusi
2009-10-27 14:00 ` Jarkko Nikula
2009-10-28 5:52 ` Peter Ujfalusi
2009-10-28 6:53 ` Eero Nurkkala
2009-10-29 6:35 ` Peter Ujfalusi
2009-10-29 7:15 ` [alsa-devel] " Jarkko Nikula
2009-11-09 7:49 ` Peter Ujfalusi
2009-11-09 13:18 ` Mark Brown
2009-10-29 7:13 ` [alsa-devel] " Jarkko Nikula
2009-11-12 22:17 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256641643.30157.339.camel@eenurkka-desktop \
--to=ext-eero.nurkkala@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.