* [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64.
@ 2009-09-10 9:37 Tiziano Müller
2009-09-10 9:48 ` David Miller
2009-10-28 19:11 ` John W. Linville
0 siblings, 2 replies; 3+ messages in thread
From: Tiziano Müller @ 2009-09-10 9:37 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
Hi there
I had problems to get my rtl8185 PCI card running on Sparc64: I always
got an error about "No suitable DMA available" followed by an error
that no device could be detected. When comparing the rtl8180 driver to
others I noticed that others are mostly using DMA_BIT_MASK so I changed
the custom mask to DMA_BIT_MASK(32) which fixed my issue.
Cheers,
Tiziano
---
drivers/net/wireless/rtl818x/rtl8180_dev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
index 16429c4..515f562 100644
--- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -850,8 +850,8 @@ static int __devinit rtl8180_probe(struct pci_dev *pdev,
goto err_free_reg;
}
- if ((err = pci_set_dma_mask(pdev, 0xFFFFFF00ULL)) ||
- (err = pci_set_consistent_dma_mask(pdev, 0xFFFFFF00ULL))) {
+ if ((err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) ||
+ (err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)))) {
printk(KERN_ERR "%s (rtl8180): No suitable DMA available\n",
pci_name(pdev));
goto err_free_reg;
--
1.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64.
2009-09-10 9:37 [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64 Tiziano Müller
@ 2009-09-10 9:48 ` David Miller
2009-10-28 19:11 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-09-10 9:48 UTC (permalink / raw)
To: tm; +Cc: linville, linux-wireless
From: Tiziano Müller <tm@dev-zero.ch>
Date: Thu, 10 Sep 2009 11:37:43 +0200
> Hi there
>
> I had problems to get my rtl8185 PCI card running on Sparc64: I always
> got an error about "No suitable DMA available" followed by an error
> that no device could be detected. When comparing the rtl8180 driver to
> others I noticed that others are mostly using DMA_BIT_MASK so I changed
> the custom mask to DMA_BIT_MASK(32) which fixed my issue.
Looks correct to me.
I wonder what it was trying to achieve by clearing the low 8 bits
:-)
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64.
2009-09-10 9:37 [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64 Tiziano Müller
2009-09-10 9:48 ` David Miller
@ 2009-10-28 19:11 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2009-10-28 19:11 UTC (permalink / raw)
To: Tiziano Müller; +Cc: linux-wireless
Can I get a "Signed-off-by:" line from you for this?
Thanks,
John
On Thu, Sep 10, 2009 at 11:37:43AM +0200, Tiziano Müller wrote:
> Hi there
>
> I had problems to get my rtl8185 PCI card running on Sparc64: I always
> got an error about "No suitable DMA available" followed by an error
> that no device could be detected. When comparing the rtl8180 driver to
> others I noticed that others are mostly using DMA_BIT_MASK so I changed
> the custom mask to DMA_BIT_MASK(32) which fixed my issue.
>
> Cheers,
> Tiziano
>
> ---
> drivers/net/wireless/rtl818x/rtl8180_dev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
> index 16429c4..515f562 100644
> --- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
> +++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
> @@ -850,8 +850,8 @@ static int __devinit rtl8180_probe(struct pci_dev *pdev,
> goto err_free_reg;
> }
>
> - if ((err = pci_set_dma_mask(pdev, 0xFFFFFF00ULL)) ||
> - (err = pci_set_consistent_dma_mask(pdev, 0xFFFFFF00ULL))) {
> + if ((err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) ||
> + (err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)))) {
> printk(KERN_ERR "%s (rtl8180): No suitable DMA available\n",
> pci_name(pdev));
> goto err_free_reg;
> --
> 1.6.4
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-28 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-10 9:37 [RFC] rtl8180: change PCI DMA mask to DMA_BIT_MASK(32) to solve "No suitable DMA available" problems on sparc64 Tiziano Müller
2009-09-10 9:48 ` David Miller
2009-10-28 19:11 ` John W. Linville
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.