All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf.
@ 2009-11-03  4:36 Hitoshi Mitake
  2009-11-03  7:33 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Hitoshi Mitake @ 2009-11-03  4:36 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, Rusty Russell, Thomas Gleixner, Peter Zijlstra,
	Mike Galbraith, Arnaldo Carvalho de Melo,
	Frédéric_Weisbecker


Adding general performance benchmarking subsystem to perf.
This patch modifies Makefile of perf to build new source files.

Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
---
 tools/perf/Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 7e190d5..f6f7a6b 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
 BUILTIN_OBJS += builtin-timechart.o
 BUILTIN_OBJS += builtin-top.o
 BUILTIN_OBJS += builtin-trace.o
+BUILTIN_OBJS += builtin-bench.o
+BUILTIN_OBJS += builtin-bench-messaging.o
+BUILTIN_OBJS += builtin-bench-pipe.o
 
 PERFLIBS = $(LIB_FILE)
 
-- 
1.5.6.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf.
  2009-11-03  4:36 [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf Hitoshi Mitake
@ 2009-11-03  7:33 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-11-03  7:33 UTC (permalink / raw)
  To: Hitoshi Mitake
  Cc: linux-kernel, Rusty Russell, Thomas Gleixner, Peter Zijlstra,
	Mike Galbraith, Arnaldo Carvalho de Melo,
	Frédéric_Weisbecker


* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:

> 
> Adding general performance benchmarking subsystem to perf.
> This patch modifies Makefile of perf to build new source files.
> 
> Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Mike Galbraith <efault@gmx.de>
> ---
>  tools/perf/Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7e190d5..f6f7a6b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
>  BUILTIN_OBJS += builtin-timechart.o
>  BUILTIN_OBJS += builtin-top.o
>  BUILTIN_OBJS += builtin-trace.o
> +BUILTIN_OBJS += builtin-bench.o
> +BUILTIN_OBJS += builtin-bench-messaging.o
> +BUILTIN_OBJS += builtin-bench-pipe.o

The series should be bisectable (i.e. build at every step) - so i'd 
suggest to add this Makefile bit to the patch that adds the .c, or move 
the .c addition before the Makefile addition patch.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-03  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-03  4:36 [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf Hitoshi Mitake
2009-11-03  7:33 ` Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.