All of lore.kernel.org
 help / color / mirror / Atom feed
* [alternative-merged] speedstep-ich-use-correct-cpu-in-speedstep_get.patch removed from -mm tree
@ 2009-11-03  7:36 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-11-03  7:36 UTC (permalink / raw)
  To: dave.mueller, davej, e.a.b.piel, linux, rjw, rusty, mm-commits


The patch titled
     speedstep-ich: use correct CPU in speedstep_get()
has been removed from the -mm tree.  Its filename was
     speedstep-ich-use-correct-cpu-in-speedstep_get.patch

This patch was dropped because an alternative patch was merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: speedstep-ich: use correct CPU in speedstep_get()
From: Dave Mueller <dave.mueller@gmx.ch>

It looks like commit 394122ab144dae4b276d74644a2f11c44a60ac5c ("cpumask:
avoid playing with cpus_allowed in speedstep-ich.c") broke the
speedstep-ich driver.

The problem seems to be that speedstep-lib.c:speedstep_get_frequency() is
called with a wrong value as "processor" parameter by the code below,
resulting in a return value of 0.  The "processor" parameter should be the
value returned by "speedstep_detect_processor()"

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14340

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Dominik Brodowski <linux@brodo.de>
Cc: Dave Jones <davej@redhat.com>
Cc: Eric Pielbug <e.a.b.piel@tudelft.nl>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


diff -puN arch/x86/kernel/cpu/cpufreq/speedstep-ich.c~speedstep-ich-use-correct-cpu-in-speedstep_get arch/x86/kernel/cpu/cpufreq/speedstep-ich.c
--- a/arch/x86/kernel/cpu/cpufreq/speedstep-ich.c~speedstep-ich-use-correct-cpu-in-speedstep_get
+++ a/arch/x86/kernel/cpu/cpufreq/speedstep-ich.c
@@ -246,7 +246,7 @@ static void get_freq_data(void *_data)
 
 static unsigned int speedstep_get(unsigned int cpu)
 {
-	struct get_freq_data data = { .processor = cpu };
+	struct get_freq_data data = { .processor = speedstep_processor };
 
 	/* You're supposed to ensure CPU is online. */
 	if (smp_call_function_single(cpu, get_freq_data, &data, 1) != 0)
_

Patches currently in -mm which might be from dave.mueller@gmx.ch are

speedstep-ich-fix-error-caused-by-394122ab144dae4b276d74644a2f11c44a60ac5c.patch
speedstep-ich-use-correct-cpu-in-speedstep_get.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-03  7:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-03  7:36 [alternative-merged] speedstep-ich-use-correct-cpu-in-speedstep_get.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.