From: Antonio Ospite <ospite@studenti.unina.it> To: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: Eric Miao <eric.y.miao@gmail.com>, linux-arm-kernel@lists.infradead.org, openezx-devel@lists.openezx.org, Bart Visscher <bartv@thisnet.nl>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones Date: Wed, 4 Nov 2009 12:35:36 +0100 [thread overview] Message-ID: <20091104123536.9b95d161.ospite@studenti.unina.it> (raw) In-Reply-To: <Pine.LNX.4.64.0911040907400.4837@axis700.grange> [-- Attachment #1: Type: text/plain, Size: 1764 bytes --] On Wed, 4 Nov 2009 09:13:16 +0100 (CET) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > On Wed, 4 Nov 2009, Eric Miao wrote: > > > Hi Antonio, > > > > Patch looks generally OK except for the MFP/GPIO usage, check my > > comments below, thanks. > > > > > +/* camera */ > > > +static int a780_pxacamera_init(struct device *dev) > > > +{ > > > + int err; > > > + > > > + /* > > > + * GPIO50_GPIO is CAM_EN: active low > > > + * GPIO19_GPIO is CAM_RST: active high > > > + */ > > > + err = gpio_request(MFP_PIN_GPIO50, "nCAM_EN"); > > > > Mmm... MFP != GPIO, so this probably should be written simply as: > > > > #define GPIO_nCAM_EN (50) > > ...but without parenthesis, please: > > #define GPIO_nCAM_EN 50 > > same everywhere below > OK. BTW, Guennadi, shouldn't the pxa_camera platform_data expose also an exit() method for symmetry with the init() one, where we can free the requested resources? If you want I think I can add it. [...] > > > + > > > +static int a780_pxacamera_power(struct device *dev, int on) > > > +{ > > > + gpio_set_value(MFP_PIN_GPIO50, on ? 0 : 1); > > > > gpio_set_value(GPIO_nCAM_EN, on ? 0 : 1); > > IMHO better yet > > gpio_set_value(GPIO_nCAM_EN, !on); > > Also throughout the patch below. > > I'm still to look at it miself and maybe provide a couple more comments, > if any. > Ok, thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: ospite@studenti.unina.it (Antonio Ospite) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones Date: Wed, 4 Nov 2009 12:35:36 +0100 [thread overview] Message-ID: <20091104123536.9b95d161.ospite@studenti.unina.it> (raw) In-Reply-To: <Pine.LNX.4.64.0911040907400.4837@axis700.grange> On Wed, 4 Nov 2009 09:13:16 +0100 (CET) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > On Wed, 4 Nov 2009, Eric Miao wrote: > > > Hi Antonio, > > > > Patch looks generally OK except for the MFP/GPIO usage, check my > > comments below, thanks. > > > > > +/* camera */ > > > +static int a780_pxacamera_init(struct device *dev) > > > +{ > > > + ? ? ? int err; > > > + > > > + ? ? ? /* > > > + ? ? ? ?* GPIO50_GPIO is CAM_EN: active low > > > + ? ? ? ?* GPIO19_GPIO is CAM_RST: active high > > > + ? ? ? ?*/ > > > + ? ? ? err = gpio_request(MFP_PIN_GPIO50, "nCAM_EN"); > > > > Mmm... MFP != GPIO, so this probably should be written simply as: > > > > #define GPIO_nCAM_EN (50) > > ...but without parenthesis, please: > > #define GPIO_nCAM_EN 50 > > same everywhere below > OK. BTW, Guennadi, shouldn't the pxa_camera platform_data expose also an exit() method for symmetry with the init() one, where we can free the requested resources? If you want I think I can add it. [...] > > > + > > > +static int a780_pxacamera_power(struct device *dev, int on) > > > +{ > > > + ? ? ? gpio_set_value(MFP_PIN_GPIO50, on ? 0 : 1); > > > > gpio_set_value(GPIO_nCAM_EN, on ? 0 : 1); > > IMHO better yet > > gpio_set_value(GPIO_nCAM_EN, !on); > > Also throughout the patch below. > > I'm still to look at it miself and maybe provide a couple more comments, > if any. > Ok, thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091104/a4c5d482/attachment-0001.sig>
next prev parent reply other threads:[~2009-11-04 11:35 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-11-03 16:45 [PATCH 0/3] ezx: A780/A910 camera, A910 leds, ezx_defconfig update Antonio Ospite 2009-11-03 16:45 ` [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones Antonio Ospite 2009-11-03 16:45 ` Antonio Ospite 2009-11-03 16:45 ` [PATCH 2/3] ezx: Add leds-lp3944 support for A910 EZX phone Antonio Ospite 2009-11-04 6:40 ` Eric Miao 2009-11-13 8:24 ` Eric Miao 2009-11-04 6:38 ` [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones Eric Miao 2009-11-04 6:38 ` Eric Miao 2009-11-04 8:13 ` Guennadi Liakhovetski 2009-11-04 8:13 ` Guennadi Liakhovetski 2009-11-04 11:35 ` Antonio Ospite [this message] 2009-11-04 11:35 ` Antonio Ospite 2009-11-06 16:40 ` Guennadi Liakhovetski 2009-11-06 16:40 ` Guennadi Liakhovetski 2009-11-06 17:05 ` Robert Jarzmik 2009-11-06 17:05 ` Robert Jarzmik 2009-11-06 17:39 ` Antonio Ospite 2009-11-06 17:39 ` Antonio Ospite 2009-11-04 9:14 ` Antonio Ospite 2009-11-04 9:14 ` Antonio Ospite 2009-11-04 9:19 ` Eric Miao 2009-11-04 9:19 ` Eric Miao 2009-11-04 20:47 ` [PATCH 1/3 v2] " Antonio Ospite 2009-11-04 20:47 ` Antonio Ospite 2009-11-04 23:53 ` Guennadi Liakhovetski 2009-11-04 23:53 ` Guennadi Liakhovetski 2009-11-05 2:48 ` Eric Miao 2009-11-05 2:48 ` Eric Miao 2009-11-05 22:44 ` Antonio Ospite 2009-11-05 22:44 ` Antonio Ospite 2009-11-06 14:11 ` Guennadi Liakhovetski 2009-11-06 14:11 ` Guennadi Liakhovetski 2009-11-06 17:29 ` Antonio Ospite 2009-11-06 17:29 ` Antonio Ospite 2009-11-10 9:29 ` Antonio Ospite 2009-11-10 9:29 ` Antonio Ospite 2009-11-10 9:39 ` Guennadi Liakhovetski 2009-11-10 9:39 ` Guennadi Liakhovetski 2009-11-11 11:01 ` [PATCH 1/3 v3] " Antonio Ospite 2009-11-11 11:01 ` Antonio Ospite 2009-11-11 13:55 ` Eric Miao 2009-11-11 13:55 ` Eric Miao 2009-11-11 18:02 ` Guennadi Liakhovetski 2009-11-11 18:02 ` Guennadi Liakhovetski 2009-11-12 14:41 ` Antonio Ospite 2009-11-12 14:41 ` Antonio Ospite 2009-11-12 14:47 ` [PATCH 1/3 v4] " Antonio Ospite 2009-11-12 14:47 ` Antonio Ospite 2009-11-12 20:49 ` Guennadi Liakhovetski 2009-11-12 20:49 ` Guennadi Liakhovetski 2009-11-13 8:23 ` Eric Miao 2009-11-13 8:23 ` Eric Miao 2009-11-10 12:48 ` [PATCH 1/3] ezx: " Antonio Ospite 2009-11-10 12:48 ` Antonio Ospite 2009-11-10 15:13 ` Eric Miao 2009-11-10 15:13 ` Eric Miao 2009-11-03 17:44 ` [PATCH 0/3] ezx: A780/A910 camera, A910 leds, ezx_defconfig update Stefan Schmidt 2009-11-03 20:40 ` Antonio Ospite 2009-11-04 6:42 ` Eric Miao 2009-11-04 7:42 ` Antonio Ospite 2009-11-04 21:35 ` [PATCH 3/3] ezx: Update ezx_defconfig now that ezx-pcap is in Antonio Ospite 2009-11-11 14:08 ` Antonio Ospite 2009-11-13 8:25 ` Eric Miao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091104123536.9b95d161.ospite@studenti.unina.it \ --to=ospite@studenti.unina.it \ --cc=bartv@thisnet.nl \ --cc=eric.y.miao@gmail.com \ --cc=g.liakhovetski@gmx.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=openezx-devel@lists.openezx.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.