From: Harald Welte <laforge@gnumonks.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
ben-linux@fluff.org, bhmin@samsung.com
Subject: Re: [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device
Date: Fri, 6 Nov 2009 12:29:05 +0900 [thread overview]
Message-ID: <20091106032905.GM3913@prithivi.gnumonks.org> (raw)
In-Reply-To: <1255421482-26455-10-git-send-email-m.szyprowski@samsung.com>
On Tue, Oct 13, 2009 at 10:11:14AM +0200, Marek Szyprowski wrote:
> Samsung S5PC100 has LCD-controller compatible with the one known from
> previous SoCs series. Add required platform setup and support code that
> it can be used with s3c-fb driver.
Once again i like teh idea and purpose of the patch.
However, I don't like that we copy an entire header file and now have two
copies of the same header file in the kernel tree.
> arch/arm/mach-s5pc100/include/mach/regs-fb.h | 259 ++++++++++++++++++++++++++
I'm quite sure that there must be a solution where we can avoid copying the
file to two places.
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
WARNING: multiple messages have this Message-ID (diff)
From: laforge@gnumonks.org (Harald Welte)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device
Date: Fri, 6 Nov 2009 12:29:05 +0900 [thread overview]
Message-ID: <20091106032905.GM3913@prithivi.gnumonks.org> (raw)
In-Reply-To: <1255421482-26455-10-git-send-email-m.szyprowski@samsung.com>
On Tue, Oct 13, 2009 at 10:11:14AM +0200, Marek Szyprowski wrote:
> Samsung S5PC100 has LCD-controller compatible with the one known from
> previous SoCs series. Add required platform setup and support code that
> it can be used with s3c-fb driver.
Once again i like teh idea and purpose of the patch.
However, I don't like that we copy an entire header file and now have two
copies of the same header file in the kernel tree.
> arch/arm/mach-s5pc100/include/mach/regs-fb.h | 259 ++++++++++++++++++++++++++
I'm quite sure that there must be a solution where we can avoid copying the
file to two places.
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
next prev parent reply other threads:[~2009-11-06 3:33 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 8:11 [PATCH] Update Samsung S5PC100 SoC support Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 01/17] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 02/17] ARM: S5PC1XX: registers rename Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 03/17] ARM: S5PC1XX: clock " Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 04/17] ARM: S5PC1XX: clocks reimplementation Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 05/17] ARM: S5PC1XX: add GPIO L banks to register definition Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 06/17] ARM: S5PC1XX: GPIO registers rename Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 07/17] ARM: S5PC1xx: add gpiolib and external/gpio interrupt support Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 08/17] ARM: S5PC1XX: add cpu idle and system reset support Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 10/17] SMDKC100: enable S3C FrameBuffer Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 11/17] drivers: fb: enable S3C FrameBuffer on S5PC1XX platform Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 12/17] ARM: S5PC1xx: add platform helpers for i2c adapter devices Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 13/17] SMDKC100: add I2C0 and I2C1 buses support Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 14/17] drivers: i2c: s3c2410-i2c also on S5PC1XX platform Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 15/17] ARM: S5PC1xx: add platform helpers for SDHCI host controllers Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 16/17] SMDKC100: add SDHCI controllers 0, 1 and 2 support Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-10-13 8:11 ` [PATCH 17/17] drivers: MMC: enable SDHCI-S3C on S5PC1XX platform Marek Szyprowski
2009-10-13 8:11 ` Marek Szyprowski
2009-11-06 3:31 ` [PATCH 15/17] ARM: S5PC1xx: add platform helpers for SDHCI host controllers Harald Welte
2009-11-06 3:31 ` Harald Welte
2009-11-06 3:30 ` [PATCH 13/17] SMDKC100: add I2C0 and I2C1 buses support Harald Welte
2009-11-06 3:30 ` Harald Welte
2009-11-06 3:30 ` [PATCH 12/17] ARM: S5PC1xx: add platform helpers for i2c adapter devices Harald Welte
2009-11-06 3:30 ` Harald Welte
2009-11-06 3:29 ` [PATCH 10/17] SMDKC100: enable S3C FrameBuffer Harald Welte
2009-11-06 3:29 ` Harald Welte
2009-11-06 3:29 ` Harald Welte [this message]
2009-11-06 3:29 ` [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device Harald Welte
2009-11-09 0:02 ` Ben Dooks
2009-11-09 0:02 ` Ben Dooks
2009-11-06 3:26 ` [PATCH 08/17] ARM: S5PC1XX: add cpu idle and system reset support Harald Welte
2009-11-06 3:26 ` Harald Welte
2009-11-06 3:23 ` [PATCH 07/17] ARM: S5PC1xx: add gpiolib and external/gpio interrupt support Harald Welte
2009-11-06 3:23 ` Harald Welte
2009-11-09 0:00 ` Ben Dooks
2009-11-09 0:00 ` Ben Dooks
2009-11-06 3:20 ` [PATCH 06/17] ARM: S5PC1XX: GPIO registers rename Harald Welte
2009-11-06 3:20 ` Harald Welte
2009-11-06 3:20 ` [PATCH 05/17] ARM: S5PC1XX: add GPIO L banks to register definition Harald Welte
2009-11-06 3:20 ` Harald Welte
2009-11-06 3:19 ` [PATCH 03/17] ARM: S5PC1XX: clock registers rename Harald Welte
2009-11-06 3:19 ` Harald Welte
2009-11-06 3:18 ` [PATCH 02/17] ARM: S5PC1XX: " Harald Welte
2009-11-06 3:18 ` Harald Welte
2009-11-06 15:02 ` Marek Szyprowski
2009-11-06 15:02 ` Marek Szyprowski
2009-11-09 0:07 ` Ben Dooks
2009-11-09 0:07 ` Ben Dooks
2009-11-06 8:17 ` tommy.hong
2009-11-06 2:32 ` [PATCH 01/17] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx Harald Welte
2009-11-06 2:32 ` Harald Welte
2009-11-08 23:58 ` Ben Dooks
2009-11-08 23:58 ` Ben Dooks
2009-11-09 2:41 ` Kyungmin Park
2009-11-09 2:41 ` Kyungmin Park
2009-11-09 0:05 ` [PATCH] Update Samsung S5PC100 SoC support Ben Dooks
2009-11-09 0:05 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2009-10-13 7:56 Marek Szyprowski
2009-10-13 7:56 ` [PATCH 01/17] ARM: MM: use 64bytes of L1 cache on plat S5PC1xx Marek Szyprowski
2009-10-13 7:56 ` [PATCH 02/17] ARM: S5PC1XX: registers rename Marek Szyprowski
2009-10-13 7:56 ` [PATCH 03/17] ARM: S5PC1XX: clock " Marek Szyprowski
2009-10-13 7:56 ` [PATCH 04/17] ARM: S5PC1XX: clocks reimplementation Marek Szyprowski
2009-10-13 7:57 ` [PATCH 05/17] ARM: S5PC1XX: add GPIO L banks to register definition Marek Szyprowski
2009-10-13 7:57 ` [PATCH 06/17] ARM: S5PC1XX: GPIO registers rename Marek Szyprowski
2009-10-13 7:57 ` [PATCH 07/17] ARM: S5PC1xx: add gpiolib and external/gpio interrupt support Marek Szyprowski
2009-10-13 7:57 ` [PATCH 08/17] ARM: S5PC1XX: add cpu idle and system reset support Marek Szyprowski
2009-10-13 7:57 ` [PATCH 09/17] ARM: S5PC1xx: add platform helpers for s3c-fb device Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106032905.GM3913@prithivi.gnumonks.org \
--to=laforge@gnumonks.org \
--cc=ben-linux@fluff.org \
--cc=bhmin@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.