Re: [Bug 14537] New: missing compat_ioctl on x86_64

From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Thierry Vignaud <tvignaud@mandriva.com>,
	bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [Bug 14537] New: missing compat_ioctl on x86_64
Date: Sat, 7 Nov 2009 20:14:05 +0100	[thread overview]
Message-ID: <20091107191405.GD5361@elf.ucw.cz> (raw)
In-Reply-To: <200911072006.36904.rjw@sisk.pl>

Hi!

> > > > > - when trying to suspend:
> > > > > ioctl32(s2disk:8164): Unknown cmd fd(4) cmd(400c330d){t:'3';sz:12}
> > > > > arg(ffc190ec) on /dev/snapshot
> > > > > ioctl32(s2disk:8164): Unknown cmd fd(4) cmd(4004330a){t:'3';sz:4} arg(00000806)
> > > > > on /dev/snapshot
> > > > 
> > > > snapshot_ioctl seems to lack compat support completely. Raphael ??
> > > 
> > > It does, but that wouldn't work anyway.  s2disk is one of the things that have
> > > to be native.
> > 
> > Actually... it would be nice to fix that one day, if someone submitted
> > nice patch... :-).   
> 
> It must be fixed in s2disk first, but that would probably require us to drop
> support for older kernels.  Which is not unthinkable, but might hurt some
> users.

It should be possible to check compat_task() and provide interface
userland expects.

But yes, improving interface to be same for 32 and 64bit would
probably be the way, too. (Or did you have something else in mind?)
								Pavel 
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html