From: Stephen Rothwell <sfr@canb.auug.org.au> To: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Thomas Gleixner <tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [patch 09/16] powerpc: Replace old style lock initializer Date: Sun, 8 Nov 2009 18:55:39 +1100 [thread overview] Message-ID: <20091108185539.8d09017e.sfr@canb.auug.org.au> (raw) In-Reply-To: <1257548144.13611.267.camel@pasglop> [-- Attachment #1: Type: text/plain, Size: 929 bytes --] Hi Ben, On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > Looks reasonable. But iseries can be a bitch, so we do need to test it > on monday. It should be safe as the spinlocks cannot be access until after the following ppc_md pointer initialisations are done (and all this happens before the secondary CPUs are started). But, you are right that there is nothing like actually testing with iSeries. :-) > > void __init hpte_init_iSeries(void) > > { > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(iSeries_hlocks); i++) > > + spin_lock_init(&iSeries_hlocks[i]); > > + > > ppc_md.hpte_invalidate = iSeries_hpte_invalidate; > > ppc_md.hpte_updatepp = iSeries_hpte_updatepp; > > ppc_md.hpte_updateboltedpp = iSeries_hpte_updateboltedpp; -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Peter Zijlstra <peterz@infradead.org>, linuxppc-dev@ozlabs.org, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [patch 09/16] powerpc: Replace old style lock initializer Date: Sun, 8 Nov 2009 18:55:39 +1100 [thread overview] Message-ID: <20091108185539.8d09017e.sfr@canb.auug.org.au> (raw) In-Reply-To: <1257548144.13611.267.camel@pasglop> [-- Attachment #1: Type: text/plain, Size: 929 bytes --] Hi Ben, On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > Looks reasonable. But iseries can be a bitch, so we do need to test it > on monday. It should be safe as the spinlocks cannot be access until after the following ppc_md pointer initialisations are done (and all this happens before the secondary CPUs are started). But, you are right that there is nothing like actually testing with iSeries. :-) > > void __init hpte_init_iSeries(void) > > { > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(iSeries_hlocks); i++) > > + spin_lock_init(&iSeries_hlocks[i]); > > + > > ppc_md.hpte_invalidate = iSeries_hpte_invalidate; > > ppc_md.hpte_updatepp = iSeries_hpte_updatepp; > > ppc_md.hpte_updateboltedpp = iSeries_hpte_updateboltedpp; -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-11-08 7:55 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-11-06 22:41 [patch 00/16] Remove old style lock initializers Thomas Gleixner 2009-11-06 22:41 ` [patch 01/16] arm: Replace old style lock initializer Thomas Gleixner 2009-11-06 22:41 ` [patch 02/16] mips: Replace old style spin " Thomas Gleixner 2009-11-06 22:41 ` [patch 03/16] net: Replace old style " Thomas Gleixner 2009-11-07 6:17 ` David Miller 2009-11-06 22:41 ` [patch 04/16] cred: " Thomas Gleixner 2009-11-06 22:41 ` [patch 05/16] pci: " Thomas Gleixner 2009-11-06 23:06 ` Jesse Barnes 2009-11-06 22:41 ` [patch 06/16] sound: " Thomas Gleixner 2009-11-07 9:20 ` Takashi Iwai 2009-11-06 22:41 ` [patch 07/16] um: " Thomas Gleixner 2009-11-09 2:13 ` Américo Wang 2009-11-06 22:41 ` [patch 08/16] sparc: Make atomic locks raw Thomas Gleixner 2009-11-06 22:41 ` Thomas Gleixner 2009-11-07 6:16 ` David Miller 2009-11-07 6:16 ` David Miller 2009-11-06 22:41 ` [patch 09/16] powerpc: Replace old style lock initializer Thomas Gleixner 2009-11-06 22:41 ` Thomas Gleixner 2009-11-06 22:55 ` Benjamin Herrenschmidt 2009-11-06 22:55 ` Benjamin Herrenschmidt 2009-11-08 7:55 ` Stephen Rothwell [this message] 2009-11-08 7:55 ` Stephen Rothwell 2009-11-09 5:15 ` Stephen Rothwell 2009-11-09 5:15 ` Stephen Rothwell 2009-11-09 8:53 ` Benjamin Herrenschmidt 2009-11-09 8:53 ` Benjamin Herrenschmidt 2009-11-06 22:41 ` [patch 10/16] parisc: Replace old style lock init Thomas Gleixner 2009-11-06 22:41 ` Thomas Gleixner 2009-11-08 5:06 ` Kyle McMartin 2009-11-08 16:11 ` Thomas Gleixner 2009-11-06 22:41 ` [patch 11/16] alpha: Replace old style lock initializer Thomas Gleixner 2009-11-06 22:42 ` [patch 12/16] ia64: " Thomas Gleixner 2009-11-06 22:42 ` Thomas Gleixner 2009-11-06 22:42 ` [patch 13/16] sh: " Thomas Gleixner 2009-11-06 22:42 ` Thomas Gleixner 2009-11-09 1:49 ` Paul Mundt 2009-11-09 1:49 ` Paul Mundt 2009-11-06 22:42 ` [patch 14/16] sparc: " Thomas Gleixner 2009-11-06 22:42 ` Thomas Gleixner 2009-11-07 6:18 ` David Miller 2009-11-07 6:18 ` David Miller 2009-11-07 6:20 ` David Miller 2009-11-07 6:20 ` David Miller 2009-11-07 12:16 ` Thomas Gleixner 2009-11-07 12:16 ` Thomas Gleixner 2009-11-08 6:45 ` David Miller 2009-11-08 6:45 ` David Miller 2009-11-06 22:42 ` [patch 15/16] xtensa: " Thomas Gleixner 2009-11-10 9:34 ` Chris Zankel 2009-11-06 22:42 ` [patch 16/16] locking: Remove old style lock initializers Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091108185539.8d09017e.sfr@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=benh@kernel.crashing.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=mingo@elte.hu \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.