[PATCH] libgsf: fix compile error, add missing dependency on gtk+

[PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Petr Štetiar]

This patch fixes this compile error:
main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 recipes/gnome/libgsf_1.14.16.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/gnome/libgsf_1.14.16.bb b/recipes/gnome/libgsf_1.14.16.bb
index 5697275..9405b42 100644
--- a/recipes/gnome/libgsf_1.14.16.bb
+++ b/recipes/gnome/libgsf_1.14.16.bb
@@ -1,7 +1,7 @@
 LICENSE = "GPL"
 SECTION = "libs"
 
-DEPENDS= "libxml2 bzip2 glib-2.0 zlib gtk-doc libbonobo gnome-vfs"
+DEPENDS= "gtk+ libxml2 bzip2 glib-2.0 zlib gtk-doc libbonobo gnome-vfs"
 RDEPENDS = "gconf gnome-vfs"
 
 PACKAGES =+ "${PN}-gnome ${PN}-gnome-dev "
-- 
1.5.6.3

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Phil Blundell]

On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
> This patch fixes this compile error:
> main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory

I wonder if you might be better off depending on gdk-pixbuf rather than
the full gtk+.  Does that work for you?

p.

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Petr Štetiar]

Phil Blundell <pb@reciva.com> [2009-11-08 14:49:54]:

> On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
> > This patch fixes this compile error:
> > main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
> 
> I wonder if you might be better off depending on gdk-pixbuf rather than
> the full gtk+.  Does that work for you?

Yes, it works for me. What should I do now, since the patch has been commited
already? :-)

-- ynezz

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Otavio Salvador]

Hello,

2009/11/8 Petr Štetiar <ynezz@true.cz>:
> Phil Blundell <pb@reciva.com> [2009-11-08 14:49:54]:
>
>> On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
>> > This patch fixes this compile error:
>> > main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
>>
>> I wonder if you might be better off depending on gdk-pixbuf rather than
>> the full gtk+.  Does that work for you?
>
> Yes, it works for me. What should I do now, since the patch has been commited
> already? :-)

Make a new one and bump PR again ;-)

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Petr Štetiar]

Petr Štetiar <ynezz@true.cz> [2009-11-08 17:17:51]:

> Phil Blundell <pb@reciva.com> [2009-11-08 14:49:54]:
> 
> > On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
> > > This patch fixes this compile error:
> > > main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
> > 
> > I wonder if you might be better off depending on gdk-pixbuf rather than
> > the full gtk+.  Does that work for you?
> 
> Yes, it works for me. What should I do now, since the patch has been commited
> already? :-)

I've encoutered few problems when using gdk-pixbuf as dependency, for example
when building Abiword which than needs gdk-linux-fb package as dependency, which
is pulled in by EXTRA_OECONF = "--with-gdktarget=linux-fb" in gdk-pixbuf package.
So I think, that gtk+ in this patch is correct.

-- ynezz

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Otavio Salvador]

Hello,

2009/11/8 Petr Štetiar <ynezz@true.cz>:
> Petr Štetiar <ynezz@true.cz> [2009-11-08 17:17:51]:
>
>> Phil Blundell <pb@reciva.com> [2009-11-08 14:49:54]:
>>
>> > On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
>> > > This patch fixes this compile error:
>> > > main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
>> >
>> > I wonder if you might be better off depending on gdk-pixbuf rather than
>> > the full gtk+.  Does that work for you?
>>
>> Yes, it works for me. What should I do now, since the patch has been commited
>> already? :-)
>
> I've encoutered few problems when using gdk-pixbuf as dependency, for example
> when building Abiword which than needs gdk-linux-fb package as dependency, which
> is pulled in by EXTRA_OECONF = "--with-gdktarget=linux-fb" in gdk-pixbuf package.
> So I think, that gtk+ in this patch is correct.

Maybe add a new package for gdk-linux-fb then?

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Petr Štetiar]

Otavio Salvador <otavio@ossystems.com.br> [2009-11-08 18:33:20]:

> Hello,
> 
> 2009/11/8 Petr Štetiar <ynezz@true.cz>:
> > Petr Štetiar <ynezz@true.cz> [2009-11-08 17:17:51]:
> >
> >> Phil Blundell <pb@reciva.com> [2009-11-08 14:49:54]:
> >>
> >> > On Sun, 2009-11-08 at 15:13 +0100, Petr Štetiar wrote:
> >> > > This patch fixes this compile error:
> >> > > main.c:38:35: error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
> >> >
> >> > I wonder if you might be better off depending on gdk-pixbuf rather than
> >> > the full gtk+.  Does that work for you?
> >>
> >> Yes, it works for me. What should I do now, since the patch has been commited
> >> already? :-)
> >
> > I've encoutered few problems when using gdk-pixbuf as dependency, for example
> > when building Abiword which than needs gdk-linux-fb package as dependency, which
> > is pulled in by EXTRA_OECONF = "--with-gdktarget=linux-fb" in gdk-pixbuf package.
> > So I think, that gtk+ in this patch is correct.
> 
> Maybe add a new package for gdk-linux-fb then?

The real issue, that I just found, is that gdk-pixbuf package overwrites pkgconfig files
of GTK, so it reports GTK version of gdk-pixbuf package 2.10.14 instead of
correct 2.18.3 of current GTK.

Directory gdk-pixbuf-2.10.14-r2/staging-pkg/staging/armv7a-angstrom-linux-gnueabi/usr/lib/pkgconfig
contains:

gdk-2.0.pc
gdk-pixbuf-2.0.pc
gdk-pixbuf-xlib-2.0.pc
gtk+-2.0.pc
gtk+-unix-print-2.0.pc

and content of gtk+-2.0.pc is "Version: 2.10.14". It's then staged, and
Abiword won't compile, because of GTK_VERSION_REQ=2.12.0.

-- ynezz

Re: [PATCH] libgsf: fix compile error, add missing dependency on gtk+

[Otavio Salvador]

Hello,

2009/11/8 Petr Štetiar <ynezz@true.cz>:
> The real issue, that I just found, is that gdk-pixbuf package overwrites pkgconfig files
> of GTK, so it reports GTK version of gdk-pixbuf package 2.10.14 instead of
> correct 2.18.3 of current GTK.

Cool; are you cooking a patch for it?

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br