Re: [PATCH -mmotm 0/8] memcg: recharge at task move

From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <menage@google.com>
Subject: Re: [PATCH -mmotm 0/8] memcg: recharge at task move
Date: Mon, 9 Nov 2009 10:38:06 +0530	[thread overview]
Message-ID: <20091109050806.GB3042@balbir.in.ibm.com> (raw)
In-Reply-To: <20091106141011.3ded1551.nishimura@mxp.nes.nec.co.jp>

* nishimura@mxp.nes.nec.co.jp <nishimura@mxp.nes.nec.co.jp> [2009-11-06 14:10:11]:

> Hi.
> 
> In current memcg, charges associated with a task aren't moved to the new cgroup
> at task move. These patches are for this feature, that is, for recharging to
> the new cgroup and, of course, uncharging from old cgroup at task move.
> 
> Current virsion supports only recharge of non-shared(mapcount == 1) anonymous pages
> and swaps of those pages. I think it's enough as a first step.
>

What is the motivation? Is to provide better accountability? I think
it is worthwhile to look into it, provided the cost of migration is
not too high. It was on my list of things to look at, but I found that
if cpu/memory are mounted together and the cost of migration is high,
it can be a bottleneck in some cases. I'll review the patches a bit
more.

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>