linux-next: rr tree build warnings

linux-next: rr tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

Hi Rusty,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

Introduced by commit 9f94999724555729819ea0143eab1d0529c029d1
("param:param_ops").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: rr tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]

Hi Rusty,

On Mon, 9 Nov 2009 18:31:04 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> 
> Introduced by commit 9f94999724555729819ea0143eab1d0529c029d1
> ("param:param_ops").

I am also getting some section mismatch warnings like this:

WARNING: drivers/mtd/ubi/ubi.o(.data+0x1c0): Section mismatch in reference from the variable __ops_mtd to the function .init.text:ubi_mtd_param_parse()
The variable __ops_mtd references
the function __init ubi_mtd_param_parse()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, 

Which are probably also related to the above change.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: rr tree build warnings

[Rusty Russell]

On Mon, 9 Nov 2009 06:01:04 pm Stephen Rothwell wrote:
> Hi Rusty,
> 
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> 
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'
> 
> Introduced by commit 9f94999724555729819ea0143eab1d0529c029d1
> ("param:param_ops").

Thanks Stephen!  Overzealous conversion; harmless but annoying.

I've fixed this properly now...
Rusty.

Re: linux-next: rr tree build warnings

[Rusty Russell]

On Mon, 9 Nov 2009 06:10:46 pm Stephen Rothwell wrote:
> I am also getting some section mismatch warnings like this:
> 
> WARNING: drivers/mtd/ubi/ubi.o(.data+0x1c0): Section mismatch in reference from the variable __ops_mtd to the function .init.text:ubi_mtd_param_parse()
> The variable __ops_mtd references
> the function __init ubi_mtd_param_parse()

Right.  This needs a new rule in modpost; here's what I've added:

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -97,10 +97,10 @@ struct kparam_array
 
 /* Obsolete - use module_param_cb() */
 #define module_param_call(name, set, get, arg, perm)			\
-	static struct kernel_param_ops __ops_##name =			\
+	static struct kernel_param_ops __param_ops_##name =		\
 		 { (void *)set, (void *)get };				\
 	__module_param_call(MODULE_PARAM_PREFIX,			\
-			    name, &__ops_##name, arg,			\
+			    name, &__param_ops_##name, arg,		\
 			    __same_type(*(arg), bool),			\
 			    (perm) + sizeof(__check_old_set_param(set))*0)
 
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -951,6 +951,13 @@ static int section_mismatch(const char *
  *   fromsec = .data*
  *   atsym   =__param*
  *
+ * Pattern 1a:
+ *   module_param_call() ops can refer to __init set function if permissions=0
+ *   The pattern is identified by:
+ *   tosec   = .init.text
+ *   fromsec = .data*
+ *   atsym   = __param_ops_*
+ *
  * Pattern 2:
  *   Many drivers utilise a *driver container with references to
  *   add, remove, probe functions etc.
@@ -984,6 +991,12 @@ static int secref_whitelist(const char *
 	    (strncmp(fromsym, "__param", strlen("__param")) == 0))
 		return 0;
 
+	/* Check for pattern 1a */
+	if (strcmp(tosec, ".init.text") == 0 &&
+	    match(fromsec, data_sections) &&
+	    (strncmp(fromsym, "__param_ops_", strlen("__param_ops_")) == 0))
+		return 0;
+
 	/* Check for pattern 2 */
 	if (match(tosec, init_exit_sections) &&
 	    match(fromsec, data_sections) &&

Re: linux-next: rr tree build warnings

[Sam Ravnborg]

On Tue, Nov 10, 2009 at 12:50:58PM +1030, Rusty Russell wrote:
> On Mon, 9 Nov 2009 06:10:46 pm Stephen Rothwell wrote:
> > I am also getting some section mismatch warnings like this:
> > 
> > WARNING: drivers/mtd/ubi/ubi.o(.data+0x1c0): Section mismatch in reference from the variable __ops_mtd to the function .init.text:ubi_mtd_param_parse()
> > The variable __ops_mtd references
> > the function __init ubi_mtd_param_parse()
> 
> Right.  This needs a new rule in modpost; here's what I've added:

Looks fine.

Acked-by: Sam Ravnborg <sam@ravnborg.org>

	Sam

linux-next: rr tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 8933 bytes --]

Hi Rusty,

Today's linux-next build (powerpc ppc64_defconfig) produced these
warnings:

arch/powerpc/kernel/sysfs.c: In function 'store_mmcr0':
arch/powerpc/kernel/sysfs.c:187: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_mmcr1':
arch/powerpc/kernel/sysfs.c:188: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc1':
arch/powerpc/kernel/sysfs.c:189: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc2':
arch/powerpc/kernel/sysfs.c:190: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc3':
arch/powerpc/kernel/sysfs.c:191: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc4':
arch/powerpc/kernel/sysfs.c:192: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc5':
arch/powerpc/kernel/sysfs.c:193: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc6':
arch/powerpc/kernel/sysfs.c:194: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc7':
arch/powerpc/kernel/sysfs.c:201: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pmc8':
arch/powerpc/kernel/sysfs.c:202: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_mmcra':
arch/powerpc/kernel/sysfs.c:204: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_purr':
arch/powerpc/kernel/sysfs.c:205: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_spurr':
arch/powerpc/kernel/sysfs.c:206: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_dscr':
arch/powerpc/kernel/sysfs.c:207: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc0':
arch/powerpc/kernel/sysfs.c:216: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc1':
arch/powerpc/kernel/sysfs.c:217: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc2':
arch/powerpc/kernel/sysfs.c:218: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc3':
arch/powerpc/kernel/sysfs.c:219: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc4':
arch/powerpc/kernel/sysfs.c:220: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pa6t_pmc5':
arch/powerpc/kernel/sysfs.c:221: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_hid0':
arch/powerpc/kernel/sysfs.c:223: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_hid1':
arch/powerpc/kernel/sysfs.c:224: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_hid4':
arch/powerpc/kernel/sysfs.c:225: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_hid5':
arch/powerpc/kernel/sysfs.c:226: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima0':
arch/powerpc/kernel/sysfs.c:227: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima1':
arch/powerpc/kernel/sysfs.c:228: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima2':
arch/powerpc/kernel/sysfs.c:229: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima3':
arch/powerpc/kernel/sysfs.c:230: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima4':
arch/powerpc/kernel/sysfs.c:231: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima5':
arch/powerpc/kernel/sysfs.c:232: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima6':
arch/powerpc/kernel/sysfs.c:233: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima7':
arch/powerpc/kernel/sysfs.c:234: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima8':
arch/powerpc/kernel/sysfs.c:235: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ima9':
arch/powerpc/kernel/sysfs.c:236: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_imaat':
arch/powerpc/kernel/sysfs.c:237: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_btcr':
arch/powerpc/kernel/sysfs.c:238: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_pccr':
arch/powerpc/kernel/sysfs.c:239: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_rpccr':
arch/powerpc/kernel/sysfs.c:240: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_der':
arch/powerpc/kernel/sysfs.c:241: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_mer':
arch/powerpc/kernel/sysfs.c:242: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ber':
arch/powerpc/kernel/sysfs.c:243: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_ier':
arch/powerpc/kernel/sysfs.c:244: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_sier':
arch/powerpc/kernel/sysfs.c:245: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_siar':
arch/powerpc/kernel/sysfs.c:246: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_tsr0':
arch/powerpc/kernel/sysfs.c:247: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_tsr1':
arch/powerpc/kernel/sysfs.c:248: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_tsr2':
arch/powerpc/kernel/sysfs.c:249: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type
arch/powerpc/kernel/sysfs.c: In function 'store_tsr3':
arch/powerpc/kernel/sysfs.c:250: warning: passing argument 2 of 'smp_call_function_single' from incompatible pointer type

Caused by commit 971fa46b1a83d63d3610009e44ba5cab039df611
("cpumask:smp_call_function-in-powerpc-sysfs).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: rr tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

Hi Rusty,

Today's linux-next build (sparc32 defconfig) produced these new warnings
(I think they are down to the rr tree:

kernel/workqueue.c: In function 'current_is_keventd':
kernel/workqueue.c:742: warning: unused variable 'cpu'

That I have reported before.

mm/slab.c: In function 'start_cpu_timer':
mm/slab.c:865: warning: initialization from incompatible pointer type
mm/slab.c: At top level:
mm/slab.c:686: warning: 'reap_work' defined but not used

Not sure about that one.

net/xfrm/xfrm_ipcomp.c: In function 'ipcomp_decompress':
net/xfrm/xfrm_ipcomp.c:48: warning: unused variable 'cpu'
net/xfrm/xfrm_ipcomp.c: In function 'ipcomp_compress':
net/xfrm/xfrm_ipcomp.c:142: warning: unused variable 'cpu'

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: rr tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

Hi Rusty,

Today's linux-next build (powerpc ppc64_defconfig) produced these new
warnings:

arch/powerpc/platforms/cell/interrupt.c: In function 'iic_eoi':
arch/powerpc/platforms/cell/interrupt.c:85: warning: initialization from incompatible pointer type
arch/powerpc/platforms/cell/interrupt.c: In function 'iic_get_irq':
arch/powerpc/platforms/cell/interrupt.c:149: warning: assignment from incompatible pointer type
arch/powerpc/platforms/cell/interrupt.c: In function 'init_one_iic':
arch/powerpc/platforms/cell/interrupt.c:353: warning: initialization from incompatible pointer type
arch/powerpc/kernel/sysfs.c:28: warning: 'cache_toplevel' defined but not used

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]