* ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.
@ 2009-11-10 23:58 Krzysztof Halasa
2009-11-11 0:08 ` Lennart Sorensen
2009-11-17 3:18 ` Jeff Garzik
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Halasa @ 2009-11-10 23:58 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, lkml
Tested on IXP425 + CS5536.
Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
index 88a7933..0898213 100644
--- a/drivers/ata/pata_cs5536.c
+++ b/drivers/ata/pata_cs5536.c
@@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
};
static struct ata_port_operations cs5536_port_ops = {
- .inherits = &ata_bmdma_port_ops,
+ .inherits = &ata_bmdma32_port_ops,
.cable_detect = cs5536_cable_detect,
.set_piomode = cs5536_set_piomode,
.set_dmamode = cs5536_set_dmamode,
--
Krzysztof Halasa
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.
2009-11-10 23:58 ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit Krzysztof Halasa
@ 2009-11-11 0:08 ` Lennart Sorensen
2009-11-17 3:18 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Lennart Sorensen @ 2009-11-11 0:08 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: Jeff Garzik, linux-ide, lkml
On Wed, Nov 11, 2009 at 12:58:16AM +0100, Krzysztof Halasa wrote:
> Tested on IXP425 + CS5536.
Well I guess we will find out if it works on the Geode LX + CS5536 and
loongson + CS5536 sometime. I don't know why it wouldn't work.
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> index 88a7933..0898213 100644
> --- a/drivers/ata/pata_cs5536.c
> +++ b/drivers/ata/pata_cs5536.c
> @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> };
>
> static struct ata_port_operations cs5536_port_ops = {
> - .inherits = &ata_bmdma_port_ops,
> + .inherits = &ata_bmdma32_port_ops,
> .cable_detect = cs5536_cable_detect,
> .set_piomode = cs5536_set_piomode,
> .set_dmamode = cs5536_set_dmamode,
--
Len Sorensen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.
2009-11-10 23:58 ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit Krzysztof Halasa
2009-11-11 0:08 ` Lennart Sorensen
@ 2009-11-17 3:18 ` Jeff Garzik
2009-11-17 11:35 ` Thierry Vignaud
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2009-11-17 3:18 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: linux-ide, lkml
On 11/10/2009 06:58 PM, Krzysztof Halasa wrote:
> Tested on IXP425 + CS5536.
>
> Signed-off-by: Krzysztof Hałasa<khc@pm.waw.pl>
>
> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> index 88a7933..0898213 100644
> --- a/drivers/ata/pata_cs5536.c
> +++ b/drivers/ata/pata_cs5536.c
> @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> };
>
> static struct ata_port_operations cs5536_port_ops = {
> - .inherits =&ata_bmdma_port_ops,
> + .inherits =&ata_bmdma32_port_ops,
> .cable_detect = cs5536_cable_detect,
> .set_piomode = cs5536_set_piomode,
> .set_dmamode = cs5536_set_dmamode,
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.
2009-11-17 3:18 ` Jeff Garzik
@ 2009-11-17 11:35 ` Thierry Vignaud
2009-11-17 11:56 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Thierry Vignaud @ 2009-11-17 11:35 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Krzysztof Halasa, linux-ide
Jeff Garzik <jgarzik@pobox.com> writes:
> > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> > index 88a7933..0898213 100644
> > --- a/drivers/ata/pata_cs5536.c
> > +++ b/drivers/ata/pata_cs5536.c
> > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> > };
> >
> > static struct ata_port_operations cs5536_port_ops = {
> > - .inherits =&ata_bmdma_port_ops,
> > + .inherits =&ata_bmdma32_port_ops,
> > .cable_detect = cs5536_cable_detect,
> > .set_piomode = cs5536_set_piomode,
> > .set_dmamode = cs5536_set_dmamode,
>
> applied
Why not rename ata_bmdma_port_ops as ata_bmdma_port_ops16 for
consistency?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.
2009-11-17 11:35 ` Thierry Vignaud
@ 2009-11-17 11:56 ` Alan Cox
0 siblings, 0 replies; 5+ messages in thread
From: Alan Cox @ 2009-11-17 11:56 UTC (permalink / raw)
To: Thierry Vignaud; +Cc: Jeff Garzik, Krzysztof Halasa, linux-ide
On Tue, 17 Nov 2009 12:35:50 +0100
Thierry Vignaud <tvignaud@mandriva.com> wrote:
> Jeff Garzik <jgarzik@pobox.com> writes:
>
> > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> > > index 88a7933..0898213 100644
> > > --- a/drivers/ata/pata_cs5536.c
> > > +++ b/drivers/ata/pata_cs5536.c
> > > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> > > };
> > >
> > > static struct ata_port_operations cs5536_port_ops = {
> > > - .inherits =&ata_bmdma_port_ops,
> > > + .inherits =&ata_bmdma32_port_ops,
> > > .cable_detect = cs5536_cable_detect,
> > > .set_piomode = cs5536_set_piomode,
> > > .set_dmamode = cs5536_set_dmamode,
> >
> > applied
>
> Why not rename ata_bmdma_port_ops as ata_bmdma_port_ops16 for
> consistency?
Because 16bit is the normal default for ATA BMDMA, and because its a ton
of unneccessary churn ?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-17 11:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 23:58 ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit Krzysztof Halasa
2009-11-11 0:08 ` Lennart Sorensen
2009-11-17 3:18 ` Jeff Garzik
2009-11-17 11:35 ` Thierry Vignaud
2009-11-17 11:56 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.