[PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

[PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

[Benjamin LaHaise]

Hello,

I have an out of tree network driver (GPL'd) that would like to make use of 
the unregister_netdevice_queue interface for bulk unregister of devices.  
Add a #define HAVE_UNREGISTER_NETDEV_QUEUE to allow the source to detect 
that the kernel supports this.

		-ben

Signed-off-by: Benjamin LaHaise <bcrl@lhnet.ca
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 465add6..f9e8e0e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1117,6 +1117,7 @@ extern int		dev_close(struct net_device *dev);
 extern void		dev_disable_lro(struct net_device *dev);
 extern int		dev_queue_xmit(struct sk_buff *skb);
 extern int		register_netdevice(struct net_device *dev);
+#define HAVE_UNREGISTER_NETDEV_QUEUE
 extern void		unregister_netdevice_queue(struct net_device *dev,
 						   struct list_head *head);
 extern void		unregister_netdevice_many(struct list_head *head);

Re: [PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

[David Miller]

From: Benjamin LaHaise <bcrl@lhnet.ca>
Date: Tue, 10 Nov 2009 17:00:04 -0500

> I have an out of tree network driver (GPL'd) that would like to make use of 
> the unregister_netdevice_queue interface for bulk unregister of devices.  
> Add a #define HAVE_UNREGISTER_NETDEV_QUEUE to allow the source to detect 
> that the kernel supports this.

Please get your code upstream :-)

We're already overcluttered with these "HAVE_PANTS", "HAVE_JACKET",
"HAVE_KITCHEN", "HAVE_SINK" ugly defines spewed all over netdevice.h,
and I'm not adding any more of that.

Re: [PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

[Benjamin LaHaise]

On Wed, Nov 11, 2009 at 11:24:57AM -0800, David Miller wrote:
> From: Benjamin LaHaise <bcrl@lhnet.ca>
> Date: Tue, 10 Nov 2009 17:00:04 -0500
> 
> > I have an out of tree network driver (GPL'd) that would like to make use of 
> > the unregister_netdevice_queue interface for bulk unregister of devices.  
> > Add a #define HAVE_UNREGISTER_NETDEV_QUEUE to allow the source to detect 
> > that the kernel supports this.
> 
> Please get your code upstream :-)

It's a completely separate PPP & L2TP / PPPoE from the existing code that 
is in tree.  Somehow, I don't think people are interested in merging duplicate 
functionality regardless of what differences there are in the interfaces.

> We're already overcluttered with these "HAVE_PANTS", "HAVE_JACKET",
> "HAVE_KITCHEN", "HAVE_SINK" ugly defines spewed all over netdevice.h,
> and I'm not adding any more of that.

If there was some other way of detecting that the interface is present, 
I'd use it, but there isn't.

		-ben