Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this perticular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

We have addressed the following list of review comments:

1. Removed bfa_cb_queue macros and the corresponding file, #define WWN_NULL, Replaced MAC_ADDRLEN with ETH_ALEN

2. Removed lun_t

3. Removed references to LICENSE.bna

4. Using cpu_to_be64 in bna_dma_addr64() instead of swab64()

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller]

From: Rasesh Mody <rmody@brocade.com>
Date: Tue, 17 Nov 2009 00:30:55 -0800

> This is patch 0/6 which contains the summary of changes we've
> done in this perticular submission for Brocade's BR1010/BR1020
> 10Gb CEE capable ethernet adapter. Source is based against
> net-next-2.6.

I reviewed three of the 6 patches and that was exhausting enough
as-is.  This driver still needs a bit more work, I'd say 2 or
3 more iterations if myself and others can muster the review
energy :-/

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller]

This driver still needs a lot of work.

The number of headers files is rediculious and I see pieces of
information duplicated up to 4 or 5 times (!?!??!)

First, reduce the header files to say two or three.

Next, remove all of the duplicated information.  You have at least two
copies of the PCI device ID in these header files.  There are three or
four definitions of the same statistics data structures.

It's pure bloat, you have to consolidate the content and the number of
header files holding this information.

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller]

Why does the string "Subject: " appear in the subject of
all of your postings?

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this particular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

The changes are as follows:

1) Explicitly included linux/vmalloc.h to address vmalloc errors.

2) Removed unused prototype.

3) Removed trailing blank lines.

We wish this patch to be considered for inclusion in net-next-2.6.

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller]

From: Rasesh Mody <rmody@brocade.com>
Date: Fri, 12 Feb 2010 06:00:57 -0800

> From: Rasesh Mody <rmody@brocade.com>
> 
> This is patch 0/6 which contains the summary of changes we've
> done in this particular submission for Brocade's BR1010/BR1020
> 10Gb CEE capable ethernet adapter. Source is based against
> net-next-2.6.
> 
> The changes are as follows:
> 
> 1) Cleaned up extra BUG_ON()
> 
> 2) Using mutex wherever appropriate
> 
> 3) Using PCI_DEVICE_TABLE
> 
> We wish this patch to be considered for inclusion in net-next-2.6.
> 
> Signed-off-by: Rasesh Mody <rmody@brocade.com>

The driver doesn't build:

drivers/net/bna/bnad.c: In function ‘bnad_alloc_unmap_q’:
drivers/net/bna/bnad.c:850: error: implicit declaration of function ‘vmalloc’
drivers/net/bna/bnad.c:850: warning: assignment makes pointer from integer without a cast
drivers/net/bna/bnad.c: In function ‘bnad_free_txq’:
drivers/net/bna/bnad.c:1319: error: implicit declaration of function ‘vfree’
drivers/net/bna/bnad.c: In function ‘bnad_priv_init’:
drivers/net/bna/bnad.c:3163: warning: assignment makes pointer from integer without a cast

Second, the driver header files make reference to global functions which do
not exist, such as bna_ioctl_init() and friends.  Please remove those.

Lastly, some of the files added have extra trailing empty lines, please remove
them.

Thanks.

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this particular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

The changes are as follows:

1) Cleaned up extra BUG_ON()

2) Using mutex wherever appropriate

3) Using PCI_DEVICE_TABLE

We wish this patch to be considered for inclusion in net-next-2.6.

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this particular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

The changes are as follows:

1) Frimware changes:
	Releasing the firmware buffer
	Using global mutex for synchronizing firmware read
	Using MODULE_FIRMWARE for firmware dependencies

2) Got rid of extra message buffers

3) Using kernel Timers 

4) Removed perm_addr from bnad structure

5) Using roundup in place of DIV_ROUND_UP

6) Miscellaneous cleanup

We wish this patch to be considered for inclusion in net-next-2.6.

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[David Miller]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 19 Dec 2009 02:02:25 +0000

> On Fri, 2009-12-18 at 17:28 -0800, Debashis Dutt wrote:
> [...]
>> We are working on addressing rest of the comments.
> 
> What is the point of re-posting this without addressing the other
> comments?

Agreed, there is no point having people review this if you haven't
addressed the feedback you've already received.

Come back to us when you've done so.

Thanks.

Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Ben Hutchings]

On Fri, 2009-12-18 at 17:28 -0800, Debashis Dutt wrote:
[...]
> We are working on addressing rest of the comments.

What is the point of re-posting this without addressing the other
comments?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Debashis Dutt]

From: Debashis Dutt <ddutt@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this particular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

The changes are as follows:

1. Removed bfa_defs_version.h (David Miller's comments) 

2. Used upper_32_bits & lower_32_bits as appropriate (Stephen Hemminger's
   comments). 

3. Incorporated a couple of patches from Joe Perches
	a) to use kcalloc wherever appropriate
	b) to use pr_level instead of DPRINTK

4. Replaced #defines with readl & writel as required.

5. Upgraded driver version to 2.1.2.1 from 2.1.0.0

We are working on addressing rest of the comments.

Signed-off-by: Debashis Dutt <ddutt@brocade.com>
---
 0 files changed

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Debashis Dutt]

From: Debashis Dutt <ddutt@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this particular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

The changes are as follows:

1. Removed inconsistent comments

2. Removed a couple of unused functions 

3. Addressed most of the review comments received from Joe Perches, Stephen Hemminger, 
   David Miller & others. 

We are working on addressing rest of the comments.

Signed-off-by: Debashis Dutt <ddutt@brocade.com>
---
 0 files changed

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this perticular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

We have addressed the following list of review comments and some some additional changes from our side:

1. Fixed include file names and there by assumption that current working directory is in the header search path

2. Added const qualifier to global variables where appropriate for compiler optimization. 

3. Using bool instead of int wherever appropriate to reduce space consumption

4. Used OS defined macros BUG_ON, ALIGN & DIV_ROUND_UP, wherever possible

5. Removed inappropriate netif_carrier_ok() tests

6. Removed useless prefetch() from Rx path

7. Replaced dev_kfree_skb_any() with the less expensive dev_kfree_skb() in bnad_poll_cq() since this is always called from NAPI poll context.

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this perticular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

We have addressed the following list of review comments:

1. Removed bfa_cb_queue macros and the corresponding file, #define WWN_NULL, Replaced MAC_ADDRLEN with ETH_ALEN

2. Removed lun_t

3. Removed references to LICENSE.bna

4. Using cpu_to_be64 in bna_dma_addr64() instead of swab64()

5. Addressed failure in case of "make allyesconfig"

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed

Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver

[Rasesh Mody]

From: Rasesh Mody <rmody@brocade.com>

This is patch 0/6 which contains the summary of changes we've
done in this perticular submission for Brocade's BR1010/BR1020
10Gb CEE capable ethernet adapter. Source is based against
net-next-2.6.

We wish this patch to be considered for inclusion in net-next-2.6.

Please NOTE we've updated patches to a newer code, based on Brocade
Release 2.1, that has enhancements for better control path
synchronization.

We have addressed the following is a list of review comments apart
from the required clean-up:

1. Removed all the module parameters except bnad_ioc_auto_recover

2. Removed all the proprietary implementation of a driver debug
   logging facility.

3. Fixed bnad_netpoll() for MSIX

4. Removed macros e.g.   NETIF_F_*, SKB_GSO_TCPV4, VMK*,
   BNAD_RXBUF_HEADROOM etc.

5. Removed bnad_ioctl() function

6. Remove call to netif_stop_queue after netif_carrier_off()

7. Removed bnad_get_stats_count()

8. Change return type to netdev_tx_t for bnad_start_xmit()

9. Remove superfluous casting to irq_handler_t

10. Use setup_timer() for timer initialization, use msecs_to_jiffies()
    in mod_timer()

11. Convert BNAD_RESET_Q to a function

12. Removed pci_saved_config from bnad structure

13. Used module_param() to validate module params

14. Removed OS abstraction
        - All endian-ness conversion functions
        - Changed bfa_boolean to bool
        - Changed BFA_[TRUE|FALSE] to true/false

15. Changed naming style for structures : dropped ._s. suffix

16. Removed setting of netdev->trans_start & netdev->last_rx

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 0 files changed