[PATCH] ath5k: Fix I/Q calibration

[PATCH] ath5k: Fix I/Q calibration

[Lukáš Turek]

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

The sign of correction coefficients was lost in the calculations, which
caused high packetloss in 802.11a mode after the results were applied.
Fixed by removing unneccesary and broken AND with a bit mask.

Signed-off-by: Lukas Turek <8an@praha12.net>
---
 drivers/net/wireless/ath/ath5k/phy.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 8959907..6af0a73 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1399,7 +1399,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah,
 	if (i_coffd == 0 || q_coffd == 0)
 		goto done;
 
-	i_coff = ((-iq_corr) / i_coffd) & 0x3f;
+	i_coff = ((-iq_corr) / i_coffd);
 
 	/* Boundary check */
 	if (i_coff > 31)
@@ -1407,7 +1407,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah,
 	if (i_coff < -32)
 		i_coff = -32;
 
-	q_coff = (((s32)i_pwr / q_coffd) - 128) & 0x1f;
+	q_coff = (((s32)i_pwr / q_coffd) - 128);
 
 	/* Boundary check */
 	if (q_coff > 15)
-- 
1.6.4.4

--
Lukas Turek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] ath5k: Fix I/Q calibration

[Nick Kossifidis]

2009/11/20 Lukáš Turek <8an@praha12.net>:
> The sign of correction coefficients was lost in the calculations, which
> caused high packetloss in 802.11a mode after the results were applied.
> Fixed by removing unneccesary and broken AND with a bit mask.
>
> Signed-off-by: Lukas Turek <8an@praha12.net>
> ---
>  drivers/net/wireless/ath/ath5k/phy.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 8959907..6af0a73 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1399,7 +1399,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah,
>        if (i_coffd == 0 || q_coffd == 0)
>                goto done;
>
> -       i_coff = ((-iq_corr) / i_coffd) & 0x3f;
> +       i_coff = ((-iq_corr) / i_coffd);
>
>        /* Boundary check */
>        if (i_coff > 31)
> @@ -1407,7 +1407,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah,
>        if (i_coff < -32)
>                i_coff = -32;
>
> -       q_coff = (((s32)i_pwr / q_coffd) - 128) & 0x1f;
> +       q_coff = (((s32)i_pwr / q_coffd) - 128);
>
>        /* Boundary check */
>        if (q_coff > 15)
> --
> 1.6.4.4


Acked-by: Nick Kossifidis <mickflemm@gmail.com>


-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick