All of
 help / color / mirror / Atom feed
* [patch]race between disconnect and open in usbtouchscreen
@ 2009-11-20 21:13 Oliver Neukum
  2009-11-20 21:22 ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2009-11-20 21:13 UTC (permalink / raw)
  To: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-input-u79uwXL29TY76Z2rM5mHXA, Ondrej Zary, Jiri Kosina,
	Daniel Ritz, Dmitry Torokhov


an open() between killing the urb and unregistering the device
can lead to IO to a disconnected device.


Signed-off-by: Oliver Neukum <>


commit e15f9b41115356ca5399f77bbc6b364c41b7f780
Author: Oliver Neukum <>
Date:   Fri Nov 20 21:50:38 2009 +0100

    usbtouchscreen: fix race between open and disconnect
    the input device must be unregistered before IO is stopped
    so that open cannot restart IO

diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 68ece58..6850b0d 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -1087,8 +1087,8 @@ static void usbtouch_disconnect(struct usb_interface *intf)
 	dbg("%s - usbtouch is initialized, cleaning up", __func__);
 	usb_set_intfdata(intf, NULL);
-	usb_kill_urb(usbtouch->irq);
+	usb_kill_urb(usbtouch->irq);
 	usbtouch_free_buffers(interface_to_usbdev(intf), usbtouch);

To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
More majordomo info at

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-11-23 17:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-20 21:13 [patch]race between disconnect and open in usbtouchscreen Oliver Neukum
2009-11-20 21:22 ` Dmitry Torokhov
2009-11-20 21:49   ` Oliver Neukum
2009-11-23 17:21     ` Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.