From: Alessandro Zummo <a.zummo@towertech.it>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: rtc-linux@googlegroups.com,
Paul Gortmaker <p_gortmaker@yahoo.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [rtc-linux] [PATCH] ARM: NUC900: add rtc controller driver support for NUC900
Date: Mon, 23 Nov 2009 09:21:41 +0100 [thread overview]
Message-ID: <20091123092141.519d0ec1@linux.lan.towertech.it> (raw)
In-Reply-To: <4B0A2D31.5020307@gmail.com>
On Mon, 23 Nov 2009 14:35:29 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:
> Thanks a lot for your advice, and I have fixed my patch.
> But, I have a question ,which is that why do not implement ops->ioctl()
> unless absolutely necessary? and I see many other rtc driver have implemented it.
That's because the RTC framework will provide one
for you if you define the irq functions in your
rtc_ops. check *_irq_enable, irq_set_state, irq_set_freq.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
WARNING: multiple messages have this Message-ID (diff)
From: a.zummo@towertech.it (Alessandro Zummo)
To: linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] [PATCH] ARM: NUC900: add rtc controller driver support for NUC900
Date: Mon, 23 Nov 2009 09:21:41 +0100 [thread overview]
Message-ID: <20091123092141.519d0ec1@linux.lan.towertech.it> (raw)
In-Reply-To: <4B0A2D31.5020307@gmail.com>
On Mon, 23 Nov 2009 14:35:29 +0800
Wan ZongShun <mcuos.com@gmail.com> wrote:
> Thanks a lot for your advice, and I have fixed my patch.
> But, I have a question ,which is that why do not implement ops->ioctl()
> unless absolutely necessary? and I see many other rtc driver have implemented it.
That's because the RTC framework will provide one
for you if you define the irq functions in your
rtc_ops. check *_irq_enable, irq_set_state, irq_set_freq.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-11-23 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 18:14 [PATCH] ARM: NUC900: add rtc controller driver support for NUC900 Wan ZongShun
2009-11-22 18:14 ` Wan ZongShun
2009-11-22 20:41 ` [rtc-linux] " Alessandro Zummo
2009-11-22 20:41 ` Alessandro Zummo
2009-11-23 6:35 ` Wan ZongShun
2009-11-23 6:35 ` Wan ZongShun
2009-11-23 8:21 ` Alessandro Zummo [this message]
2009-11-23 8:21 ` Alessandro Zummo
[not found] <e68bb3470911190026q5bcf73a0r5431de4ce285ed92@mail.gmail.com>
[not found] ` <e68bb3470911200656k16245526la863f2865a3aa4d1@mail.gmail.com>
[not found] ` <D7863ABD8A8A4912A693215721E64C8D@usish.com.cn>
[not found] ` <e68bb3470911230130j7ce8e81cp355de325c5fab759@mail.gmail.com>
2009-11-23 9:59 ` jack wang
2009-11-23 10:05 ` Wan ZongShun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091123092141.519d0ec1@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.